From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#72343: [PATCH] Fix eglot-server-programs for TeX modes Date: Fri, 2 Aug 2024 16:29:45 +0100 Message-ID: References: <87sevtz8xg.fsf@gmail.com> <86msm1z8c4.fsf@gnu.org> <87ttg8k9l6.fsf@gmail.com> <86frrszbep.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000ec6ce7061eb4ff5c" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35883"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 72343@debbugs.gnu.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 02 17:31:55 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sZuG2-00099o-PZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Aug 2024 17:31:54 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sZuFu-0001cK-6o; Fri, 02 Aug 2024 11:31:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZuFs-0001Vh-88 for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2024 11:31:44 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sZuFr-0006ol-V9 for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2024 11:31:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=cM64AVTv51B13lXamOsheOADakHLY7yeZaAnmso7iF4=; b=R9P4ebFcykyJMTUp9eauGD5Tnxm1umb/C42FaZcUA9lw5GPYppfhw3NqgtuRLLNnz+yaDypv7JI+ieC+IelW2NAnCkdfaKuKDarmEYsF4YIfjVgj9hY5avtR6wEOo0vNG/HQR0CTIKpnlPzmLv/AiDQlLYVy9WahHqCygzwj5oI9YM5UhGinqhY2Q9IhjVrEcMEoL82HDwY8Bynazpj9oXl8NgNdLKjxd8/7ztKnVG9VjlQYJQBOK0R5DulQPUOcawA62fWLm1A4zh7mJZPMQmCxOfg2XkSU/QJbjgyAI2Sm0mOgbh/nspZ0QxVqg7x+Lm3I4bMzlZhkjS7Jd2an5w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sZuGA-000400-0E for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2024 11:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Aug 2024 15:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72343 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72343-submit@debbugs.gnu.org id=B72343.172261268815324 (code B ref 72343); Fri, 02 Aug 2024 15:32:01 +0000 Original-Received: (at 72343) by debbugs.gnu.org; 2 Aug 2024 15:31:28 +0000 Original-Received: from localhost ([127.0.0.1]:53654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZuFb-0003z5-Ml for submit@debbugs.gnu.org; Fri, 02 Aug 2024 11:31:28 -0400 Original-Received: from mail-oo1-f47.google.com ([209.85.161.47]:58693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sZuFV-0003yo-19 for 72343@debbugs.gnu.org; Fri, 02 Aug 2024 11:31:25 -0400 Original-Received: by mail-oo1-f47.google.com with SMTP id 006d021491bc7-5d60ab4f25bso2299774eaf.1 for <72343@debbugs.gnu.org>; Fri, 02 Aug 2024 08:31:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722612597; x=1723217397; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cM64AVTv51B13lXamOsheOADakHLY7yeZaAnmso7iF4=; b=J3C/cRhLmeXA4g6UuMgnwNlxe13iZn9/fXTS72rC5JrW/315cW9z8VFENd1tds4Ttv oSyS+tahYtYC0Q/bICaTamK8bMH0nfpbWR/AVcVjN3G08LPnpTRQliPUFrAVw9BONWrA mCcaZqvEGEAnjtUFIUJCGSkaFlb9ulQsAlM5lj38aVLuYrKlQU0yAF+GuK7RYv6MtBIp X4HGqxxD333eUqPs4d6W1gULVWh6+IzxeuNUJYn9013wEWMXb8SKTiphZkYcAzMZYAPy ADaGfV97faTUSrWRTtvLALV4/7goBi0zSBAL4lux/lSSmsXKyWAvWXon6D79JcKIc1eO +K6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722612597; x=1723217397; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cM64AVTv51B13lXamOsheOADakHLY7yeZaAnmso7iF4=; b=invAU0/ekRT5XIP3qJxIzk8I7Fw8xoKYU4+ltf1VhqSRM0iBkK5E1mjv6rMtJsKbDv mql2t2LX15zjfqnOjH51sR5TRnDAc8UbI8Fv0P3w++JI4soQkygT9apMHpLzw6V32cCK gVV4zIZe9gdXtkxhoHeK4+JnzEO5vvA6WoIqtRH4+CSW3Rh9SJ/3cqmdTC/cRLZp9WwL d2x+EC0mJ/nFU5BvLJVOUv5Da4q0+iDNCaAhzoKf/EMzrUIfu7vkHRqBY2/iPY+8vGwA OuTSQ3UCcZPTteYCWwwwIE2CORiUn7RT2027DLq1H00m8xLir4dz72bykNhabtoPYN9r Xh8w== X-Gm-Message-State: AOJu0Ywb4Bzh2C83Vo+z1GNRKU8/hRCx3jf/nefhICfUtZgkcoS4DmI/ PhU7qHZ+rz+10/Y6Q3rcWhQO/oaYB9NodShH9qh1UhKif6cAmc5w8H2CgBBQa+iMSxBm3HhDj8A aG0Gyvz0kZPOZ08FtSUHVxCV763Y= X-Google-Smtp-Source: AGHT+IGtH+0OTT68mNcOPPfq2QndjoUUwxnRG9pD46TF5clAQ5JYarDXpJ1YVnNRNq4+ROsWWdNc2WLXXmIJn2IwAYg= X-Received: by 2002:a05:6870:224f:b0:260:fbc0:96ec with SMTP id 586e51a60fabf-26891e68691mr4691917fac.38.1722612596892; Fri, 02 Aug 2024 08:29:56 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289642 Archived-At: --000000000000ec6ce7061eb4ff5c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Aug 2, 2024 at 4:13=E2=80=AFPM Augusto Stoffel wrote: > > I think guessing "lang" from lang-mode is perfectly fine. > It's not. And increasingly less so. But you're right it should be perfectly possible to ask a mode: "what programming language, if any, are you for?". But it's not. It's a big discussion, I won't go over it. > For the reason noted above, there is no "concise solution" to choose, all > derived modes from tex-mode need to be mentioned explicitly in one way or > another (either to make the guess correct, or to provide manually a > language id). > The solution I gave is more concise in the number of elements of eglot-server-programs. And explicit in what it is doing. > Fine, I can change the patch so that texlab will still run on modes that > it doesn't support (plain TeX and ConTeXt, etc). Just please confirm that > this is the behavior you prefer. > Yes, I prefer patches that do only their stated purpose and no other side effects. Jo=C3=A3o --000000000000ec6ce7061eb4ff5c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Aug 2, 2024 at 4:13=E2=80=AFPM Au= gusto Stoffel <arstoffel@gmail.co= m> wrote:

I think guessing "lang" from lang-mode is perfectly fine. <= /div>

It's not.=C2=A0 And increas= ingly less so.=C2=A0 But you're right it should be perfectly possible t= o ask a mode: "what programming language, if any, are you for?".= =C2=A0 But it's not.=C2=A0 It's a big discussion, I won't go ov= er it.
=C2=A0
For the reason noted above, there i= s no "concise solution" to choose, all derived modes from tex-mod= e need to be mentioned explicitly in one way or another (either to make the= guess correct, or to provide manually a language id).

The solution I gave is more concise in the number o= f elements of eglot-server-programs.=C2=A0 And explicit in what it is doing= .
=C2=A0
<= div dir=3D"auto">
Fine, I can change the patch so that tex= lab will still run on modes that it doesn't support (plain TeX and ConT= eXt, etc). Just please confirm that this is the behavior you prefer.
<= /div>

Yes, I prefer patches that do only th= eir stated purpose and no other side effects.

Jo= =C3=A3o
=C2=A0
--000000000000ec6ce7061eb4ff5c--