From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: New Flymake rewrite in emacs-26 Date: Wed, 4 Oct 2017 17:08:05 +0100 Message-ID: References: <8760bwz5qf.fsf@gmail.com> <83infw1dkz.fsf@gnu.org> <87tvzf9lbg.fsf@metapensiero.it> <87poa39gjb.fsf@metapensiero.it> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a1135acca51486b055abad17e" X-Trace: blaine.gmane.org 1507133335 12833 195.159.176.226 (4 Oct 2017 16:08:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 4 Oct 2017 16:08:55 +0000 (UTC) Cc: emacs-devel To: Lele Gaifax Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 04 18:08:44 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dzmDu-0001qe-EX for ged-emacs-devel@m.gmane.org; Wed, 04 Oct 2017 18:08:38 +0200 Original-Received: from localhost ([::1]:35970 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzmE1-0008NL-RD for ged-emacs-devel@m.gmane.org; Wed, 04 Oct 2017 12:08:45 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzmDp-0008LF-Ne for emacs-devel@gnu.org; Wed, 04 Oct 2017 12:08:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzmDj-0005Yc-5F for emacs-devel@gnu.org; Wed, 04 Oct 2017 12:08:33 -0400 Original-Received: from mail-qt0-x230.google.com ([2607:f8b0:400d:c0d::230]:45855) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dzmDi-0005Y2-Uk for emacs-devel@gnu.org; Wed, 04 Oct 2017 12:08:27 -0400 Original-Received: by mail-qt0-x230.google.com with SMTP id k1so9159992qti.2 for ; Wed, 04 Oct 2017 09:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2AqU5v13bgVtosJozxFnlLiYoRONs0EIYy4SlbG37+4=; b=G2uDoVpS41dX+x6HKYD1skj7ID3zUAwE/UW0vvlP4vuNTii95/bdgOzTQc2ZB395+V Bc/RaPnWcmBuZ/Wa6NnCMeP/v8nES+IZSS4i3jRaehQkjBtxaUjkEtAGNCovqDW8aGGF H7N1joTOaGarAN0LoMNq+GP+7Eyn1co3PCWujmL0PUe+DNloVaVJAcgE2WfyA5zl8CrK LN9bpL/GKYhXf9UYZvZIzDoVUrl/Sxz30sfkvjwhRn0D0IM3LSo7KsdsNS4jsYQY0Hx6 0K8ApDp6aMGnhTzZEw5wL5JqhhxBZbRHhwYwELmcTggUT3l6VlS0NKtbPxrAKcmk2gvF sIOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2AqU5v13bgVtosJozxFnlLiYoRONs0EIYy4SlbG37+4=; b=jIZnDmvtJD9J41DCbEJn0I4vhQNxHIoYJfKAtxslZfn0xDPObzoY4BlbJFHW4/ZfQG neijCpd5otlB5K5uK11eDlwITNB/vkXDE0FPUYERxsoKuSxIXYQVQnNdZNXr7twvIp0o E6sj+38q7UjynKicAhlI0N8OaimjlXdPuBdd/Wl2ssTsEfWFStdxTTZdMlCvRyCJ6k5t mLXsLRUpvi012Pxdr+9gQCqgAdngGpPSZ/fhg2v6AxJVGw3qS6R9l1zeBG0S2kz0Qs8c pAl6/45FAmpdscJp75vuF6CiAWz5Zd2bTmzn90lNj/j9x/aK/ZdWK6cOT4Gbz/Gbv1iP SolA== X-Gm-Message-State: AMCzsaUBziOvihhVdRpwj5lBWU/n0hPJaggiFIDMPlZNlkbMZ/7g+Tz1 suOKGvWv37+wIP9EZQl9nHLPfAJ5xuxeC96DIwXvG2jL X-Google-Smtp-Source: AOwi7QAvHPWpsdtOhu8kHbbjdr885uJGsi42R2LGq3ShFj4jrT87LiOfAOxKFkfw6na4tGAcfEa4Zp7aPOGHjIVqsX0= X-Received: by 10.200.37.65 with SMTP id 1mr13431302qtn.83.1507133305734; Wed, 04 Oct 2017 09:08:25 -0700 (PDT) Original-Received: by 10.12.145.228 with HTTP; Wed, 4 Oct 2017 09:08:05 -0700 (PDT) In-Reply-To: <87poa39gjb.fsf@metapensiero.it> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219077 Archived-At: --001a1135acca51486b055abad17e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Lele Thank you very much for proof-reading the doc. I make a lot of silly mistakes. I wonder if you've read the docstrings in the .el files, too, since that's where most of the new documentation is right now. > Will make a proper bug report with a patch, if you prefer: Neither of those is essential I think. Unless someone disagrees, keep posting to this thread and I'll make a commit crediting you as the author. Thanks, Jo=C3=A3o On Wed, Oct 4, 2017 at 2:41 PM, Lele Gaifax wrote: > Will make a proper bug report with a patch, if you prefer. > > diff --git a/doc/misc/flymake.texi b/doc/misc/flymake.texi > index 5dd72f81e2..18d9d05e62 100644 > --- a/doc/misc/flymake.texi > +++ b/doc/misc/flymake.texi > @@ -182,7 +182,7 @@ Syntax check statuses > @cindex Syntax check statuses > > After syntax check is finished, its status is displayed in the mode > line. > -The following statuses are defined. > +The following statuses are defined: > > @multitable @columnfractions 0.25 0.75 > @item @code{Wait} > @@ -356,7 +356,7 @@ Adding support for a new syntax check tool > @code{init-function} is required to initialize the syntax check, > usually by creating a temporary copy of the buffer contents. The > function must return @code{(list cmd-name arg-list)}. If > -@code{init-function} returns null, syntax check is aborted, by > +@code{init-function} returns null, syntax check is aborted, but > @code{flymake-mode} is not switched off. > > @item cleanup-function > diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el > index 0b28dc31cf..1e959d884c 100644 > --- a/lisp/progmodes/flymake.el > +++ b/lisp/progmodes/flymake.el > @@ -335,7 +335,7 @@ flymake-diagnostic-functions > * the remaining arguments are keyword-value pairs in the > form (:KEY VALUE :KEY2 VALUE2...). Currently, Flymake provides > no such arguments, but backend functions must be prepared to > - accept to accept and possibly ignore any number of them. > + accept and possibly ignore any number of them. > > Backend functions are expected to initiate the buffer check, but > aren't required to complete it check before exiting: if the > > ciao, lele. > -- > nickname: Lele Gaifax | Quando vivr=C3=B2 di quello che ho pensato ieri > real: Emanuele Gaifas | comincer=C3=B2 ad aver paura di chi mi copia. > lele@metapensiero.it | -- Fortunato Depero, 1929. > > > --=20 Jo=C3=A3o T=C3=A1vora --001a1135acca51486b055abad17e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi, Lele=

Thank you very much for = proof-reading the doc. I make a lot of silly mistakes.

I wonder if you've read the docstrings in the .el f= iles, too, since that's where most of the new documentation is right no= w.

= > Will make a proper bug report wi= th a patch, if you prefer:

Neither of= those is essential I think. Unless someone disagrees, keep posting to this thread and=C2=A0I'll make a commit crediting you as th= e author.

Thanks,
= Jo=C3=A3o


On Wed= , Oct 4, 2017 at 2:41 PM, Lele Gaifax <lele@metapensiero.it> wrote:
Will make a= proper bug report with a patch, if you prefer.

=C2=A0 =C2=A0 diff --git a/doc/misc/flymake.texi b/doc/misc/flymake.texi =C2=A0 =C2=A0 index 5dd72f81e2..18d9d05e62 100644
=C2=A0 =C2=A0 --- a/doc/misc/flymake.texi
=C2=A0 =C2=A0 +++ b/doc/misc/flymake.texi
=C2=A0 =C2=A0 @@ -182,7 +182,7 @@ Syntax check statuses
=C2=A0 =C2=A0 =C2=A0@cindex Syntax check statuses

=C2=A0 =C2=A0 =C2=A0After syntax check is finished, its status is displayed= in the mode line.
=C2=A0 =C2=A0 -The following statuses are defined.
=C2=A0 =C2=A0 +The following statuses are defined:

=C2=A0 =C2=A0 =C2=A0@multitable @columnfractions 0.25 0.75
=C2=A0 =C2=A0 =C2=A0@item @code{Wait}
=C2=A0 =C2=A0 @@ -356,7 +356,7 @@ Adding support for a new syntax check too= l
=C2=A0 =C2=A0 =C2=A0@code{init-function} is required to initialize the synt= ax check,
=C2=A0 =C2=A0 =C2=A0usually by creating a temporary copy of the buffer cont= ents.=C2=A0 The
=C2=A0 =C2=A0 =C2=A0function must return @code{(list cmd-name arg-list)}.= =C2=A0 If
=C2=A0 =C2=A0 -@code{init-function} returns null, syntax check is aborted, = by
=C2=A0 =C2=A0 +@code{init-function} returns null, syntax check is aborted, = but
=C2=A0 =C2=A0 =C2=A0@code{flymake-mode} is not switched off.

=C2=A0 =C2=A0 =C2=A0@item cleanup-function
=C2=A0 =C2=A0 diff --gi= t a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
=C2=A0 =C2=A0 index 0b28dc31cf..1e959d884c 100644
=C2=A0 =C2=A0 --- a/lisp/progmodes/flymake.el
=C2=A0 =C2=A0 +++ b/lisp/progmodes/flymake.el
=C2=A0 =C2=A0 @@ -335,7 +335,7 @@ flymake-diagnostic-functions
=C2=A0 =C2=A0 =C2=A0* the remaining arguments are keyword-value pairs in th= e
=C2=A0 =C2=A0 =C2=A0 =C2=A0form (:KEY VALUE :KEY2 VALUE2...).=C2=A0 Current= ly, Flymake provides
=C2=A0 =C2=A0 =C2=A0 =C2=A0no such arguments, but backend functions must be= prepared to
=C2=A0 =C2=A0 -=C2=A0 accept to accept and possibly ignore any number of th= em.
=C2=A0 =C2=A0 +=C2=A0 accept and possibly ignore any number of them.

=C2=A0 =C2=A0 =C2=A0Backend functions are expected to initiate the buffer c= heck, but
=C2=A0 =C2=A0 =C2=A0aren't required to complete it check before exiting= : if the

ciao, lele.
--
nickname: Lele Gaifax | Quando vivr=C3=B2 di quello che ho pensato ieri
real: Emanuele Gaifas | comincer=C3=B2 ad aver paura di chi mi copia.
lele@metapensiero.it=C2=A0 |=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-- Fortunato Dep= ero, 1929.





--
=
Jo=C3=A3o T=C3=A1vora
--001a1135acca51486b055abad17e--