From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Adding support for xref jumping to headers/interfaces Date: Mon, 6 Mar 2023 13:52:48 +0000 Message-ID: References: <1587ddb6-f631-0890-965a-c7acb5729fa6@yandex.ru> <87r0u2ax26.fsf@betli.tmit.bme.hu> <253cdcdd-863e-e8e3-a783-62ce1c570cfb@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37154"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Felician Nemeth , John Yates , Helmut Eller , emacs-devel To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 06 14:53:23 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZBHH-0009Xd-IP for ged-emacs-devel@m.gmane-mx.org; Mon, 06 Mar 2023 14:53:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZBGx-0000ZJ-Jc; Mon, 06 Mar 2023 08:53:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZBGw-0000WC-1d for emacs-devel@gnu.org; Mon, 06 Mar 2023 08:53:02 -0500 Original-Received: from mail-oi1-x22e.google.com ([2607:f8b0:4864:20::22e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZBGu-0004aJ-EE for emacs-devel@gnu.org; Mon, 06 Mar 2023 08:53:01 -0500 Original-Received: by mail-oi1-x22e.google.com with SMTP id be16so315498oib.0 for ; Mon, 06 Mar 2023 05:53:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678110779; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=v/97x/0eAIt9nQVj8eUnW2F3fqAU62N+UgqeNQkEA9I=; b=ERp766h4rV8LJNFjlPC7er+PpBeNTt6K1HfvDBhNnUkS4TFaxrtL2nV0AMwFlpRXJ4 rxnEZiiSS2VKbm2veAkzfvSVZjhNX9ZrPSA8MEcMshVuYUoFHbrHBkItphSaa31Fh9bD piPDMLHd+LS9N3SxJn2GfgFb9ZTagtKp6rDjjiW/69QXMPLyRReDECErLPr7rr+NY78M 0keKUZc8koD0ATCyqLVFhK3/dYmdLT/w+LK7ro4jqDkZtMJD9IfCCWztNZKF5/F5cPe5 jE01Kx30agANs6ZIL2iPP4rf897Z7M3m4tFJ5ht7R+VOT74XLJIh0BJSj8SoiV7bgrIg Qi8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678110779; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v/97x/0eAIt9nQVj8eUnW2F3fqAU62N+UgqeNQkEA9I=; b=KGbWqNRoy8GLnLyBa6Nw2G2Xg8g4HlDX5FWN17/TySMZU3FVBOPwQJ59NM10EWGnRH tuxhSP0n05BFzoJReq9CI7yCuoRWw44OvtJAYWCnxLj46CnUB5Ls9aZNMc6mu+y98wWE gZSAfgSBU/SRikmnsS4A2CYVTaRBadxIxfhDve6xLeklS9vNZ5SVDdb+p0WbYnit+QrR 5dFy35eIIfctHOSMpu8cC1WgVaLKuAbXMYyonh6YPWQ+Nx+8ajSUkN5RtPSw4kK842+b mgBrU/RzWC5dJQeWmgQbuNHg+6T2cR3JujJev/i9ljgUPbzVysOG9g0qve2rfSknzaRE jGvg== X-Gm-Message-State: AO0yUKX6GEXO1h9jwUtNpqeVCPKA/V5fs2aOlnhbtojlVa+V2E8uEszD z1FHC2yudOYw2TDo7CkcsR4zdZuY0ETzikl/SnIEVm0M X-Google-Smtp-Source: AK7set9FKa/snp+qAbz7nxaeASjpkh6gBnp8Qfuu1nCOZru+QF8EnrB47+mIY/7af8J/4Ykiu0grKrO+0u3+oJYCpCk= X-Received: by 2002:a05:6808:2098:b0:383:f981:b1e5 with SMTP id s24-20020a056808209800b00383f981b1e5mr6778304oiw.5.1678110779236; Mon, 06 Mar 2023 05:52:59 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::22e; envelope-from=joaotavora@gmail.com; helo=mail-oi1-x22e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304047 Archived-At: On Mon, Mar 6, 2023 at 1:46=E2=80=AFPM Dmitry Gutov wrot= e: > > On 06/03/2023 15:38, Jo=C3=A3o T=C3=A1vora wrote: > > I think that is doable, yes. The question is whether to use the LSP > > names for them or our "own" names. I think I prefer the former, to > > avoid concept creep. So M-x xref-find-extra would offer > > "textDocument/findImplementation", "textDocument/findDeclaration", > > etc when backend reports these operation names (which in turn it does > > if the server has the associated LSP capability). > > I think we'll need readable names -- e.g. "implementations", > "declarations", "type definitions" (with a space or dash, maybe), > without the confusing "text document" stuff. We don't _need_ them, but it's generally nice to have readable names. > I think the idea is to report the names of "things" that can be found. > > > The consistency would be in the single xref-find-extra binding. > > The LSP names are clear enough and we can even decamelify them > > automatically to be nicer to the camelically disinclined like > > myself. > > And remove the "textDocument/find" prefix. Right. That's a LSP thing, and Eglot knows LSP, so perfectly doable. Jo=C3=A3o