From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#59138: Eglot support for java-language-server Date: Wed, 9 Nov 2022 16:58:08 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000005c70a305ed0c909a" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14458"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59138@debbugs.gnu.org, Stefan Kangas To: Robert Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 09 17:59:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osoQ5-0003UD-Au for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Nov 2022 17:59:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osoPs-0002Tj-5c; Wed, 09 Nov 2022 11:59:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osoPn-0002Qi-IB for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2022 11:59:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1osoPm-0000jC-2u for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2022 11:59:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1osoPl-0002NA-UJ for bug-gnu-emacs@gnu.org; Wed, 09 Nov 2022 11:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Nov 2022 16:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59138 X-GNU-PR-Package: emacs Original-Received: via spool by 59138-submit@debbugs.gnu.org id=B59138.16680131089080 (code B ref 59138); Wed, 09 Nov 2022 16:59:01 +0000 Original-Received: (at 59138) by debbugs.gnu.org; 9 Nov 2022 16:58:28 +0000 Original-Received: from localhost ([127.0.0.1]:40729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osoPE-0002MO-51 for submit@debbugs.gnu.org; Wed, 09 Nov 2022 11:58:28 -0500 Original-Received: from mail-ot1-f51.google.com ([209.85.210.51]:39469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osoPC-0002MA-NR for 59138@debbugs.gnu.org; Wed, 09 Nov 2022 11:58:27 -0500 Original-Received: by mail-ot1-f51.google.com with SMTP id br15-20020a056830390f00b0061c9d73b8bdso10445079otb.6 for <59138@debbugs.gnu.org>; Wed, 09 Nov 2022 08:58:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OmMx/W70ME1AEbjuA+455R1ubR6PWJtlTXvmNRV/2gQ=; b=X60NyUi7oB7v+yB/XVBze760TWikXGLsQ9URGPgzCBC++rYet5Qfo55sDfQsIeY3GU Jok4TUbHa/UAG2hYueOP0Vbfz7bl2ngGM22ryGXzEQNs84YK6BQgLAN3kl1AIGnWZibC yxW2jD1UrfoE9ZXO3h1RtfQkoTxTMeTi/F0xGVmBGtrPGC7qS3L0LurBJWNR1Qwj9B48 OUz+SqPj1STC6mz/A9Wb15vpGB4FuT8y7wjDq5vKRdFsCgE646AwPSZg+FAO6BQ9G3Ft h/XgrreeGcxjbWuzSVUnO+x45TF1eDg0tI5UWVw20zRL78AOvIGC1rMqaQfJKJlqHqgk lEXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OmMx/W70ME1AEbjuA+455R1ubR6PWJtlTXvmNRV/2gQ=; b=orpPFVXDuqBAOSJZmLf3AuFcQ6p7KYmFcrJMNZXsxp3NIbBH+WcLAEidTh8ya9QymQ jCTPxFR6RRp8rZk19AgT4lULOKbTS9MLXyEm727j+STk88DlwwwNNADxIzhiNxKjaKvB j7NKZyyxWrUaiP6QIApzuTk6WLUL4tUFksaiVOuK+1GN0jBDeVHt9xiwH5kNeP/QyDFU PcJEhfNA5cxMehY7Vfj8nNCf8Pt6l7Ig3mtU7q1kaOJDESICYEYJPlOGgYMICn7qqV6b /2zEO5WZIvjid0NMhN/VPD2J+PItdwHL0gtNEKAY+oOASFtFvcHFgpZgOE3uNBdYSq0M JUpw== X-Gm-Message-State: ANoB5plbqsifFg3+T1m4nAht5P1GZE3U+N7rymHrKSd1IhndEWb+5lYz 84gV4buHnRcTZUXro7nqTCdaFC0Rb4vCn3C2QKY= X-Google-Smtp-Source: AA0mqf5mP6P3bQDbqYeLd3o+3X5g7dXpEP88oT2n1VNYxUT5vrJy3mRWmQNOC9ISb7lrKCfTam9vGd57d3K/UqCLxsw= X-Received: by 2002:a05:6830:d15:b0:66d:2e31:735e with SMTP id bu21-20020a0568300d1500b0066d2e31735emr3538882otb.93.1668013100919; Wed, 09 Nov 2022 08:58:20 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247444 Archived-At: --0000000000005c70a305ed0c909a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I can search for that address later in the copyright file. Your very simple patch can go in regardless, marked as "Copyright-paperwork-exempt: Yes". Jo=C3=A3o On Wed, Nov 9, 2022, 16:25 Robert Brown wrote: > Not sure if I have signed a copyright assignment. Would have been a long > time ago. My email address would have been @bibliotech.com. > > > On Wed, Nov 9, 2022, 11:07 AM Stefan Kangas > wrote: > >> [Please use "Reply to all" so that the discussion is recorded in the bug >> tracker.] >> >> Robert Brown writes: >> >> > I don't know what the relative popularity is. I found j-l-s to be >> > easier to compile and configure for environments that are not Maven or >> > Gradle. I think jdtls may have more features. >> >> Thanks, that's good enough for me. >> >> Have you signed the copyright assignment? I see one previous change >> from you, so I'm not sure if this latest patch would take us over the >> limit for what we could accept without one. Eli, any comments? >> >> commit 96db005527ef9d9c45c5ec8e91b01e91ee37a7fd >> Author: Robert Brown (tiny change) >> Date: Thu Jun 19 10:03:45 2014 -0400 >> >> * etc/NEWS: New Tramp method "nc". >> >> * lisp/emacs-lisp/lisp-mode.el (lisp-string-after-doc-keyword-p): Ne= w >> fun. >> (lisp-string-in-doc-position-p): New function, extracted from >> lisp-font-lock-syntactic-face-function. >> (lisp-font-lock-syntactic-face-function): Use them. >> >> Fixes: debbugs:9130 >> >> etc/NEWS | 3 +++ >> lisp/ChangeLog | 7 +++++++ >> lisp/emacs-lisp/lisp-mode.el | 64 >> ++++++++++++++++++++++++++++++++++++++-------------------------- >> 3 files changed, 48 insertions(+), 26 deletions(-) >> > --0000000000005c70a305ed0c909a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I can search for that address later in the copyright file= . Your very simple patch can go in regardless, marked as "Copyright-pa= perwork-exempt: Yes".

Jo= =C3=A3o

On Wed, Nov 9, 2022, 16:25 Robert Brown <robert.brown@gmail.com> wrote:
Not sure if I have signed a co= pyright assignment.=C2=A0 Would have been a long time ago.=C2=A0 My email a= ddress would have been @bibliotech.com.

On Wed, = Nov 9, 2022, 11:07 AM Stefan Kangas <stefankangas@gmail.com> = wrote:
[Please use "Reply to a= ll" so that the discussion is recorded in the bug
tracker.]

Robert Brown <robert.brown@gmail.com> writes:

> I don't know what the relative popularity is.=C2=A0 I found j-l-s = to be
> easier to compile and configure for environments that are not Maven or=
> Gradle.=C2=A0 I think jdtls may have more features.

Thanks, that's good enough for me.

Have you signed the copyright assignment?=C2=A0 I see one previous change from you, so I'm not sure if this latest patch would take us over the limit for what we could accept without one.=C2=A0 Eli, any comments?

commit 96db005527ef9d9c45c5ec8e91b01e91ee37a7fd
Author: Robert Brown (tiny change) <robert.brown@gmail.co= m>
Date:=C2=A0 =C2=A0Thu Jun 19 10:03:45 2014 -0400

=C2=A0 =C2=A0 * etc/NEWS: New Tramp method "nc".

=C2=A0 =C2=A0 * lisp/emacs-lisp/lisp-mode.el (lisp-string-after-doc-keyword= -p): New fun.
=C2=A0 =C2=A0 (lisp-string-in-doc-position-p): New function, extracted from=
=C2=A0 =C2=A0 lisp-font-lock-syntactic-face-function.
=C2=A0 =C2=A0 (lisp-font-lock-syntactic-face-function): Use them.

=C2=A0 =C2=A0 Fixes: debbugs:9130

=C2=A0etc/NEWS=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0|=C2=A0 3 +++
=C2=A0lisp/ChangeLog=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= |=C2=A0 7 +++++++
=C2=A0lisp/emacs-lisp/lisp-mode.el | 64
++++++++++++++++++++++++++++++++++++++--------------------------
=C2=A03 files changed, 48 insertions(+), 26 deletions(-)
--0000000000005c70a305ed0c909a--