From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Date: Thu, 5 Mar 2020 08:46:37 +0000 Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000d8760405a0179360" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="87137"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 05 09:47:20 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9mA2-000MZW-S4 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Mar 2020 09:47:18 +0100 Original-Received: from localhost ([::1]:45116 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9mA1-0004PJ-Tz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Mar 2020 03:47:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51627) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9m9m-0004Dp-Sc for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 03:47:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9m9l-00066B-R6 for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 03:47:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36178) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9m9l-000660-NM for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 03:47:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j9m9l-0002Z6-LV for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 03:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 08:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs Original-Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.15833980169849 (code B ref 38992); Thu, 05 Mar 2020 08:47:01 +0000 Original-Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 08:46:56 +0000 Original-Received: from localhost ([127.0.0.1]:42151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9m9g-0002Ym-BQ for submit@debbugs.gnu.org; Thu, 05 Mar 2020 03:46:56 -0500 Original-Received: from mail-io1-f49.google.com ([209.85.166.49]:36927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9m9e-0002YY-DA for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 03:46:54 -0500 Original-Received: by mail-io1-f49.google.com with SMTP id k4so60921ior.4 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 00:46:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VOfAY1UqKKW/sryf6nvYJ1WCyKB2vsiUZCDI/HCbbbA=; b=SGTl08hIbNxkKpHuqaYOu8Tlxb5Gw94swH4A0+fTHTZxZ9iTIfRZoDW4PZ9WDACKAE atAuUkqPJyeMoNDpuFakP6tJA4ihJs6Riq9GyouHy3iVMyqdsbExYgLwomA/RWcIrjvR p1O/myNzf+oI+Qq2W+k771Og1hHnRy/QT+a4NtrNKlEh26Jitocf3ltKoC7rM2malg92 kdCxO24tHwyDljZ8yOeSU5518Dop6Aah1NQTs/hu6OpGWsoORHuw7BlpldjXbjxfQLkB mQ9vym2/ibIGzOv/M09Fhf1IuFHF0AiQ7GkWtzOU+FR/R//ZOFBLfLJjIJhgdjeGZ1ub K8oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VOfAY1UqKKW/sryf6nvYJ1WCyKB2vsiUZCDI/HCbbbA=; b=K7QrjmnIS2fwk6UXNumFStezkevcnZTq0+t8KhdBPworJpkNuOQJRNBXEcd0dmMEBP 0PhQux0D8TSiykTLIJDcwCvuqmN9xESOt5anqlshM5KISNCDRaVmbMZO0Ab9sruLfQyW N8zp6ONmRz9wLGfLWbRCxI2uGTZdhplU1ab0C5JcDG/X3V+P/DhwF670ssm0+afct248 xxjwFW6OYYjmHqsxhLhQoy2MIhn4htTlUjHOsYKMeJvg50xO1ot4JnrooNeVRwbGx7b6 wCOQC5KHGWqG/fyXNlJCDAd/ybhVt+IEBweQibPjCo5uvhgrzLgeipXx8et2xtjjREoA 8x2Q== X-Gm-Message-State: ANhLgQ2NmNtmGrgbpGZgE++8iL/lSYB4P9dd97yCUr11Najruta0qbla BuLZgGr/GLbXMjRIcXnL44/IJmegOO8qMdf9R6g= X-Google-Smtp-Source: ADFU+vsOzd+7aIKq7PHajYTkGawtp43XKcTfZ9FdKtj1mVY3RyRd1u1sZn3LNQktvyCQ5d6CAm7TCI0jrRnIxVlVbBU= X-Received: by 2002:a02:c9cf:: with SMTP id c15mr6499267jap.71.1583398008680; Thu, 05 Mar 2020 00:46:48 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176888 Archived-At: --000000000000d8760405a0179360 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 5, 2020 at 8:36 AM Dmitry Gutov wrote: > > On 05.03.2020 10:01, Jo=C3=A3o T=C3=A1vora wrote: > > > > ido-mode users, however, like to use RET for arbitrary inputs as well. > > > > Let's first _not_ change the current fido-mode UI ok? At least > > for now. Later (even before Emacs 27) could be fine. > > It only changed according to our previous discussion. E.g. RET can now > accept '*.c' as pattern to search for in 'M-x grep'. Yes, that fine. I meant, let's not change it _further_ (if that was indeed what you were proposing). Also, I think, for safety, that we still should have in the fido-mode-keymap sth bound to the "atomic" give-me-whatever-is-in-minibuffer command, maybe C-M-j or something like that. Even if it _does_ break the required-match semantics somewhere else, it just seems like a good idea. > Of course, if there were any matches in the completion table for that > input, RET would choose the first match. > > Let me know if you see a problem there. Hmmm, isn't that how ido-mode behaves already, and how fido-mode behaves, at least to a large extent? If so it seems fine. Jo=C3=A3o T=C3=A1vora --000000000000d8760405a0179360 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Mar 5, 2020 at 8:36 AM Dmitry Gutov <dgutov@yandex.ru> wrote:
>
> O= n 05.03.2020 10:01, Jo=C3=A3o T=C3=A1vora wrote:
>
> > =C2= =A0> =C2=A0ido-mode users, however, like to use RET for arbitrary inputs= as well.
> >
> > Let's first _not_ change the curren= t fido-mode UI ok? At least
> > for now.=C2=A0 Later (even before = Emacs 27) could be fine.
>
> It only changed according to our p= revious discussion. E.g. RET can now
> accept '*.c' as patter= n to search for in 'M-x grep'.

Yes, that fin= e.=C2=A0 I meant, let's not change it _further_ (if that was indeed
what you were proposing).

Also, I think, fo= r safety, that we still should have in the fido-mode-keymap
= sth bound to the "atomic" give-me-whatever-is-in-minibuffer
<= /div>
command, maybe C-M-j or something like that.=C2=A0 Even if it
_does_ break the required-match semantics somewhere else,
= it just seems like a good idea.

> Of course, if there = were any matches in the completion table for that
> input, RET woul= d choose the first match.
>
> Let me know if you see a pro= blem there.

Hmmm, isn't that how ido-mode beha= ves already, and how fido-mode
behaves, at least to a large = extent? If so it seems fine.

Jo=C3=A3o T=C3=A1vora<= /div> --000000000000d8760405a0179360--