all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Felician Nemeth <felician.nemeth@gmail.com>
Cc: 61072@debbugs.gnu.org, Wei-Ting Lin <linwaytin@gmail.com>
Subject: bug#61072: How to change the length of the separation lines in eldoc, used by eglot?
Date: Tue, 21 Feb 2023 17:19:02 +0000	[thread overview]
Message-ID: <CALDnm53PUs0kghDZ9CkA8XVi_-DtiAK+kLQ3+j-nUN3Q3PhFoA@mail.gmail.com> (raw)
In-Reply-To: <87pma3gcyw.fsf@betli.tmit.bme.hu>

On Tue, Feb 21, 2023 at 5:11 PM Felician Nemeth
<felician.nemeth@gmail.com> wrote:

> So the LSP server sends "---\n".  gfm-view-mode turns these three dashes
> into a long separation line, which is then displayed by eldoc-box.
> Neither gfm-view-mode nor eldoc-box is a part of Emacs or available from
> GNU ELPA.  I'm therefore tempted to say that debbugs is not the right
> place for this bug report.
>
> However, when Eglot calls gfm-view-mode in eglot--format-markup the
> window-width probably equals to the width of the window containing the
> user's source code and eldoc-box seems to display the documentation in a
> narrower window.  So maybe it would help if Eglot allowed the users to
> run a custom function instead of calling gfm-view-mode in
> eglot--format-markup.

Yes, I see the problem.  Thanks for describing Felicián.

But I don't think your suggestion is the correct way to tackle it.

Rather,  Eglot should add a markdown-capable element to
eldoc-display-functions and hint in the documentation item
produced by Eglot's eldoc-documentation-functions that that item
has a markdown version (it may also have a plaintext version
alongside),  taken directly from the LSP source. The new function
would then render the item appropriately.

Then users and other modes such as eldoc-box can also add things to
eldoc-display functions, read the hints (if they support them)
and do whatever they think is more suitable with the rich/poor
documentation item.

This is in principle already fully supported by the ElDoc
infrastructure, but needs someone to experiment with it (and
potentially find limitations in ElDoc, which I can help plug).

João





  reply	other threads:[~2023-02-21 17:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26  1:42 bug#61072: How to change the length of the separation lines in eldoc, used by eglot? Wei-Ting Lin
2023-01-26 11:12 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-27  1:08   ` Wei-Ting Lin
2023-02-09 17:05 ` Felician Nemeth
2023-02-18 15:08   ` Wei-Ting Lin
2023-02-21 17:11     ` Felician Nemeth
2023-02-21 17:19       ` João Távora [this message]
2023-03-15 12:07         ` Felician Nemeth
2023-03-23 21:59           ` João Távora
2023-03-28 15:16             ` Felician Nemeth
2023-03-28 22:27               ` João Távora
2023-03-29 17:48                 ` Felician Nemeth
2023-03-29 23:59                   ` Yuan Fu
2023-04-08  8:52                     ` Felician Nemeth
2023-04-08  9:10                       ` João Távora
2023-03-23 21:53 ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALDnm53PUs0kghDZ9CkA8XVi_-DtiAK+kLQ3+j-nUN3Q3PhFoA@mail.gmail.com \
    --to=joaotavora@gmail.com \
    --cc=61072@debbugs.gnu.org \
    --cc=felician.nemeth@gmail.com \
    --cc=linwaytin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.