From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Flymake, compilation-mode lighters very noisy Date: Wed, 21 Nov 2018 11:58:22 +0000 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000034eee9057b2b7802" X-Trace: blaine.gmane.org 1542802178 4725 195.159.176.226 (21 Nov 2018 12:09:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Nov 2018 12:09:38 +0000 (UTC) Cc: emacs-devel To: Yuri Khan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 21 13:09:34 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gPRK0-000166-KL for ged-emacs-devel@m.gmane.org; Wed, 21 Nov 2018 13:09:32 +0100 Original-Received: from localhost ([::1]:38705 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPRM6-00070r-Dy for ged-emacs-devel@m.gmane.org; Wed, 21 Nov 2018 07:11:42 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPRLq-0006rn-9N for emacs-devel@gnu.org; Wed, 21 Nov 2018 07:11:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPR9O-0003Ga-TZ for emacs-devel@gnu.org; Wed, 21 Nov 2018 06:58:35 -0500 Original-Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]:33852) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gPR9O-0003FI-LJ for emacs-devel@gnu.org; Wed, 21 Nov 2018 06:58:34 -0500 Original-Received: by mail-qt1-x82a.google.com with SMTP id r14so3470374qtp.1 for ; Wed, 21 Nov 2018 03:58:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wAfnDTYXcae0oj72ciWlTrUDBT31TqFbSsGgmATfmcQ=; b=AiGEbwPRSJuY8LetohldrgXHAia3uVQf2caOUj5MDXFA+hYzMsIR9zg6IpffOtMjoG kBM2DU2p15LA8+8DfVq/UNM3OkaCCqRmOOADR2HyEbsxckysPX7EWOnjtAC+q21uvSdv mbdHgTZ7nCcqFkiaA5RpcZ/1LFsVpQcbutPDUgJy4dzxFiCWwx3xQBqDY3a6El2qeL8U Rt6SCF9kDPvApAH2eYQPQ/DdTpoFDgINNoj1e4Ncjl4VE/R7vL5FN4ZlUauTUllih/CJ 31GZTzOCQGnnN+EdD4lldSLxUbZS08DSn1pLRaR94HL9FYg+uJgdLbZEoc4P1BxP4QKt LFbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wAfnDTYXcae0oj72ciWlTrUDBT31TqFbSsGgmATfmcQ=; b=oqZQGyku4yqm7NxYB06i+3ufG8jRT1upI7ZcQWdWifMFnhNuD0CkY0uQgCeMYeNdO0 3FXRmHiNyxvJWi+npOnAVZhYC7Zyuuk4FfJKAYOW2oNxdmmfJmnA43EvJjoxx77Q0JKh vKtPVR2qw735d8fGgaXPDFdFkd5V4t0V89FwRdaOaAuD95yXyqltJNnN9SPv3BbhPlSn IQF48oRPuKtycMILt3eQm7z1hGhq+jCRaFgbBvHzcnEQrlzR0ZDItHY0T1UxfV02ciQB 3Hs142f4TrdbJKpp2Tzw9nIfyYeLRUSZyKqYN4fpITAadiPQcbv/M+QHLnGZyfi9pg+S VtJg== X-Gm-Message-State: AGRZ1gIMAI1CW/unHjMU3o1lGtBpxhZFfH2MQdrZfsczozSl2N/5MWxq JqrOcx/Z6n2KajKutx8j5b5yPoox3DqaeZP9ViI= X-Google-Smtp-Source: AJdET5fRJinpCwshxPMDkjwDloB+7ccuYkhJ0c1s+RL9OaTtPBfGgpsRP8HZ2b28BZEfBOYsa4rtHU0KP4k4L3IuI08= X-Received: by 2002:ac8:3e91:: with SMTP id y17mr5702838qtf.390.1542801514096; Wed, 21 Nov 2018 03:58:34 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::82a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231278 Archived-At: --00000000000034eee9057b2b7802 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Nov 21, 2018 at 11:36 AM Yuri Khan wrote: > On Wed, Nov 21, 2018 at 5:39 PM Jo=C3=A3o T=C3=A1vora wrote: > > > > This is too long for me to read right now, sorry. > > Please take your time. No pressure. > > > The simple variable flymake-always-show-indicators-min-severity-level > would fix the problem you reported yesterday, and it would be trivial to > implement, but you seem to be suggesting much more. > > I am suggesting a massive logic:presentation split-up, so that not > only my problem would be fixed but also similar problems for different > categories of other users, We still need to clear up exactly what situations/problems we would be fixing... and because such a split-up is generally a good thing. > With emphasis on the "generally" :-). I'd rather fix concrete problems, like the one you brought me originally. I must admit I don't have much incentive in what is potentially an overdesign (for me in particular) of this bit of functionality, so you must find another "sponsor". > By the way, I only asked you to propose a break up of that function because you talked about copying it to your init and tweaking it. I assumed those tweaks would not be random... :) > > Okay, if we are talking about my tweaks only, then I would want to > have a configuration where a red or yellow anything on my mode line > means an actionable alert. That is, only display color if there is > something I *can* and *should* fix immediately. > > * First, I would suppress zero counters of all severities. This would > make it possible for me to work on projects that currently have no > errors or warnings and where the policy is to keep errors and warnings > at zero. > OK. So is a flymake-supress-zero-counters variable enough? If set to t, means to supress all zero counters. If set to :warning, the default, means to suppress zero counters of severity less than warning. Likewise if set to severity X= . If set to nil, don't supress any zero counters. > * I could get involved in a project that has warnings, and where I > cannot fix them all at the source. Then I would first attempt to see > if I can customize the checker rules to silence those categories of > errors or warnings. If that proved infeasible, then I would have to > live with a non-zero error or warning counter; in that case I would > want to tweak the indicator so that the counters were displayed in a > normal face, not in red and yellow. > > =E2=80=A6And here I looked at where it gets the faces from and saw I coul= d > just (put 'flymake-error 'mode-line-face nil). Thank you, immediate > problem solved, sorry for the panic :) > Yes, I was going to suggest that. That's the standard way to affect error types. > > Propose those changes in a patch or a scratch branch! Or, alternatively= , > propose only the new customization variable/interfaces you would like to > see added, along with docstrings, and we can deal with the implementation > later after we settle on the user interface. > > As someone who has not assigned copyright to FSF, I think I can > currently only propose ideas, and modest amounts of code. > Then start working on that assignment! Jo=C3=A3o T=C3=A1vora --00000000000034eee9057b2b7802 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Nov 21, 2018 at 11:36 AM Yuri Khan <yurivkhan@gmail.com> wrote:
On Wed, Nov 21, 2018 at 5:= 39 PM Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> wrote:
>
> This is too long for me to read right now, sorry.

Please take your time. No pressure.

> The simple variable flymake-always-show-indicators-min-severity-level = would fix the problem you reported yesterday, and it would be trivial to im= plement, but you seem to be suggesting much more.

I am suggesting a massive logic:presentation split-up, so that not
only my problem would be fixed but also similar problems for different
categories of other users,

We still need t= o clear up exactly what situations/problems we would be
fixi= ng...

and because such a= split-up is generally a good thing.

Wi= th emphasis on the "generally" :-).=C2=A0 I'd rather fix conc= rete problems, like
the one you brought me originally.=C2=A0= I must admit I don't have much incentive
in what is pot= entially an overdesign (for me in particular) of this bit of
functionality, so you must find another "sponsor".

=C2=A0> By the way, I only asked you to propose a break = up of that function because you talked about copying it to your init and tw= eaking it. I assumed those tweaks would not be random... :)

Okay, if we are talking about my tweaks only, then I would want to
have a configuration where a red or yellow anything on my mode line
means an actionable alert. That is, only display color if there is
something I *can* and *should* fix immediately.

* First, I would suppress zero counters of all severities. This would
make it possible for me to work on projects that currently have no
errors or warnings and where the policy is to keep errors and warnings
at zero.

OK. So is a flymake-supress-ze= ro-counters variable enough? If set to t, means
to supress all ze= ro counters. If set to :warning, the default, means to suppress
z= ero counters of severity less than warning.=C2=A0 Likewise if set to severi= ty X.
If set to nil, don't supress any zero counters.
=C2=A0
* I could get involved in a project that has warnings, and where I
cannot fix them all at the source. Then I would first attempt to see
if I can customize the checker rules to silence those categories of
errors or warnings. If that proved infeasible, then I would have to
live with a non-zero error or warning counter; in that case I would
want to tweak the indicator so that the counters were displayed in a
normal face, not in red and yellow.

=E2=80=A6And here I looked at where it gets the faces from and saw I could<= br> just (put 'flymake-error 'mode-line-face nil). Thank you, immediate=
problem solved, sorry for the panic :)

= Yes, I was going to suggest that. That's the standard way to affect
error types.
=C2=A0
> Propose those changes in a patch or a scratch branch! Or, alternativel= y, propose only the new customization variable/interfaces you would like to= see added, along with docstrings, and we can deal with the implementation = later after we settle on the user interface.

As someone who has not assigned copyright to FSF, I think I can
currently only propose ideas, and modest amounts of code.
<= div>
Then start working on that assignment!
=C2= =A0
Jo=C3=A3o T=C3=A1vora
--00000000000034eee9057b2b7802--