From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62694: 30.0.50; eglot-tests fails with recent pylsp Date: Thu, 6 Apr 2023 20:50:56 +0100 Message-ID: References: <87sfddibcn.fsf@gmx.de> <87o7o1tfvc.fsf@gmx.de> <87ile9t5uj.fsf@gmx.de> <87ttxssyef.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1720"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62694@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 06 21:52:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkVee-0000MD-KS for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Apr 2023 21:52:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pkVeO-0000qv-Jv; Thu, 06 Apr 2023 15:52:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkVeN-0000qk-1M for bug-gnu-emacs@gnu.org; Thu, 06 Apr 2023 15:52:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pkVeM-0001Q4-PD for bug-gnu-emacs@gnu.org; Thu, 06 Apr 2023 15:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pkVeM-0002SP-5a for bug-gnu-emacs@gnu.org; Thu, 06 Apr 2023 15:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Apr 2023 19:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62694 X-GNU-PR-Package: emacs Original-Received: via spool by 62694-submit@debbugs.gnu.org id=B62694.16808106789326 (code B ref 62694); Thu, 06 Apr 2023 19:52:02 +0000 Original-Received: (at 62694) by debbugs.gnu.org; 6 Apr 2023 19:51:18 +0000 Original-Received: from localhost ([127.0.0.1]:55238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkVdd-0002QJ-J3 for submit@debbugs.gnu.org; Thu, 06 Apr 2023 15:51:18 -0400 Original-Received: from mail-oo1-f45.google.com ([209.85.161.45]:33433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkVdZ-0002PA-4t for 62694@debbugs.gnu.org; Thu, 06 Apr 2023 15:51:16 -0400 Original-Received: by mail-oo1-f45.google.com with SMTP id n6-20020a4abd06000000b0053b59893660so6342578oop.0 for <62694@debbugs.gnu.org>; Thu, 06 Apr 2023 12:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680810667; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Id4Syp/xtNpsMF6JOA4FN9keQlrCHUAW5kTwRM8Goj0=; b=jOORuuHHe3aOzWRYIbxRFPaarmH7Ygk64vruJy3OPNBvopLE6r0qh0ZluRcDrePyop /cWwJM5owqWEj23m+GqZiQEjbHR1siPgif6+DlHEyGiuOWPzzCNlSnEsuWDiQig6zLgv rtOfc9LC5v9qx+VlsQpyhHR5HvqipYlJqWHm3dP/1sDIE3ur+xZgzQ4gK+q/arfdYVqz kbTJcsZ5K1QxBsQbjognLmJLUcM0HIIN8rrD/Y8cfo9sY3p9bXd96XEmVsbfYF4PFlcB dkxO2nnJpAjnHvkK4P+PipdvltpU512D1WuMDLFGuV940eZqtsuo4GHauno6ObRRba/g ZB6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680810667; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Id4Syp/xtNpsMF6JOA4FN9keQlrCHUAW5kTwRM8Goj0=; b=fTkdOt16akG7eW2tL/gZtBgx1cvLXpRv1rIWNMRormtl5e1Nl9Gjk3rfW0v2atyALI gaOAYCETAlXxucCtAXVjUwnrRyrUmmC8WN0qcSc9kH0Qg00zLU/Q2qEAaL4RzhJ9gu/6 22NaueLhFIJnzLuqO49hFydmdlvQzchKFGWHv8K3LrSclyHU3cZcvM3puy0ymZt81+ln 0LDtTCYXswS0Affh9jizB5uS/Nsvn70+S8p4lnS9Jlf1gEZR4D4A0syhoCrYVzpyySZP Vh9w5VPkA2Ef9yUfQ8u05ru1u2NPoo9JFVtoc4LlEz2ge0+m516ELnd7LilLdDpIa17T QTCw== X-Gm-Message-State: AAQBX9e8Mn44QsyNtaRDv7ULSNiZ5Vq5FMm6kcukZHldSISvGkWXOzmA K4+vp//JAxFEpVk1MN/Qe4GsQZmly3NgiYOO7Q4= X-Google-Smtp-Source: AKy350bv+0XJAiAtrkkeokxskjMzDWKqE0Zm5MKCl9J5UdlAKUNDocEvk2ZXuqK9pJu/7mAeeHUIFNzOyprsQ+vS4y0= X-Received: by 2002:a4a:e9b0:0:b0:541:453f:99e6 with SMTP id t16-20020a4ae9b0000000b00541453f99e6mr248182ood.1.1680810667176; Thu, 06 Apr 2023 12:51:07 -0700 (PDT) In-Reply-To: <87ttxssyef.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259354 Archived-At: On Thu, Apr 6, 2023 at 6:39=E2=80=AFPM Michael Albinus wrote: > > Jo=C3=A3o T=C3=A1vora writes: > > Hi Jo=C3=A3o, > > >> I don't doubt. But you cannot expect that everybody uses "the number o= ne > >> recommended pylsp installation method". > > > > I expect that. The same way I expect people to install Eglot from ELPA,= and > > use a normal installation of Emacs, not some "Doom" or "Spacemacs". Or = the > > same way I expect people not to have advice in their configurations. > > Many times my expectation fails, and yet I expect these things, because > > that's what I programmed against. > > > > So if they don't use that method, then maybe they should. More > > importantly, here we're talking about the much smaller universe of Ema= cs > > developers, not regular users. > > I don't speak about eglot (pylsp) users. They will know what to do. > > I speak about ordinary Emacs users, not interested in eglot, who could > see Emacs errors when they run "make check". But these Emacs users are _also_ pylsp users, who have the Debian pylsp package installed. So you _are_ speaking about pylsp users. > >> Again, I'm not speaking about eglot users. They shall know what to > >> do. But eglot-tests could fail for everybody who has installed a pylsp > >> package, for example from Debian, w/o even being interested in eglot. > > > > That package is faulty to some degree in that it does not work exactly > > like the recommended installation of pylsp. > > Likely yes. But people might have it installed, because they use > Debian. Why don't you check this wrong installation of pylsp in your > skip checks? This would solve it sufficiently, I believe. How do I do that? How do I do that portably? > > Even if that's a problem for some hypothetical hardcore Debian > > user who happens to also be an Emacs developer and who uses pylsp > > but not in Eglot, and for some reason won't install anything from anywh= ere > > else in his development machine, we have yet to hear from the hordes of > > users at the intersection of all those conditions. > > The don't need to be pylsp users. A package could be installed for > several reasons. That could happen, but I doubt that pylsp is installed for any other reason than to be used. To intersect the set of people who have installed it "accidentally" and additionally happen to be "make check"-running Emacs devs who are completely baffled when they see the failure. Until I'm shown otherwise, I really think you're the only person in that set in the world, and you're not baffled: you know exactly what's going on. > And we haven't heart from them, because there doesn't exist an Emacs > release with built-in eglot and eglot-tests yet. But Eglot with these tests has been in master for a very long time, where Emacs dev happens. And that's where people normally run make check, not in a release they download. In fact there were many more serious errors there for a long time that didn't appear before you installed clangd on EMBA. And clangd is orders of magnitude more popular than pylsp. By the way, remember when your clangd installed via Debian's snap or something was a senseless do-nothing script? Should I also ironclad eglot-tests.el against that? > eglot from ELPA I don't care about, they know what they do. > > > In your case in particular, I'd say you have control over what you > > install in your machine and what you install in EMBA. And I've > > given you the recommended way to fix this, if you really must have > > pylsp there. Again, can you answer what is preventing you from using > > `pip install` in your machine or in EMBA scripts? > > The point is not Emba. It is just a mean to demonstrate what could > happen. You've demonstrated an academic possibility. A lot of things in this world may conceivably happen but are extremely rare or have never happened. > And yes, I try to make the environment according to what people > use in general. And not to install special 3PP, not included in Debian, > just to "let the tests succeed". That's not the idea of regression tests. Here the 3rd party _is_ Debian's packaging! Just use pip: Pip is a package-management system written in Python and is used to install and manage software packages. The Python Software Foundation recommends using pip for installing Python applications and its dependencies during deployment. It's as kosher as it gets! I don't recommend Debian packages for installing Emacs packages, I recommend package.el, which is under our control. Have you at least tried pip there? Can you at least relay back if it works? > No, I'm neither interested in python nor in eglot myself. I'm interested > in a stable Emacs. And I know, that people providing tests should ensure > that their tests do not harm. Yes, any failed test in the wild is a harm. Put on your boots and your hat, go into the wilderness and bring me some of these wild creatures. Frankly, this obstinate stance about Debian's package manager, just makes people want to _not_ contribute tests. > > Are you just trying to get the best possible coverage from eglot-tests.= el? > > Thanks, but then I'd focus on rust-analyzer first, or the Java jdtls se= rver. > > The latter would be really useful as the GitHub CI isn't currently > > installing it and the test is being skipped there. > > If you could show me the Debian way to install rust-analyzer or jdtls in > Debian, I'm your man. I didn't find a corresponding package (but > honestly, I haven't tried for days). In case such packages don't exist > yet for Debian, I would be willing to install them differently, for a whi= le. What is with this blind devotion to Debian? It's a nice distro, but surely it can handle installation of software in different ways. Jo=C3=A3o