From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Slow completion-at-point Date: Thu, 9 Nov 2023 18:32:21 +0000 Message-ID: References: <25929.50004.710119.599023@google.com> <868r7af3v6.fsf@mail.linkov.net> <25930.31126.454503.607723@google.com> <868r78bsnx.fsf@mail.linkov.net> <25931.49899.219679.933329@google.com> <25932.1952.158726.658192@google.com> <86a5rne6x9.fsf_-_@mail.linkov.net> <86leb6aoex.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000055d8b30609bc6db1" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38816"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , emacs-devel To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 09 19:33:37 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r19qS-0009oF-07 for ged-emacs-devel@m.gmane-mx.org; Thu, 09 Nov 2023 19:33:36 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r19pW-0004sP-Op; Thu, 09 Nov 2023 13:32:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r19pV-0004rv-6l for emacs-devel@gnu.org; Thu, 09 Nov 2023 13:32:37 -0500 Original-Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r19pT-00006y-J6 for emacs-devel@gnu.org; Thu, 09 Nov 2023 13:32:36 -0500 Original-Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-507f1c29f25so1534865e87.1 for ; Thu, 09 Nov 2023 10:32:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699554753; x=1700159553; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BvRTnwGY3UJGaEqZsRPe7ihlZ0Y+Mf35Fj9Geq5jt3E=; b=ZLovTJpzRZhPJz1AzrO3PdJhO4ciecnRiZIbv4zKAGviLHQo3urGrkZdmuV7U0ulDv ZRUAr1O8aYkZ8MoGtukHka4b/q6M42ywGkdF3DWcg90bbqIIbKR22eqbfATqxlogEKaz 9VPfmmGa8dl/tjOsm5VSu98LIiTdXhsK2RLriPTZ5i3d3GzKut6Ujg4ZwtACls9JXdWa on1YgFkdNo1mxUJXWzD/jB+O1LfAp4PxWHbzQcVLscCRoBPu6TdCOcijTJGRLB2HaatK aYGTKRa/F9w2ZtrLoGP01LNgOl9XWR8xxZdc+RSnR2ahnsbdp3Pm14GffOjXDoSc6QsM OvHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699554753; x=1700159553; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BvRTnwGY3UJGaEqZsRPe7ihlZ0Y+Mf35Fj9Geq5jt3E=; b=r75qO4fQunq6tiW/Gsm+O+/1dmiRTiNUKTfRO9LHuUseUkMvM1hOEBFXGnRKvfHHJL 4lMqZ05xM0Olryd2X1SVCq1Kj3jvnbiSrPC5CCWtUeU9V6B+k+VvdKOMdNK3EA2c5YZ6 BiwBnnmvQfrsbpZpY1jSyrWEiGgOww2+qCwxhbkzI5cPL9/Gb8CMjxBJBUNedJZmAc3v jFStvDNdC/+EHEc8LRVroBKdI8de2zmz3jtGJ6yh3mufTch0UYpSvVvnwmoo4iH40WK5 nmioOrZiXH78hu1MZoqI2vEgMN4HFMFdDVJ6tWdA5GBuK352hxkzoFR4sZJ83rZEcLZt hYHA== X-Gm-Message-State: AOJu0Yyz0HfdNPqpq78+btOKtDNigSYs7fHLQgp7mq+sCyoFVeXuIRf1 GsSj7EtuXxnchx+wXsJ+7L1Xg2FNpfXREvoP0wI= X-Google-Smtp-Source: AGHT+IFdiH0EORAq72s1yF1nIWrzpGgfO2aCGMP0bbx7N1W0YgvAZZVaweFM2dTHHblatEES1oHAQ9Srarn+3pMYsbY= X-Received: by 2002:ac2:419a:0:b0:507:9aec:3014 with SMTP id z26-20020ac2419a000000b005079aec3014mr1741699lfh.26.1699554753106; Thu, 09 Nov 2023 10:32:33 -0800 (PST) In-Reply-To: <86leb6aoex.fsf@mail.linkov.net> Received-SPF: pass client-ip=2a00:1450:4864:20::12d; envelope-from=joaotavora@gmail.com; helo=mail-lf1-x12d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:312434 Archived-At: --00000000000055d8b30609bc6db1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Nov 9, 2023, 16:22 Juri Linkov wrote: > > IOW, whenever each completion UI is updated (that uses completion style= s > -- > > that is, calls completion-all-completions), all its users will see the > > benefits. > > BTW, after the recent change many tests are broken at the first part > of test/lisp/minibuffer-tests.el since there is no text property > 'completion-score' anymore. I noticed this when adding more tests > at the second part of the same file that is unrelated to this change. Thanks for noticing and sorry for the breakage. I think the tests need to be updated to reflect what exactly the public expectations are regarding these properties. I'll look into this ASAP. Jo=C3=A3o > > --00000000000055d8b30609bc6db1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Nov 9, 2023, 16:22 Juri Linkov <juri@linkov.net> wrote:
> IOW, whenever each completion UI is updated (that uses c= ompletion styles --
> that is, calls completion-all-completions), all its users will see the=
> benefits.

BTW, after the recent change many tests are broken at the first part
of test/lisp/minibuffer-tests.el since there is no text property
'completion-score' anymore.=C2=A0 I noticed this when adding more t= ests
at the second part of the same file that is unrelated to this change.

Thanks for= noticing and sorry for the breakage. I think the tests need to be updated = to reflect what exactly the public expectations are regarding these propert= ies. I'll look into this ASAP.

Jo=C3=A3o

--00000000000055d8b30609bc6db1--