From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62194: 30.0.50; Two Eglot-over-Tramp tests are failing on master, passing on emacs-29 Date: Sat, 18 Mar 2023 11:29:21 +0000 Message-ID: References: <87wn3jue1q.fsf@gmail.com> <87edpqjqsv.fsf@gmx.de> <874jqmjl0s.fsf@gmx.de> <875yb1pxai.fsf@miha-pc> <87ttykj45i.fsf@gmx.de> <878rfw51mh.fsf@gmail.com> <87pm98iw1e.fsf@gmx.de> <87fsa43f36.fsf@gmail.com> <87sfe4eh09.fsf@gmx.de> <87wn3g1ssd.fsf@gmail.com> <87fsa3ejxq.fsf@gmx.de> <87pm97eibv.fsf@gmail.com> <87mt4az9eo.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15569"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62194@debbugs.gnu.org, miha@kamnitnik.top To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 18 12:28:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdUjY-0003vt-4r for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Mar 2023 12:28:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdUjH-0008WF-H5; Sat, 18 Mar 2023 07:28:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdUjC-0008Vp-PA for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 07:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdUjB-0002rW-Vk for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 07:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pdUjB-0003qc-Q0 for bug-gnu-emacs@gnu.org; Sat, 18 Mar 2023 07:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Mar 2023 11:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62194 X-GNU-PR-Package: emacs Original-Received: via spool by 62194-submit@debbugs.gnu.org id=B62194.167913885814761 (code B ref 62194); Sat, 18 Mar 2023 11:28:01 +0000 Original-Received: (at 62194) by debbugs.gnu.org; 18 Mar 2023 11:27:38 +0000 Original-Received: from localhost ([127.0.0.1]:46415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdUio-0003q0-7t for submit@debbugs.gnu.org; Sat, 18 Mar 2023 07:27:38 -0400 Original-Received: from mail-oa1-f44.google.com ([209.85.160.44]:44843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pdUim-0003po-2u for 62194@debbugs.gnu.org; Sat, 18 Mar 2023 07:27:36 -0400 Original-Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-176261d7f45so8336426fac.11 for <62194@debbugs.gnu.org>; Sat, 18 Mar 2023 04:27:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679138850; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kVgAQAtxG994aS6yIQiXGKn1Iu994P2Cv2fsf8fMChI=; b=dD6nO8Mw4vlzaXPxHX+WZiKcIZdJrkMxAxmtaHKTbluLy43kSBJteo5JDX3krGS/oP LKa1ZX4KLBqOZBpDBPId1HNTUAWsSNvkQZlVGX87W7GdzqJGfxzDWnOjZuzCQm1FcYjV 8gqeQdXapEksI1SaC2TksDRkXWFT/tRH8EoavXqpHFqwhaLfwxnKPyy+muS7IFWvpin6 gwTRTna56mvt5GihKw7MZxIOZWew1c003o9cFyHbbOb3B9D1tmpF58NNktYW0oUlhwJT cfaEsTYThHve5QV4HxpQ/YNEkrmuNkjQz8hkGVCXT15TwPwVeKzS4wBP3/+xzvMwSh6o wvhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679138850; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kVgAQAtxG994aS6yIQiXGKn1Iu994P2Cv2fsf8fMChI=; b=xBu4+CxIFarHvsUHyeHdVzEFr6uQSxETo+hFlObI1oVWCVqTbsbGsjX1vlGPCWFPnV sOGUXOPcuz18W2rpf7gY6Ove6nHf20JA/FYuu+TUPACqqoBbFRmHdVEGnrcqES+HpqrD J5MvQBuSN4/Ne9Ig5scCIBFK+fHB1U1EtudGdWr3Hdj2gUTvqTL3VjibNZjip4BH74A9 sF+WmG0E8Ebsqlwj1wcqpu1CJYGgmZhOPX+xPL/m5w0EJzF4OO1BS80witU/Z2kJoj+v lE/xmOUKRN5y2TlPfqYqq7wW9DMcf4T60LTZzl2URkWVGCMpwuB0RSk9xCpRHho4I6Ey +b8g== X-Gm-Message-State: AO0yUKW2xlqiULgUSZHNGZt6RREn3v4kG9+ilEyj9bosEyCeDbMOycuA diRD/GAcmaZE42pV3Po0kr2Orb/uZ5EEFewarsI= X-Google-Smtp-Source: AK7set8XnlPoGukyDGenEoQpnZ5j8Y91vjAcYa+fIAvy5yzCwY5Ss1g5B8lxhbG16tpLwtld/EsoSrlGma6iCmop50o= X-Received: by 2002:a05:6871:8a85:b0:17a:df9b:6b1b with SMTP id tm5-20020a0568718a8500b0017adf9b6b1bmr511120oab.5.1679138850435; Sat, 18 Mar 2023 04:27:30 -0700 (PDT) In-Reply-To: <87mt4az9eo.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258163 Archived-At: On Sat, Mar 18, 2023 at 9:38=E2=80=AFAM Michael Albinus wrote: > > Jo=C3=A3o T=C3=A1vora writes: > > Hi Jo=C3=A3o, > > >> I've applied the patch, but Thomas' recipe still blocks for me. Sorry = to > >> tell you. > > > > Drats. Reproduced. > > > > I honestly don't know what's going on. Yesterday I got 0% failures, > > today I get 100% failures with the very same code. Maybe there is some > > SSH/ControlMaster thing at the OS level that's tainting the experiment. > > So I propose we let the state as-it-is in master. The relevant tests > pass successfully, and we have your workaround in eglot.el, which makes > the situation a little bit better. I propose we still revert the two of your latest patches. The situation stays exactly the same in practice for now (bug#31350 broken, this bug fixed, workaround in place, no-one knows what is really happening), but with the added advantage that the code is still the same as in emacs-29. > Just one remark: perhaps you could > change this to > > --8<---------------cut here---------------start------------->8--- > (let ((default-directory default-directory) > ;; bug#61350: Tramp turns on a feature > ;; by default that can't (yet) handle > ;; very much data so we turn it off > ;; unconditionally -- just for our > ;; process. > (tramp-use-ssh-controlmaster-options 'suppr= ess) > (tramp-ssh-controlmaster-options > "-o ControlMaster=3Dno -o ControlPath=3Dno= ne")) > --8<---------------cut here---------------end--------------->8--- > For the Tramp < 2.6.0.3 it still works, because > tramp-use-ssh-controlmaster-options is non-nil, and > tramp-ssh-controlmaster-options is used. Starting with Tramp 2.6.0.3, > the value `suppress' forces Tramp to compute its own > tramp-ssh-controlmaster-options, which might be the same, or not. But it > is Tramp's responsibility to DTRT. Makes sense. If it's just this change, you can push this yourself. Thanks in advance. > Note that I have plans to enable shared connections also for PuTTY, by a > similar option tramp-use-shared-connection (or similar, not decided > yet). But this will be relevant for MS Windows users only; I don't know > how many of them use eglot. And it will definitively be in Tramp 2.7 > only. > > As proposed. we shall close *this* bug. The reported problem is fixed, > and for everything else we have bug#61350. OK. Just a heads up, I asked for bug#61350 and this one to be "merged" earlier. Don't know what debbugs did about that, but didn't see any practical effect > > FWIW, removing the JUST-THIS-ONE make Thomas' example always pass, but > > it has other implications like the re-entrancy thing, which I don't > > understand. > > > > I don't have any better ideas at the moment, other than just biting the > > bullet and reading Tramp's code very closely. I'll try my hand at > > adapting a process-filter into it as I described in bug#61350, but I > > don't know if I'll manage of course, since I'm not closely acquainted > > with the API. > > I will continue to bring threads into play with Tramp, again. Slow > progress only. But perhaps, it helps to improve the situation. I think you should consider bring stuff _out_ of Tramp instead of _in_. Consider removing tramp-a-o-p entirely, and segregating/segmenting messages in a process filter. This segregation is entirely textual (no fs primitives) and does run the risk of reentrancy. Then -- for sync APIs -- 'throw' the complete message into whoever is blockingly waiting for the answer with (catch ... (while (accept-process-output p))). I've given a working example in bug#61350. If you need timeouts I can show you how to add them. Jo=C3=A3o