bug#34294: 27.0.50; flymake-start-on-save-buffer has no effect

["João Távora" <joaotavora@gmail.com>]

On Mon, Mar 18, 2019 at 9:23 PM Juri Linkov <juri@linkov.net> wrote:
> João, if you are not very busy atm, could you please look at this patch.

It looks good to me.  I just have a suggestion and would like
to see the commit msg, too.

> > -(defcustom flymake-start-syntax-check-on-newline t
> > +(define-obsolete-variable-alias 'flymake-start-syntax-check-on-newline
> > +  'flymake-start-on-newline "27.1")
> > +
> > +(defcustom flymake-start-on-newline t
> >    "Start syntax check if newline char was added/removed from the buffer."
> >    :type 'boolean)

I think we should change this to default to nil.

I would even go as far as obsoleting the variable entirely, and
use make-obsolete-variable instead: there's no real reason
why newline should be given special treatment.  And users
that need this for some obscure reason can probably plug it
in post-self-insert-hook.

If you obsolete the variable, you can remove it from the
manual, too.


-- 
João Távora