From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#70958: 30.0.50; eglot-managed-mode hooks not called on shutdown Date: Mon, 27 May 2024 18:22:14 +0100 Message-ID: References: <86y17yz5sr.fsf@gnu.org> <87ed9np6n8.fsf@betli.tmit.bme.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14778"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70958@debbugs.gnu.org, Eli Zaretskii , Troy Brown , Stefan Monnier To: Felician Nemeth Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 27 19:24:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sBe59-0003ih-Qt for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 May 2024 19:24:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBe4h-000110-KV; Mon, 27 May 2024 13:23:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBe4f-000104-Og for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 13:23:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sBe4f-0005iA-DT for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 13:23:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sBe4o-0007eS-1v for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 13:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 May 2024 17:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70958 X-GNU-PR-Package: emacs Original-Received: via spool by 70958-submit@debbugs.gnu.org id=B70958.171683062329383 (code B ref 70958); Mon, 27 May 2024 17:24:02 +0000 Original-Received: (at 70958) by debbugs.gnu.org; 27 May 2024 17:23:43 +0000 Original-Received: from localhost ([127.0.0.1]:45148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBe4V-0007dq-Fu for submit@debbugs.gnu.org; Mon, 27 May 2024 13:23:43 -0400 Original-Received: from mail-lf1-f48.google.com ([209.85.167.48]:47503) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBe4T-0007dc-Hz for 70958@debbugs.gnu.org; Mon, 27 May 2024 13:23:42 -0400 Original-Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-52389c1308dso11605417e87.3 for <70958@debbugs.gnu.org>; Mon, 27 May 2024 10:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716830546; x=1717435346; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PnvVRBfAg4fgwYOlnsiNChCwPimaszaBxRkTDa8PSks=; b=dXtZvFDhZKkzSRXYqoCFsN/SuYuVxjDQEA5zoWhNalGlwjpnczrSBIaAipBe5ZtUzE CkbZujhxkX4+obQS6dH4OOQKwl1fWf2vYc5FPHPhDntkGGFB1e34C0dAiTdyUMV+J7Mo FBIgUvlcF/HItsBAUBtQi4duD/zpGSUmyrzkJT4NxG1TisN8vg+RPnHbe9aD3Ng3vSYk x2RuYsIE3we8SUPEo8/vZ7UgQGXhSXVDQdieBg5rRFAR6fH7nqKqX/UXWllvDv06q6ZP y7q3ngDGNNmyniAHmBXyjyVGdcVd74RG3dzS9YU8g/4l16dMn7tnbVkQHZeL6mc0fam8 S7DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716830546; x=1717435346; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PnvVRBfAg4fgwYOlnsiNChCwPimaszaBxRkTDa8PSks=; b=FDrlJe8w6m8Q26oNFnu4N4g3BAMUxaNOOlfwEacZjJkQRlPaGNZz5z7h5SMb74KQTW EdgZQjb1TMXUwueUAZ03iu+JCaM99nyltkOeiuFbJGWsoJOiEIJakhpSnUIy6CAO9lFh u8q7Wei4p0mSylaNo4f6VDR+FwRFPsy/VaWqS4amSeHLgV17UjafgLQ5Uz+OueuYoXrd upTy1SwrADiYVAG68NjcOjHaDcmamuKT12MkxW10gk3NBGS0NzH1fB8v/MGnMmMA/tyC wc45SFAMNm/udCdoJNIRbs3cpiJAiKI2/SPq+xBw3oPJTkBQeVjuYAVTo57hXokGSpH6 +iiA== X-Forwarded-Encrypted: i=1; AJvYcCVhELEhcFkdRlh/Ducd3IrvveYxcKH4kEDJUGbskwsLmWULHZWbYDdcDTanrmySMIlAQWV7GPJ5aHcHoP9hVS2/kpM1v6Q= X-Gm-Message-State: AOJu0YyCeB1uKXqcKKyg5jKuoGJsZKvZSYIwpqz1PIXayBazJM7GpKls vGreVfv87q9Y9WqSGc0+BpOAfy6rBQAuTtVFUy/mlCN3cUpf6rJCFLKNmTnYO+933wj8qQKkxf4 t+rWp918c0yAK+LT1iJ1+MpjvJ0Y= X-Google-Smtp-Source: AGHT+IFvk+WF/GsJvlzz8tkskVs6q8dLkQr7CDQj8CKMgZ+wrCYieteSN3Ghrk8PFzkvzOlUdu7q86bA7kWEdhQcDjs= X-Received: by 2002:a05:6512:3f1f:b0:523:91d1:12b2 with SMTP id 2adb3069b0e04-529644ec081mr7006608e87.6.1716830546287; Mon, 27 May 2024 10:22:26 -0700 (PDT) In-Reply-To: <87ed9np6n8.fsf@betli.tmit.bme.hu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286056 Archived-At: On Mon, May 27, 2024 at 5:21=E2=80=AFPM Felician Nemeth wrote: > > Jo=C3=A3o T=C3=A1vora writes: > > > So when e-m-m-hook was added it was made to run only on "turn on" > > If I remember correctly, the original intention was to use the hook when > Eglot "turns off" as well. By "it was made to" I was just stating that that's how it turned out and that's where it probably solved practical problems that some user was facing. IOW, I don't think there was ever a time when it was ever run at "off" time. But you're right the docstring seems to indicate the intention was to replicate eglot--managed-mode-hook. So that lends a bit more credibility to the fix I proposed, I guess. Jo=C3=A3o