From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: master 78fc49407b8 1/3: Improve filling of ChangeLog entries Date: Wed, 31 Jan 2024 13:22:38 +0000 Message-ID: References: <170643232559.30479.16631610453249222615@vcs2.savannah.gnu.org> <20240128085846.187A2C1DAE4@vcs2.savannah.gnu.org> <540cc339-b7d4-4c1a-b084-c7f739ad4947@gutov.dev> <8734ue327d.fsf@gmail.com> <87a5omf1e8.fsf@yahoo.com> <878r45px71.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1010"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jan 31 14:23:56 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rVAZI-00005z-AD for ged-emacs-devel@m.gmane-mx.org; Wed, 31 Jan 2024 14:23:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVAYO-0002mA-4b; Wed, 31 Jan 2024 08:23:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVAYJ-0002le-5H for emacs-devel@gnu.org; Wed, 31 Jan 2024 08:22:56 -0500 Original-Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rVAYH-0007Pi-Cz for emacs-devel@gnu.org; Wed, 31 Jan 2024 08:22:54 -0500 Original-Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-5111f40b8beso2019367e87.2 for ; Wed, 31 Jan 2024 05:22:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706707371; x=1707312171; darn=gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XfpAA5ySL1QdQuJqcIcrjV/t9OP7sRfOF8v21vUwWxw=; b=bgRP2/1o1l7o8pX03G6QxTnBEl0nKkvmfxjlB9V2RawDso9cojcYsoBZn6QWxjkBC9 dn2cx1/UfF4f+gM7N+wlb577mandVwI+XVXcoEp25vMNGdRTpAp43DkXHum9MAG+942K WjKm/k86bPZ5hxjIRQroI7aooc0o7ASgSCPtxi8eB3PORMJIL6HPzJ9YIqURk3EtleaO ja+HH++BfID7GLF1g+xKBV97n8fbvadkocf5YELm3qrJVsXDBnKks78rZU0SEPg7HSZ/ 5Zsh+oe/hl0IwI80IQmah7Q98/OEbsEzG4InNC5J779Yd090ql2ABBSVGxnJLpSjbqGT YGfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706707371; x=1707312171; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XfpAA5ySL1QdQuJqcIcrjV/t9OP7sRfOF8v21vUwWxw=; b=rrCnJzovn11dThswmw448dEWM+d7xVfudEP0bJHS9wdDOS5XYKpTEIpcfkXYtDaHPO neDDBR8kPp0yt9IXo7k/dEz0dW8W1MtDjsHMC57YUrFrdZaWIjez3f6BSP33Au/pS3fd H/buN5FLdRMwu1Q709IL4d/YF6IXRo95CmPnZgOS9YWzF54Ax/RRpVPkmcPq/zsDCA1L 3Fnl5EM+8cj7WQb+xWFID/iXnpwNfVtOFdh8AQNa0IOk82qP9n57Dd2bAOtXyOnj0uLD SBKXGqCKgcrshFkaSIQkmzQDCMgLvbvVk13lOKsxmkJGxLcXH3kCusQgCJjTD1CAzymp APcg== X-Gm-Message-State: AOJu0YyiP6K+lBeAcrtqWa2iaRIncPfdVaAp41aLJMnVUepqr0zo7F/V Wh/FvVNpH792qit6sgv0Ksy7d0y6B4khpppc6FN94gVjUpBE4JMRP+W0JZ/VTOCQOIKxd7ERZPb o35n5vVhG+HBkVH00VxGpmpjnsafNOh2xD34= X-Google-Smtp-Source: AGHT+IEK30iasNMRqnJ0xCU9fdtpUlcuY/GK2RUQSoik8ccs80fY8KlTzZYkqiZcPMSKSZzViyQ8P1QDe0vPLbMpRS0= X-Received: by 2002:a05:6512:b91:b0:510:12e2:12a8 with SMTP id b17-20020a0565120b9100b0051012e212a8mr1617704lfv.7.1706707371195; Wed, 31 Jan 2024 05:22:51 -0800 (PST) In-Reply-To: <878r45px71.fsf@yahoo.com> Received-SPF: pass client-ip=2a00:1450:4864:20::130; envelope-from=joaotavora@gmail.com; helo=mail-lf1-x130.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315665 Archived-At: On Wed, Jan 31, 2024 at 11:19=E2=80=AFAM Po Lu wrote: > I don't doubt that these particular `cl-loop' or `pcase' > forms are simple to understand, provided that the reader takes the ten > or so minutes to absorb the relevant portions of their documentation. As I said, I'd just use edebug or macroexpand these things away, like I did. You do know edebug, right? And pp-macroexpand? The latter takes not even 10 seconds, what 10 minutes!?? Also, do you have any remote idea how much time it will take someone to read your code which has grown those functions 3 or 4 fold?? > avocational projects such as Emacs, where I make a mental note of tasks > that interest me, and pick the least time-consuming of them to complete > whenever free time (which, surprising as it may be, is scarce) does come > my way. Judging by the number of follow-up bugfix commits, you misjudged that badly. > Which is also the reason I requested no more than that you not install > your version now, leaving the door open to future improvement on your > terms once I finish making it work. Of course not, it's now yours. Probably forever. The unit tests are basically the only thing I can read from your code. Really, in practice you'll be probably be the only one ever reading that long-winded Fotran-like code, so I wish you stick around for a long time maintaining it. The only "improvement" I'd have is reverting all your work and applying my succinct patch that meets the current goalposts. If you move them or invent new ones that's another matter... hopefully that will also come with tests, or even some minimal discussion. So while the code would go back to being simpler (even without cl-loop) you'd probably be demotivated to keep maintaing the file. Also the history is already botched, I'd just make it worse. Really doesn't justify rewriting your code. It'd be a poor, almost ridiculous, way to "collaborate". > diatribe was unnecessary (and I'm not certain I disagree with > most of it) If, in all that sea of bravado, it has dropped a grain of self-doubt for next time you're pulling out the bulldozer, I consider it a diatribe well tribed. Anyway, have fun, and all the best Jo=C3=A3o