From: "João Távora" <joaotavora@gmail.com>
To: "Johan Bockgård" <bojohan@gnu.org>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: Fwd: Flymake and the 'face' property
Date: Tue, 29 Jan 2019 18:49:12 +0000 [thread overview]
Message-ID: <CALDnm535Oewm9Thw36phsHGJJ-y571_b4ieUeZfgPOHk-3ZpOA@mail.gmail.com> (raw)
In-Reply-To: <87munj2tzz.fsf@gnu.org>
Thanks Johan, but this should be legal as long as rng-error
is *not* used as the name for a face.
But indeed I think Eli's rule-of-thumb is wrong there.
João
On Tue, Jan 29, 2019 at 6:34 PM Johan Bockgård <bojohan@gnu.org> wrote:
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> Now, flymake.el happened to be unlucky enough to store these
> >> properties in the plist of a symbol which, by doubling as a face
> >> symbol, already had some implementation-specific a meaning for some
> >> of those properties.
> >
> > A 'face' property is documented for general use only for text, not for
> > symbol plists.
>
> The `category' feature for text/overlays uses symbol plists to define
> its default properties. `face' is probably one the more common
> properties to use in a category. Let's see...
>
>
> ...a few minutes later, I find this in rng-valid.el:
>
>
> (defface rng-error '((t (:inherit font-lock-warning-face)))
> [...]
> (overlay-put overlay 'category 'rng-error)
> [...]
> (put 'rng-error 'face 'rng-error)
--
João Távora
next prev parent reply other threads:[~2019-01-29 18:49 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190128152540.6870.46132@vcs0.savannah.gnu.org>
[not found] ` <20190128152541.12A4D20B50@vcs0.savannah.gnu.org>
2019-01-28 16:05 ` [Emacs-diffs] master cd06d17: Fix bug with face-id after restoring from pdump Daniel Colascione
2019-01-28 18:14 ` Eli Zaretskii
2019-01-28 19:37 ` Daniel Colascione
2019-01-28 20:19 ` Eli Zaretskii
2019-01-28 17:58 ` Glenn Morris
2019-01-28 20:05 ` Eli Zaretskii
2019-01-28 20:12 ` Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) Eli Zaretskii
2019-01-28 20:39 ` João Távora
2019-01-28 20:57 ` Eli Zaretskii
2019-01-28 21:38 ` João Távora
2019-01-29 16:54 ` Eli Zaretskii
[not found] ` <CALDnm53FnkT+fjneg3uLNMsCu1MxJK1aKWQyvz85EjVdOyr4bg@mail.gmail.com>
2019-01-29 17:26 ` Fwd: " João Távora
2019-01-29 17:51 ` Eli Zaretskii
2019-01-29 17:54 ` Daniel Colascione
2019-01-29 18:30 ` Eli Zaretskii
2019-01-29 18:43 ` Fwd: Flymake and the 'face' property Daniel Colascione
2019-01-29 19:19 ` Eli Zaretskii
2019-01-29 18:47 ` Fwd: Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) João Távora
2019-01-29 18:53 ` Fwd: Flymake and the 'face' property Daniel Colascione
2019-01-29 19:00 ` João Távora
2019-01-29 19:21 ` Fwd: Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) Eli Zaretskii
2019-01-29 19:28 ` João Távora
2019-01-29 18:28 ` João Távora
2019-01-29 18:34 ` Fwd: Flymake and the 'face' property Johan Bockgård
2019-01-29 18:49 ` João Távora [this message]
2019-01-29 19:17 ` Eli Zaretskii
2019-01-29 19:33 ` João Távora
2019-01-29 19:48 ` Eli Zaretskii
2019-01-29 19:58 ` João Távora
2019-01-30 9:37 ` Stefan Monnier
2019-01-30 15:40 ` Eli Zaretskii
2019-01-30 17:05 ` João Távora
2019-01-30 18:01 ` Eli Zaretskii
2019-01-30 20:56 ` Stefan Monnier
2019-01-31 3:38 ` Eli Zaretskii
2019-02-02 8:23 ` Stefan Monnier
2019-02-02 10:12 ` Eli Zaretskii
2019-02-02 22:49 ` Stefan Monnier
2019-02-03 3:39 ` Eli Zaretskii
2019-02-03 12:35 ` Stefan Monnier
2019-01-29 17:52 ` Fwd: Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) Daniel Colascione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm535Oewm9Thw36phsHGJJ-y571_b4ieUeZfgPOHk-3ZpOA@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=bojohan@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.