From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Eglot tests on EMBA Date: Thu, 30 Mar 2023 13:45:51 +0100 Message-ID: References: <87y1nyi5cq.fsf@gmx.de> <87tty3eide.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17431"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 30 14:45:31 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1phrel-0004PC-3r for ged-emacs-devel@m.gmane-mx.org; Thu, 30 Mar 2023 14:45:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phrdc-00068z-HH; Thu, 30 Mar 2023 08:44:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phrdR-00067e-Rm for emacs-devel@gnu.org; Thu, 30 Mar 2023 08:44:10 -0400 Original-Received: from mail-oo1-xc2b.google.com ([2607:f8b0:4864:20::c2b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1phrdP-0003W7-JI for emacs-devel@gnu.org; Thu, 30 Mar 2023 08:44:09 -0400 Original-Received: by mail-oo1-xc2b.google.com with SMTP id n7-20020a4ae1c7000000b0053b61145406so2932477oot.11 for ; Thu, 30 Mar 2023 05:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680180241; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MoqqRLf91Pm4h6xl2zndooJJc/jeGqz/cUiblQPo2lI=; b=DkVWVf+rnu2KITa5hImwfcfXTlM2Eoap4pfLmplLKPO3oFhjHdZUwqrZHTN9LsXf5P QR2Ri8qarGd6DOcRp1Y5xheYUGcCfgrVscKSrulAanG/3Lutshuexb9DD1QLW5uGrmoc wcdV6N4hp71ZRaWkV3isAE17dfhUlYWJhVi5GWNi+Qb/vBplwSMgP4wx7TP8nkU5EvPP n/hxpznzMGieGkAPdKU1Rb4hlsCJhIMnkigeVel1wpchQE2BDDHyeWHtJwQmmRzMPA5E md/+CX+7DszgE3WSR+KgQ9We4kvJgd8u4bwfQbrn7IWAfNRiKz6/RdRD+ZJ5FFesCHJS YMMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680180241; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MoqqRLf91Pm4h6xl2zndooJJc/jeGqz/cUiblQPo2lI=; b=il7tfH1Tj1y4s2sBNB0OoK5/BHmxSMqPdJEGjgO9azguR6O/TemlWhj41QiunpXt1o FMwKEY7K1P/32qSjHAyfu8o5NMJOqWWEMYfvH5rQrSvTINm3nsEahgNTuEDoaMZqh6Sn Scm2H4mX2iOTqdgqZBbl/4gRNLyzkBwebnGYX+492xxLEuL1hmIHzKZF0uNtwN/wW4l7 E56zBiiWsdPz21FoZnWk5Ugg/7T8Z05DCuJ1Czdl2fCkOdbhaclrIl0KcKexq2rfWeeO LNt7AAoiLLxGHlwmb0fDl41TXGmY8OMhMXaFQO/H6sAyaFsAYs2nxcQpfcoEkn1D/d4y kBNw== X-Gm-Message-State: AAQBX9e6WzmNt4CEzGsz57rndX7Ow/2VIwP4x//iiALZsVErnnkm39Cy up+XacV/nN9KoD8f4GGEZrcI+0MmP3ykvkVEy74= X-Google-Smtp-Source: AKy350ax49VwkH/S0Qvrw1gKCuIImje2objp669Jq5wUnbagOzeO+VYzgr0JfgUq9OmATxP+xiS9VKxuoWhNop3YC44= X-Received: by 2002:a4a:a301:0:b0:53e:97e0:967d with SMTP id q1-20020a4aa301000000b0053e97e0967dmr311811ool.1.1680180240870; Thu, 30 Mar 2023 05:44:00 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::c2b; envelope-from=joaotavora@gmail.com; helo=mail-oo1-xc2b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304862 Archived-At: Michael, eglot-test-multiline-eldoc doesn't fail locally for me (or in the GitHub CI system (https://github.com/joaotavora/eglot/actions) though that is not running master. After reading the logs, I think it comes down to how you installed pylsp on EMBA. I think you should do it with pip install "python-lsp-server[all]" which install its "providers", which are some type of contribs. We could have code in eglot-tests.el to check if these "providers" are installed into pylsp, but I think it's better to just install pylsp like I provided, and start thinking of some other less problematic server for these tests. Maybe move the test to clangd. I think it would be equally valid. But I've not made up my mind if Eglot tests should test a wide or narrow field of language servers. Opinions welcome. Jo=C3=A3o On Wed, Mar 29, 2023 at 3:46=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > I can check the eldoc/eglot tests later, looks like I introduced it in a = recent commit and the test might need updating. > > Jo=C3=A3o > > On Wed, Mar 29, 2023, 15:34 Michael Albinus wrot= e: >> >> Michael Albinus writes: >> >> Hi, >> >> > FTR, I have changed test/infra/Dockerfile.emba to install also clangd = on >> > the server. This shall enable some of the Eglot tests, which are skipp= ed >> > at all ATM. Pushed to the emacs-29 branch. >> >> This has been extended for the master branch. On EMBA, there are now two >> jobs build-image-eglot and test-eglot, which run in every scheduled >> pipeline for the master branch. See for example >> and >> . The result, >> eglot-tests.log from the latter job, can be retrieved as artifact via >> . >> >> While 36 (of 50) tests pass, we have also one failing and 13 skipped job= s: >> >> --8<---------------cut here---------------start------------->8--- >> Ran 50 tests, 36 results as expected, 1 unexpected, 13 skipped (2023-03-= 29 14:07:00+0000, 75.388590 sec) >> >> 1 unexpected results: >> FAILED eglot-test-multiline-eldoc "eglot--tests-force-full-eldoc di= dn't deliver" >> >> 13 skipped results: >> SKIPPED eglot-test-eclipse-connect ((skip-unless (executable-find "j= dtls")) :form (executable-find "jdtls") :value nil) >> SKIPPED eglot-test-javascript-basic ((skip-unless (and (executable-f= ind "typescript-language-server") (executable-find "tsserver"))) :form (and= (executable-find "typescript-language-server") (executable-find "tsserver"= )) :value nil) >> SKIPPED eglot-test-json-basic ((skip-unless (executable-find "vscode= -json-languageserver")) :form (executable-find "vscode-json-languageserver"= ) :value nil) >> SKIPPED eglot-test-path-to-uri-windows ((skip-unless (eq system-type= 'windows-nt)) :form (eq gnu/linux windows-nt) :value nil) >> SKIPPED eglot-test-project-wide-diagnostics-rust-analyzer ((skip-unl= ess (executable-find "rust-analyzer")) :form (executable-find "rust-analyze= r") :value nil) >> SKIPPED eglot-test-project-wide-diagnostics-typescript ((skip-unless= (and (executable-find "typescript-language-server") (executable-find "tsse= rver"))) :form (and (executable-find "typescript-language-server") (executa= ble-find "tsserver")) :value nil) >> SKIPPED eglot-test-python-autopep-formatting ((skip-unless (and (exe= cutable-find "pylsp") (executable-find "autopep8"))) :form (and (executable= -find "pylsp") (executable-find "autopep8")) :value nil) >> SKIPPED eglot-test-python-yapf-formatting ((skip-unless (and (execut= able-find "pylsp") (not (executable-find "autopep8")) (or (executable-find = "yapf") (executable-find "yapf3")))) :form (and (executable-find "pylsp") (= not (executable-find "autopep8")) (or (executable-find "yapf") (executable-= find "yapf3"))) :value nil) >> SKIPPED eglot-test-rust-analyzer-hover-after-edit ((skip-unless (exe= cutable-find "rust-analyzer")) :form (executable-find "rust-analyzer") :val= ue nil) >> SKIPPED eglot-test-rust-analyzer-watches-files ((skip-unless (execut= able-find "rust-analyzer")) :form (executable-find "rust-analyzer") :value = nil) >> SKIPPED eglot-test-rust-on-type-formatting ((skip-unless (executable= -find "rust-analyzer")) :form (executable-find "rust-analyzer") :value nil) >> SKIPPED eglot-test-snippet-completions ((skip-unless (and (executabl= e-find "pylsp") (functionp 'yas-minor-mode))) :form (and (executable-find "= pylsp") (functionp 'yas-minor-mode)) :value nil) >> SKIPPED eglot-test-snippet-completions-with-company ((skip-unless (a= nd (executable-find "pylsp") (functionp 'yas-minor-mode) (functionp 'compan= y-complete))) :form (and (executable-find "pylsp") (functionp 'yas-minor-mo= de) (functionp 'company-complete)) :value nil) >> --8<---------------cut here---------------end--------------->8--- >> >> Could somebody check why the test eglot-test-multiline-eldoc fails? And >> are there recipes how to install the missing dependencies in Debian >> bullseye, in order to activate the missing tests? I've digged for >> recipes of clangd and pylisp (see test/infra/Dockerfile.emba target >> emacs-eglot); doing it for the other dependencies would be too much for >> me. >> >> Best regards, Michael. --=20 Jo=C3=A3o T=C3=A1vora