From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#73472: [PATCH] Substitute quotation marks in Eglot messages Date: Sat, 28 Dec 2024 13:29:44 +0000 Message-ID: References: <86setnbu3n.fsf@gnu.org> <86ldzfarnd.fsf@gnu.org> <86ploex3e7.fsf@gnu.org> <86r08stah0.fsf@gnu.org> <86zfn0lgea.fsf@gnu.org> <865xowojsi.fsf@gnu.org> <86frnim9ol.fsf@gnu.org> <86y10lyy3s.fsf@gnu.org> <861pxsul6k.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000003ab0c0062a5493db" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30590"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Thomas Voss , 73472@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 28 14:32:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tRWvK-0007pf-JK for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Dec 2024 14:32:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRWvF-0005X6-0Y; Sat, 28 Dec 2024 08:32:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRWvD-0005Wv-HM for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 08:32:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tRWvC-0000XP-4u for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 08:32:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=RNd2BlHCxpHc9ZNDtqMO4xfbt03eaGXAEYtJJOyRcCM=; b=S4zrKIymki+ajOJpFW+TLXZvSIEQbMSXVh2UssqGXs6AsvJrqdSNCdbkReroZWyXOcgTNzjxo5/XPt0xbY2/291aJUy2T/Ol2QgrZJBnhDwxxlgb46Z4KdZ54rHOIHpm2uoxG5QTo3x/eMXh4w5KFVkjQHUGNMarUV5MAgGI6edDt6sAA3PjzNMKAWIpC8k3cYtudUkAj1E8alayLq+Qj6U8OcA/I9YYzn4rbWnHTa2iM9O5XGiyqZuDjDUVBxuMCloenisvjqR0GSh9YJrtDwmzRAVL4nG/XSy1kLT93f6ta4ie6pujKhyULgILEW6Zv/IlH/+wk0W/QnPvmP74mg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tRWvB-0005C3-Vm for bug-gnu-emacs@gnu.org; Sat, 28 Dec 2024 08:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Dec 2024 13:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73472 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73472-submit@debbugs.gnu.org id=B73472.173539266319885 (code B ref 73472); Sat, 28 Dec 2024 13:32:01 +0000 Original-Received: (at 73472) by debbugs.gnu.org; 28 Dec 2024 13:31:03 +0000 Original-Received: from localhost ([127.0.0.1]:49790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRWuE-0005Af-Lm for submit@debbugs.gnu.org; Sat, 28 Dec 2024 08:31:03 -0500 Original-Received: from mail-oa1-f49.google.com ([209.85.160.49]:56425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tRWuD-0005AD-DZ for 73472@debbugs.gnu.org; Sat, 28 Dec 2024 08:31:02 -0500 Original-Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-29fc424237bso3621377fac.0 for <73472@debbugs.gnu.org>; Sat, 28 Dec 2024 05:31:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735392596; x=1735997396; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=RNd2BlHCxpHc9ZNDtqMO4xfbt03eaGXAEYtJJOyRcCM=; b=L6GPvs1NnSBgG5/J30JcuNaV/uoygMPRGAMq+Zf6mYdeANrLA2cfqsabBXo4FT3vop HwvGCH4KkP8PNBW67YFrCGkNuyoWMu+m947zDInvedK28yCFr7ZIZzAtfUZIRv+6fqDd CUsKLA/CL2siGxxHn4DR4nrcKzqFZ1kxTq0ZtTiMY6nGZ3Cxrl4a7VGeAI75E4G+sF52 WHK2cgi7gUCfMe0Ft3UE84TmTv3RL1oWezXIoJjqA3zWlcnqWBxjOWd+Gc3RmEVi52LC Fm1S7KyBaBmvPytPDWYEvokWtERI7wM4v9SuFnDgzMc2gPVAbOPMyZgdT0tDXkPdXWoH Oitg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735392596; x=1735997396; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RNd2BlHCxpHc9ZNDtqMO4xfbt03eaGXAEYtJJOyRcCM=; b=E+uUJ3LReE9XKxJizVZSwdBCJsde6Zw4Mu4SXber3yoowplTJN9UEqbtwQ04IRxhhO mfOOJgWRrwFGQH9bUWqT1h3ye+H/asV78oF2EX2hdfvvgxWt/kaL/vCJCxIcxstuqs/Y bZV/460hSMaZALZtiOqlQ331Ra7FOQTVG+K/vc5Xog4GRjYt0XtjaS4riv7qFUPVNqFU aCKQgMsIcj8ds224ry44M815eDtYsrfufkLpcUfqvWLa03hmise++zb5NOvatgE8WoCC PA6fPsr/mYUC2aZtHS9KthETfxPcRJLTstH3u4ZBLFqndphgn53uetWqfmpfVb/9UAB5 6JTA== X-Forwarded-Encrypted: i=1; AJvYcCXUXM3hXQBwtolgyjF7sqLdY/vj4Eo5dyIMFusVlbjwR6KKn1tJJ55CwiNHRRqj15LnUwRfcA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyVQFe5cYgjzCnQwCIF0VIWXwm+9suIoqaWk0BYfwgOGpOcOx8m 5TZh82dfqc3JMkaACG0P0Rtgp6iJfR34qf/uSnEF3d33Wpr2nDdhazdY35jGdm4mA7RweS/zGKQ zpf7cYr7H1O33LkO1D0hh96zBvLChYg== X-Gm-Gg: ASbGnctCqWthVkA7rlzbHo+WPBQHYUndwBP60SgFY++On5+O9rRYS5ENnpz6MA6mEqT wKEbwR6rZD2Hs+AxKoO7jV6rCpvV0pGvnc+qX X-Google-Smtp-Source: AGHT+IFm16ncnKqkZHE8Sz4zxfBL6T+uc2JQmV6dcW6R9Dc3Y/fzT8OcqR0LDac2klOQ4GysrtKBIJB1Uu7INHN7h38= X-Received: by 2002:a05:6871:e7c8:b0:29d:c624:7c3d with SMTP id 586e51a60fabf-2a7fb2ea736mr13116230fac.32.1735392595977; Sat, 28 Dec 2024 05:29:55 -0800 (PST) In-Reply-To: <861pxsul6k.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297903 Archived-At: --0000000000003ab0c0062a5493db Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Dec 28, 2024, 11:00 Eli Zaretskii wrote: > > From: Jo=C3=A3o T=C3=A1vora > > Date: Thu, 12 Dec 2024 10:57:48 +0000 > > Cc: Thomas Voss , 73472@debbugs.gnu.org > > > > On Thu, Dec 12, 2024 at 10:50=E2=80=AFAM Eli Zaretskii w= rote: > > > > > > > Date: Mon, 09 Dec 2024 19:01:28 +0100 > > > > From: "Thomas Voss" > > > > > > > > Apologies for the long delay; I have been super busy recently. > > > > > > > > > Ping! > > > > > > > > > > > Thanks. Jo=C3=A3o, any comments? > > > > > > > > > > > > My only comment is that the log message says "format-prompt", > but the > > > > > > code actually uses substitute-quotes. > > > > > > > > Uh=E2=80=A6 are we looking at the same patch? The log message in t= he patch I > > > > last sent does say =E2=80=98substitute-quotes=E2=80=99 for all the = places where I > used > > > > that function, and only says =E2=80=98format-prompt=E2=80=99 for th= e place where I > used > > > > that function (=E2=80=98eglot-rename=E2=80=99). > > > > > > > > Just in case, I attached the patch again to this email. > > > > > > Thanks. > > > > > > Jo=C3=A3o, are you okay with me installing this? > > > > Just had a look. The patch won't break anything, but it has some proble= ms > > around the part where substitute quotes isn't around a literal, but wra= ps > > a bigger block. I'll try to fix it. It would also be great to have > some file > > local symbol-shortening mechanism to avoid that long name, but I'm > > not going to worry about that. > > Ping! Did you have time to look into this? > No sorry. Fixed a much more serious but though. Early 2025 I will fix this patch, it's easy. Jo=C3=A3o --0000000000003ab0c0062a5493db Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sat, Dec 28, 2024, 11:00 Eli Zaretskii <eliz@gnu.org<= /a>> wrote:
&= gt; From: Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com&g= t;
> Date: Thu, 12 Dec 2024 10:57:48 +0000
> Cc: Thomas Voss <mail@thomasvoss.com>, 73472@debbugs.gnu.org
>
> On Thu, Dec 12, 2024 at 10:50=E2=80=AFAM Eli Zaretskii <eliz@g= nu.org> wrote:
> >
> > > Date: Mon, 09 Dec 2024 19:01:28 +0100
> > > From: "Thomas Voss" <mail@thomasvos= s.com>
> > >
> > > Apologies for the long delay; I have been super busy recentl= y.
> > >
> > > > Ping!
> > > >
> > > > > Thanks.=C2=A0 Jo=C3=A3o, any comments?
> > > > >
> > > > > My only comment is that the log message says "= ;format-prompt", but the
> > > > > code actually uses substitute-quotes.
> > >
> > > Uh=E2=80=A6 are we looking at the same patch?=C2=A0 The log = message in the patch I
> > > last sent does say =E2=80=98substitute-quotes=E2=80=99 for a= ll the places where I used
> > > that function, and only says =E2=80=98format-prompt=E2=80=99= for the place where I used
> > > that function (=E2=80=98eglot-rename=E2=80=99).
> > >
> > > Just in case, I attached the patch again to this email.
> >
> > Thanks.
> >
> > Jo=C3=A3o, are you okay with me installing this?
>
> Just had a look. The patch won't break anything, but it has some p= roblems
> around the part where substitute quotes isn't around a literal, bu= t wraps
> a bigger block.=C2=A0 I'll try to fix it.=C2=A0 It would also be g= reat to have some file
> local symbol-shortening mechanism to avoid that long name, but I'm=
> not going to worry about that.

Ping!=C2=A0 Did you have time to look into this?

No sorry. Fixed a much more= serious but though. Early 2025 I will fix this patch, it's easy.=C2=A0=

Jo=C3=A3o
--0000000000003ab0c0062a5493db--