From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#72701: eglot crash when project-files-relative-names t Date: Fri, 23 Aug 2024 16:08:15 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27745"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , 72701@debbugs.gnu.org To: Ship Mints Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 23 17:08:36 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1shVtz-00075k-Ib for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Aug 2024 17:08:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1shVtg-0005Lt-0Q; Fri, 23 Aug 2024 11:08:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1shVte-0005Lk-V8 for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2024 11:08:15 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1shVte-0006ti-Mg for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2024 11:08:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=y87nO0n5TZd0rdstJxGZRz5SitTsrnmJ+CyJJ+pY+Yg=; b=YqKqvP63PVqoKup2EG2wenkEnsUxRl4Jc37U7HE8Bnz0G555xBXJ6BzDRqFCv24HHWvW3ykJ5R7XNYd6raFr9JP6XbsDarlAxKb6fMSXVfgpkaSZTdcoLgclPFKPahw4KMXxz0+AcjxhnrRsKxSG3ANtRzJpOygq7XRvHg7ALSswpM1aiTDnU4MfZeSHu/DGp4y6i4FQPGbgJKERYyJbvtkhRWRPkBSibJJ4aQokQD7mXIIrVkj4mlxRZRmm6ZvWL5CTAeqyEwVlhAUToSId3uoybsTk0ws+Rau0yA56bUD5zJCIV8cXLUyLwxX+eZvjKayZLRtlxsT9X82JtaoB9w==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1shVuP-00036l-Ln for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2024 11:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2024 15:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72701 X-GNU-PR-Package: emacs Original-Received: via spool by 72701-submit@debbugs.gnu.org id=B72701.172442573511935 (code B ref 72701); Fri, 23 Aug 2024 15:09:01 +0000 Original-Received: (at 72701) by debbugs.gnu.org; 23 Aug 2024 15:08:55 +0000 Original-Received: from localhost ([127.0.0.1]:39981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shVuJ-00036R-4t for submit@debbugs.gnu.org; Fri, 23 Aug 2024 11:08:55 -0400 Original-Received: from mail-ot1-f49.google.com ([209.85.210.49]:54499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shVuG-00034z-CN for 72701@debbugs.gnu.org; Fri, 23 Aug 2024 11:08:54 -0400 Original-Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-7095bfd6346so1916501a34.0 for <72701@debbugs.gnu.org>; Fri, 23 Aug 2024 08:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724425619; x=1725030419; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=y87nO0n5TZd0rdstJxGZRz5SitTsrnmJ+CyJJ+pY+Yg=; b=F47hGYRdGnyKKEV0wYZVFKqBoO0CD6W9ohafPsHH1FBmaf/Uti3RWs3Bf3uJEXPK5N SSLFyQlGn5KX8xYFMCik3HvDBP4oe9LJnRgu8uoMLq5dfZeI24g/5WRa3lncRhtOS8Fb nTJ+tfKOn77wcR5GCTBQgiU7lBhgpqQL7Q/xPbSsDNFVy9pQGESzi4+XEuWj1oLwbQJ3 Rfsa+RE44uY08wLQlJzN5GZBNOxAj0Z2tPfjzbSsRFVgjSx71DxIQwxd2HBLVVQC8yJU JDWogwS9TjH5/BJuQHPtuPS5r1ta8M8JtlyuEaTKbz4g4EmYfRbAReKJrC/HIUSmo0Bw 6TMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724425619; x=1725030419; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y87nO0n5TZd0rdstJxGZRz5SitTsrnmJ+CyJJ+pY+Yg=; b=vHakOaxqYDnglaXJRzhcnT5HQXJZ76VdyAFWYr1rSxULM0oPnTlMHu6O7XpkoSk2Ul t7Z6wOkAS7vuBqaz0SgqFjLcxwC1mFdExiprPHmAKRGlM48AkSGECBl/3Ur9wrUc+y5M zu+0yeZLcYHsxlVhzPqaOV5PcbVTbDr4lge5+CCjpR4L+Is8gNVaCVIhcWqwwy0xoABg BKnMiuDDhYKgHcuL/VWVyveFPgre9zYEUtJXjDcsxjhzdGoOZRVcyxBeL5nMostRHFXy P+LI+wgCQ+HB0cz5K8Z1bUT2jjcwb4UmmdHxomrOrYiYii2ZC46Y99jvfgHjebeQYZZq I56g== X-Forwarded-Encrypted: i=1; AJvYcCWUC7lPkilx8BhEIgtzU4Nb76bR5XGLR5hdcU6G/pqkuJbQawR8X5lxnC47gPfQfpUIUomQ6Q==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzjADPFGXKI3WtA8z+alkOmO0nv/ugPU7u7Ri9gzk+v7KQMlXnY pfExIrnFe0aTQax47JbcDXUK7V9PpCZdNuS8bSEzd/va8f/VOyoJrpDG1bkicSD1pzrpIIQsFX7 XlqdnJcj/Y6DOTU8pRrI5qLr+wrA= X-Google-Smtp-Source: AGHT+IF3+R4NUDpte096c1yyGOxmFPIlXi8PIFuJN0Pg9qN0U/OTIGepIGiwNIh3FqCEDgxm2DSOkI6MzfWnpNi/5Ps= X-Received: by 2002:a05:6808:1914:b0:3d5:65d5:edae with SMTP id 5614622812f47-3de2a8a0828mr2963284b6e.27.1724425618966; Fri, 23 Aug 2024 08:06:58 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290598 Archived-At: On Fri, Aug 23, 2024 at 3:56=E2=80=AFPM Ship Mints wr= ote: > > Glad I set project-files-relative-names to t and have been testing. This = side-effect in Eglot is sure to bite other people who are teased by the NEW= S of this new option, despite not being a defcustom. If it's not a defcustom and, as Dmitry said, not meant to be set by the use= r, I suggest you _don't_ set it globally, but ask for it to be let-bound in whatever features you want to make use of it. Eglot could be one of those features if there's a performance advantage. But I doubt it, because server-supplied glob expressions may target the full file name (indeed likely the truename). Maybe it's worth it neverthel= ess, dunno. Anyway while let-binding p-f-r-names to nil in Eglot could work, I don't think it's the right solution, especially since it probably triggers = a compilation warning in older Emacsen which don't have this. Unrelated, there are other enhancements to Eglot's file-watching machinery. One of them is about excluding files from over-eager watching by the server which could eventually bump into OS limits for these OS objects. Jo=C3=A3o T=C3=A1vora