From: "João Távora" <joaotavora@gmail.com>
To: Ship Mints <shipmints@gmail.com>
Cc: Dmitry Gutov <dmitry@gutov.dev>, 72701@debbugs.gnu.org
Subject: bug#72701: eglot crash when project-files-relative-names t
Date: Fri, 23 Aug 2024 16:08:15 +0100 [thread overview]
Message-ID: <CALDnm53-oQe4Je7tUr9V1Km0FJhTGFABg=h5CRu1JFFOCfaGXQ@mail.gmail.com> (raw)
In-Reply-To: <CAN+1Hbq55r=6PPx9=PUrZ32-S6KbwiNSUbMs6p=DOcro1+dnWg@mail.gmail.com>
On Fri, Aug 23, 2024 at 3:56 PM Ship Mints <shipmints@gmail.com> wrote:
>
> Glad I set project-files-relative-names to t and have been testing. This side-effect in Eglot is sure to bite other people who are teased by the NEWS of this new option, despite not being a defcustom.
If it's not a defcustom and, as Dmitry said, not meant to be set by the user,
I suggest you _don't_ set it globally, but ask for it to be let-bound
in whatever
features you want to make use of it.
Eglot could be one of those features if there's a performance advantage.
But I doubt it, because server-supplied glob expressions may target the
full file name (indeed likely the truename). Maybe it's worth it nevertheless,
dunno. Anyway while let-binding p-f-r-names to nil in Eglot could work, I
don't think it's the right solution, especially since it probably triggers a
compilation warning in older Emacsen which don't have this.
Unrelated, there are other enhancements to Eglot's file-watching
machinery. One of them is about excluding files from over-eager watching
by the server which could eventually bump into OS limits for these
OS objects.
João Távora
next prev parent reply other threads:[~2024-08-23 15:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-18 15:43 bug#72701: eglot crash when project-files-relative-names t Ship Mints
2024-08-22 17:04 ` Ship Mints
2024-08-22 17:52 ` Eli Zaretskii
2024-08-22 17:53 ` Ship Mints
2024-08-22 20:38 ` João Távora
2024-08-23 15:07 ` Ship Mints
2024-08-23 22:49 ` João Távora
2024-08-22 23:22 ` Dmitry Gutov
2024-08-23 14:56 ` Ship Mints
2024-08-23 15:08 ` João Távora [this message]
2024-08-23 15:10 ` Ship Mints
2024-08-23 23:51 ` Dmitry Gutov
2024-09-07 7:20 ` Eli Zaretskii
2024-09-08 2:24 ` Dmitry Gutov
2024-09-08 10:56 ` João Távora
2024-09-08 20:51 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm53-oQe4Je7tUr9V1Km0FJhTGFABg=h5CRu1JFFOCfaGXQ@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=72701@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=shipmints@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.