From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Wed, 2 Jun 2021 12:04:45 +0100 Message-ID: References: <87pmxhb1rs.fsf@gmail.com> <23510125-37b9-e87e-3590-5322f44772ce@daniel-mendler.de> <87y2c5nhsr.fsf@mail.linkov.net> <87h7irss50.fsf@mail.linkov.net> <43d1599e-2ba9-2efb-45c3-76c67d29a69d@daniel-mendler.de> <87tumrgqrb.fsf@gmail.com> <87tumq92pe.fsf@mail.linkov.net> <87lf82g10g.fsf@gmail.com> <87y2c24lww.fsf@mail.linkov.net> <871r9t2lsy.fsf@mail.linkov.net> <22880197-6d05-c821-2c58-328ed3cfc02e@daniel-mendler.de> <87eedruui3.fsf@gmail.com> <8dd915fe-fe67-2a45-67ff-8aaa3e9b9aca@daniel-mendler.de> <878s3zuq47.fsf@gmail.com> <09f2a253-84ba-5cfd-552e-0b89109864a5@daniel-mendler.de> <875yyxaoxp.fsf@gmail.com> <871r9laj6a.fsf@gmail.com> <1a183c3b.2f2f.179cb27f64c.Coremail.tumashu@163.com> <87lf7s7lli.fsf@gmail.com> <2dd59f1c-1d4d-a7d7-fae5-d9ca9b5c90c2@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35034"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tumashu , Juri Linkov , "emacs-devel@gnu.org" , Stefan Monnier , Daniel Mendler To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jun 02 13:06:06 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loOhJ-0008uZ-Hn for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Jun 2021 13:06:05 +0200 Original-Received: from localhost ([::1]:60748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loOhH-0005gW-Uc for ged-emacs-devel@m.gmane-mx.org; Wed, 02 Jun 2021 07:06:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59770) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loOgH-0004ke-Gj for emacs-devel@gnu.org; Wed, 02 Jun 2021 07:05:01 -0400 Original-Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:37447) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loOgF-0007KF-Q1 for emacs-devel@gnu.org; Wed, 02 Jun 2021 07:05:01 -0400 Original-Received: by mail-pj1-x102f.google.com with SMTP id 22-20020a17090a0c16b0290164a5354ad0so3251557pjs.2 for ; Wed, 02 Jun 2021 04:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Unjjl25Jqc74GZSRf56rHhLtrcR5VKYfuu49R/iqAnE=; b=c+dSS25J9Q9ik611SYlXMKR70qJ7AbK9r00pgozhzoLDS4/RGTWg03K4paw8t1aDZR 2aIomSxuUj9MMoC3qoXq0PknvcT2SMJUT6KvIjvTceyVhUweIl2jd1tWYlhd2Lqnt2EJ /s1VORDzHXEtJA1tt9kz3/eqJI6W7yp3+bAeizz69n+7BBepiKaWZblydOKefrg/7rOe 03RrVMb9caKpG+yptUDKOS5rLr+CzT192Wz3r/ABXXjVzguMa+VtrPmRpo0OdjpSzYr0 GyiUr9LW1Q4fpTKxXoUtfWEmWKbPvp2DT18gRShaEzQ4VDM0ibty5Dj7qmGxtuXcMaSR P+Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Unjjl25Jqc74GZSRf56rHhLtrcR5VKYfuu49R/iqAnE=; b=JxM2DgUhGC5AfTxhltSIa3SPOd5L5piEDXdRmQd0ytWguLLrUNCTl/XOPA9MDyj2U9 IaKVABCKXGF639i7qfl8mMBRnjrOqU+TporWW7ANvJZZl6oOGpNfOJk7hiprzS+pI6o4 PQ5a7eT4DKKYrrelUNm1CvIK6ft8m1Rkb75totaA8if/TZ7LZjOF+avC4zGBDkk2ZRKl 2nvNz1wPogwsQ1g42bebUYfD7CasWEhECUbWI01CP0Skav+k7+05gOQVCh/bUJrNxXSb L1sJGunH0AWYhZl8DOOveb08b1M6aXDhPN2xQjfdRXLpeLptMpCawu2LPg0/toxqXZ47 i+Sw== X-Gm-Message-State: AOAM530jhFDnYiu8LhdmkFrJvY4F2Vz6S2AP05TTbOmDj1V8mtvH4DeW eawqc0m4mnrDq5WevfMa1vDIs4m6lgSDN+gO8emKenGgW9Q= X-Google-Smtp-Source: ABdhPJzvOUKtDaRcaL6+czRHWAa+F+vSShtDeDse1fCvXbGY1KHakXhvw4pKcN4NnoJn+BTyJC2FUlDPQ6NtoIfIecw= X-Received: by 2002:a17:90a:1141:: with SMTP id d1mr30438371pje.56.1622631897217; Wed, 02 Jun 2021 04:04:57 -0700 (PDT) In-Reply-To: <2dd59f1c-1d4d-a7d7-fae5-d9ca9b5c90c2@yandex.ru> Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=joaotavora@gmail.com; helo=mail-pj1-x102f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270276 Archived-At: Wed, Jun 2, 2021 at 11:40 AM Dmitry Gutov wrote: > > And the whole constant updating thing is about > > "flickering" anyway. > Experience shows the above is a lot less jarring then hiding all > completions ("blinking" with the empty background) and then showing them > again. I don't mind what you call flickering at all, but to each his own, as usual. > icomplete's implementation is this approach should be a lot easier to > do, too. This seems to work okay: > > diff --git a/lisp/icomplete.el b/lisp/icomplete.el > index 91bbb60013..29138e089e 100644 > --- a/lisp/icomplete.el > +++ b/lisp/icomplete.el > @@ -154,7 +154,8 @@ icomplete--initial-input > > (defun icomplete-pre-command-hook () > (let ((non-essential t)) > - (icomplete-tidy))) > + ;; (icomplete-tidy) > + )) Great! i thought it would be more complicated, to be honest. > (defun icomplete-post-command-hook () > (let ((non-essential t)) ;E.g. don't prompt for password! > > > I would also suggest lowering the default of icomplete-compute-delay to > 0.1 or even 0.05. > > With 300ms delay, the new behavior does look a little weird. Can you remind us what that delay is doing there again? Anyway, it should probably consult a customization knob. Or maybe the new behaviour could decide based on icomplete-compute-delay If someone is customizing that to a low value, turn on the anti-flicker and suffer some little latency. If the normal value, keep the current flickering and 0-ish latency. Jo=C3=A3o