From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Eglot tests on EMBA Date: Fri, 31 Mar 2023 11:50:46 +0100 Message-ID: References: <87y1nyi5cq.fsf@gmx.de> <87tty3eide.fsf@gmx.de> <878rfddxeu.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40671"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 31 12:52:04 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1piCMW-000ANR-2M for ged-emacs-devel@m.gmane-mx.org; Fri, 31 Mar 2023 12:52:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1piCLW-0000mS-5X; Fri, 31 Mar 2023 06:51:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piCLV-0000li-1z for emacs-devel@gnu.org; Fri, 31 Mar 2023 06:51:01 -0400 Original-Received: from mail-oa1-x2b.google.com ([2001:4860:4864:20::2b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1piCLT-0007vb-FU for emacs-devel@gnu.org; Fri, 31 Mar 2023 06:51:00 -0400 Original-Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-177b78067ffso22739692fac.7 for ; Fri, 31 Mar 2023 03:50:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680259857; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VWkwxMImVZtTFjzGcdErUyxe9I0+RdMhc7EE9Gx2/+c=; b=q4JNN52OzB3PXrmb6U0FJBorcnlQlyMV6zvqWll9fiWzn8a32d5H3KXnmHjcY+ytZf +lo152vU88d15b115HAf3oBfQ/o7jm10Lgns9N383j6HEAGhW8cQ42SAokLCSAsuMM3l ajalmI8RpkQDMzw1qqZw3vfYHhBLXpzuW755I9GDZ2F2MSbLNjyFPIvYfiiLT6hYyD+L 6l/SUt7MF1dmNNothHTKfJVKmaW33FiXKJtglqCO7UA28Zxu6IN+pJ0UCaRtdgeCQUO0 RBpVaabufBmgR4Z2ezwhd9SyTNa7KKKHGVSIlajMmg0MivyGuCKUCuDPYPpMwBO6t6de PM3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680259857; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VWkwxMImVZtTFjzGcdErUyxe9I0+RdMhc7EE9Gx2/+c=; b=y22LMNO8yhD/ehc1LOwucRtVI71MQblyPFbwEs+eIxHpnIPImHHCr6jxIrp7mnUJHD 1M5owtwUviLFrH6s6y6GlhbfMeq55UBr9zS2wBpzJkOZC5BXuF60MQ9/waE/Xic36e7P nUktuxqb0qdB/IfRP35fGztNvhoOWyz+Pn3hUbOM+D1jClMRBnIMO8BfDTFWaDGaz+Rs bXTpMB5BiwsNV3zYzrTyqgyxcYBHGwn4tCisNzGdOnv/H+eo+AL0mBijY7cX06G8fatS q5N0uJUO6dWXHM7PBlelO/Ny6VLA5gge8a+JgaIvSWwBdVtuZ9vUsDcVcA20gsZKAR3D 15Fg== X-Gm-Message-State: AAQBX9f1UIJJ3cfSU6vic4R945Tr8yExjNIHP4V2EEp2HYK0GVToNGzk qt0++wgvEKZSDxQAGo3RR7YFURplhr2uXRChp+E= X-Google-Smtp-Source: AKy350bWsYZjs2VFMbXa/5QX7m9afm6f4IFsCpaX9YuDynSOkJ4uaHQSkacuOrfIyKvROT/8zmF9ZO3mH7GqmqxB4H4= X-Received: by 2002:a05:6871:4986:b0:17f:5b1a:20ce with SMTP id tx6-20020a056871498600b0017f5b1a20cemr5329568oab.5.1680259857188; Fri, 31 Mar 2023 03:50:57 -0700 (PDT) In-Reply-To: <878rfddxeu.fsf@gmx.de> Received-SPF: pass client-ip=2001:4860:4864:20::2b; envelope-from=joaotavora@gmail.com; helo=mail-oa1-x2b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304904 Archived-At: On Fri, Mar 31, 2023 at 11:31=E2=80=AFAM Michael Albinus wrote: > > Jo=C3=A3o T=C3=A1vora writes: > > Hi Jo=C3=A3o, > > > After reading the logs, I think it comes down to how you installed > > pylsp on EMBA. I think you should do it with > > > > pip install "python-lsp-server[all]" > > > > which install its "providers", which are some type of contribs. > > I'm not happy with this. EMBA installs a conservative list of software; > they shall be available as Debian bullseye package. Then you should complain to Debian and uninstall pylsp on EMBA is the meantime. > Since Debian bullseye does not offer the package python3-pylsp (which > will be available with a later Debian release), I install on EMBA > python3-pyls. This shall be sufficient, because (according to > eglot-server-programs) "pyls" is supported. > > eglot-tests.el does not dertect this, it checks only for "pylsp". I > believe this shall be changed, No, it shan't :-) I'm not even sure how to do so portably. Just undo your installation of pylsp on EMBA and I'll look into replacing that test with some other language server. Or run `pip install "python-lsp-server[all]"` in the dockerfile. Let's not overcomplicate eglot-tests.el with these things. > the check shall be for all alternatives > configured in eglot-server-programs. And not only for python, but also > for other languages. No, that's an immense amount of work and that's not what these tests are really for. People add stuff to eglot-server-programs liberally: it's a huge database now. I'm not crazy about that but is has always been the most fair practice to acommodate server preferences, and people seem like to see their favourite server at least represented there. But some of these servers don't work, are deprecated, have inconsistent executable names on different platforms: it's a mess. Testing that is way beyond the scope of eglot-tests.el. You may lobby for a eglot-server-program-tests.el instead, and I won't oppose it, but I personally don't have time for that, nor do I see a lot of value at the moment. eglot-tests.el is testing the server-agnostic Elisp logic in eglot.el -- Eglot _is_ server agnostic. We just happen to need someone speaking LSP to be able to exercise features. We could just as well have a (compliant) Elisp LSP server simulator and not worry about external language servers in eglot-tests.el at all. But that's quit= e a bit of work. So some common installations of language servers are needed= . `clangd` seems to be a fairly reliable one so I've been looking at transferring most of the tests that I can to clangd. But it doesn't exercise _all_ the features that Eglot supports, like file watching. I'll look into adapting this test for clangd instead of pylsp. In the meantime, just uninstall python-lsp-server on EMBA and let this test be skipped for now. Or install it like I suggested.