From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#71823: 31.0.50; project-mode-line and eglot duplicate project-name in mode-line Date: Sun, 30 Jun 2024 15:53:39 +0100 Message-ID: References: <86wmm9jfk7.fsf@gnu.org> <86o77kjk87.fsf@gnu.org> <17183c60-1733-4938-9a85-f3351c87bcb9@gutov.dev> <87jzi6fvar.fsf@catern.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000010b3b6061c1ca611" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20098"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Spencer Baugh , Eli Zaretskii , Juri Linkov , 71823@debbugs.gnu.org, Dmitry Gutov To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 30 16:55:15 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNvxT-000553-3Y for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jun 2024 16:55:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNvxJ-0004D2-43; Sun, 30 Jun 2024 10:55:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNvxG-0004B4-O4 for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2024 10:55:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNvxG-00083C-Dg for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2024 10:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sNvxG-0006Xr-9Q for bug-gnu-emacs@gnu.org; Sun, 30 Jun 2024 10:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jun 2024 14:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71823 X-GNU-PR-Package: emacs Original-Received: via spool by 71823-submit@debbugs.gnu.org id=B71823.171975929525137 (code B ref 71823); Sun, 30 Jun 2024 14:55:02 +0000 Original-Received: (at 71823) by debbugs.gnu.org; 30 Jun 2024 14:54:55 +0000 Original-Received: from localhost ([127.0.0.1]:58687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNvx8-0006XM-IJ for submit@debbugs.gnu.org; Sun, 30 Jun 2024 10:54:55 -0400 Original-Received: from mail-lj1-f178.google.com ([209.85.208.178]:42251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNvx6-0006XC-9k for 71823@debbugs.gnu.org; Sun, 30 Jun 2024 10:54:53 -0400 Original-Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2ec59193468so17583251fa.1 for <71823@debbugs.gnu.org>; Sun, 30 Jun 2024 07:54:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719759231; x=1720364031; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0K/gv80PfWc+pF4vcaSzy/jeAiwtJaehM63iSXuHnBQ=; b=R/MhwSp1D1e5QpuRgD4YV67cMjf9Znd/v0+XcULzL8CEJ7YzV28bMOQ+RUcmnjqzQc lyGRmUymWVX7jh+iRN1xDAMLeNG3kaQUTaIrgqQDq8RGLWvGhA0FF546FJRaJSDvz1zT k0RKFZAAW0iZBx55v2DFUB5pY2clmFTd7adLxAy1AsjitefCh0IEWAdJ2widU74gkt2/ AlWdBdfAKd3608fqOW5Aa0iT9E8yahkG8m6elKsxaDnfJUPYYK3uB0lBKvQPfaRKugyq JEyZiyvP84kgiYNgiR7OFbdaZTuMZJvoto1SEQNALU7JnQfs296wPtR8U7EMLH443lO8 5gIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719759231; x=1720364031; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0K/gv80PfWc+pF4vcaSzy/jeAiwtJaehM63iSXuHnBQ=; b=EE4u+R3azNDNnYJ1cgcBaCplNVFsmu1Tz4sziNOCJY/f0g5KEYIVTmQaqmCqgcr5oa tnaZFxn1e71tGJrm6rEy9yfD/zwXZmBG1eZSTbkZ5EIBmixXk3a5NURr4tTykjydssyQ CmKWsVa/7xdzsNEaqSY+7jQ85aGh0Xsl3R2qZmIPyPZ4MVGePeUCR8KsdBcKbz5e5tX/ cILxIJcrdPTotqo8WsZxowXcFxOd41huWeKiS8XgYlkyPAD2aTj6GC20sqGWSdXYLuz7 dN4LhStsCb95sw6jP/uavYZOxGgvdG1uN/MSBDaN6lpyM+cTly9B+FQi6O9LxSSiWAoa VbcQ== X-Forwarded-Encrypted: i=1; AJvYcCXorez3w3H1wFnc+gkVc1KhWql5dEfdV7zWiOTDXUb/niTwuFLvu9NOovIKDHAmgCx7tqjtSy/th7sjPtyZbh1XzLrG/Y0= X-Gm-Message-State: AOJu0Yzo8ia4L9P9dzH5MeNcRxGifgsMDuycqlHSA/bo3i3EDpfnCrHE /xgemHm0t3owgOvPcsAmP7jYEAis7hcb8mYpS+wUGhXA4scD50J0e2fwUwaotQMBsxCP2e6mYMD FB842AlENziplBvpm9ClZmd47QFg= X-Google-Smtp-Source: AGHT+IHSp7bsOp7TvsBlRGm0savk4VhtD5sXzntsmVbvtoMMQpXDXeqY+78u11H9zoA8qXmo+/W6A/rhjq655yPA3E0= X-Received: by 2002:a2e:9c50:0:b0:2ec:35a3:20bd with SMTP id 38308e7fff4ca-2ee53c89a66mr20570871fa.22.1719759231036; Sun, 30 Jun 2024 07:53:51 -0700 (PDT) In-Reply-To: <87jzi6fvar.fsf@catern.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288198 Archived-At: --00000000000010b3b6061c1ca611 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Jun 30, 2024, 13:51 wrote: > Jo=C3=A3o T=C3=A1vora writes: > > On Sat, Jun 29, 2024, 15:24 Spencer Baugh wrote= : > > > > Or, here's an alternative idea, more aggressive: > > > > What if Eglot just sets project-mode-line=3Dt in eglot-managed buffers= , > and removes the project-name from the Eglot entry > > entirely? > > > > Then the language identifier would be the major mode, the project > identifier would be project-mode-line, and the eglot status > > indicator would just be for the status of the server. > > > > Works for me, it's in line with Eglot's policy of setting other modes > when managing buffers. Show a patch. > > Attached. > > I do think this is a great way to resolve this - now that > project-mode-line exists, using it deletes one small bit of > eglot-specific functionality, which is in line with the Eglot design > philosophy. > Yes. The only issue is that this was only added to mode-line-format in Emacs > 30, so we can only use it in Emacs 30 or later. > No, that's not an issue, or rather your solution isn't the way to solve it. In trunk Eglot use everything that is in trunk Emacs. In released Eglot versions name sure you depend on capable versions of core GNU Elpa packages, a set which already includes project.el. So basically version bumps solves it. So please show an updated patch, and don't forget the etc/EGLOT-NEWS entry. > But also, my idea of eglot-mode-line-format should be alsoh considered. > AFAICT there no big technical hurdle, it's just relatively > > boring work and some naming decisions to make. And as I mentioned, it > would fix more issues than just the one at hand. > > Yes, I think that would also be useful as a separate patch. > Looking forward to it. Jo=C3=A3o > --00000000000010b3b6061c1ca611 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Sun, Jun 30, 2024, 13:51 <sbaugh@catern.com> wrote:
Jo=C3=A3o T=C3=A1vora <joaotavora@gma= il.com> writes:
> On Sat, Jun 29, 2024, 15:24 Spencer Baugh <sbaugh@janestreet.com= > wrote:
>
>=C2=A0 Or, here's an alternative idea, more aggressive:
>
>=C2=A0 What if Eglot just sets project-mode-line=3Dt in eglot-managed b= uffers, and removes the project-name from the Eglot entry
>=C2=A0 entirely?
>
>=C2=A0 Then the language identifier would be the major mode, the projec= t identifier would be project-mode-line, and the eglot status
>=C2=A0 indicator would just be for the status of the server.
>
> Works for me, it's in line with Eglot's policy of setting othe= r modes when managing buffers. Show a patch.

Attached.

I do think this is a great way to resolve this - now that
project-mode-line exists, using it deletes one small bit of
eglot-specific functionality, which is in line with the Eglot design
philosophy.

Yes.

The only issue is that this was only added to mode-line-format in Emacs
30, so we can only use it in Emacs 30 or later.

No, that's not an issue,= or rather your solution isn't the way to solve it. In trunk Eglot use = everything that is in trunk Emacs. In released Eglot versions name sure you= depend on capable versions of core GNU Elpa packages, a set which already = includes project.el. So basically version bumps solves it.

So please show an updated patch, and don= 't forget the etc/EGLOT-NEWS entry.


> But also, my idea of eglot-mode-line-format should be alsoh considered= . AFAICT there no big technical hurdle, it's just relatively
> boring work and some naming decisions to make. And as I mentioned, it = would fix more issues than just the one at hand.

Yes, I think that would also be useful as a separate patch.

Looking forward = to it.=C2=A0

Jo=C3=A3o
--00000000000010b3b6061c1ca611--