From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#69241: Fixed patch issues Date: Sun, 10 Mar 2024 14:41:07 +0000 Message-ID: References: <86msr7ye9h.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15858"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69241@debbugs.gnu.org, Eli Zaretskii To: Daniel Pettersson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 10 15:42:53 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rjKO3-0003tA-Iz for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Mar 2024 15:42:51 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rjKNi-00071o-MM; Sun, 10 Mar 2024 10:42:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjKNh-00071c-OV for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 10:42:29 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rjKNh-0000ax-DO for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 10:42:29 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rjKOE-00033Y-Cv for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 10:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Mar 2024 14:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69241 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69241-submit@debbugs.gnu.org id=B69241.171008175911709 (code B ref 69241); Sun, 10 Mar 2024 14:43:02 +0000 Original-Received: (at 69241) by debbugs.gnu.org; 10 Mar 2024 14:42:39 +0000 Original-Received: from localhost ([127.0.0.1]:37680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjKNp-00032l-JQ for submit@debbugs.gnu.org; Sun, 10 Mar 2024 10:42:39 -0400 Original-Received: from mail-lj1-f174.google.com ([209.85.208.174]:52703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjKNl-00032V-Gs for 69241@debbugs.gnu.org; Sun, 10 Mar 2024 10:42:35 -0400 Original-Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2d40fe2181dso28045911fa.1 for <69241@debbugs.gnu.org>; Sun, 10 Mar 2024 07:42:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710081654; x=1710686454; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=F0BB0PEKRQugwhzJfszMJGz+DycNdODvQ3K0xQsnqVY=; b=Dq6vzWy1Z4SdFYEBWEdVz3ulgQjhRueX2+0X8HKkYLqybJQDEmaW67JDTZ5fVY+pGg rxLgvfa8Sybx9QjgY/uMCICemTlciROGGBfXIDsms+zF2Os8lghbHYni21Dl+hGKQ8Un FkjYsUasA/qH0T3V/IGTWc1wKQls2sYh+ZI0XrGUaPkRuiACrtO8QNwRhJhC9WhthmJA knKUS10L/Jldbyp6r8Mnz6dg4cAzVNvZmUg8EtkF+tt5DC/5aHoPTUobQZCryoo5Dzmm Kzb2uBPepfhhb/JE4bB1KW8bLFOsnyuptNt73v66VkAkVQVQg+4dOg+hJQIXT37zTM+j wcKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710081654; x=1710686454; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F0BB0PEKRQugwhzJfszMJGz+DycNdODvQ3K0xQsnqVY=; b=iCU3SnCu9/3SX+bI8onNH5BdCRC+OeyKyDj4t0vFu7TgHIkmudW+yQnasFHjvYeSkT J2O5VRvnY3EVl/ygn0j+gD/+oVJh05yVI7EyCkKENjfd4vY0IF6es9JwfeGEVLCFG9u1 lNGvKG8UTON9bERTx82givTBQFfr2GtuWECDKEBsxcYYmj4w1Qiw4WfNgiSGTIwJouPU 5fMQKxOMg3eYvXqWRr3WzFkrZ+ETZuZR+TSwVpAcTn9OgU1Jhq2/IQM+WF1TMmm9HBL0 fLwSY1Uiyb9hq8BtGEZF/VR5aQqsr4/TRYP2ZOPUEV6pxEkCZs2t0aIFqzSsFAdjOr9n RXyw== X-Forwarded-Encrypted: i=1; AJvYcCVB1kJJYhYEEZDZm/sw13UwjyDzW8TfoSyKeOhqy7P1G7XVyhYted9oxuzvSSxgi2y109eGe5hlI9S1BQ9tU49MRoOIo6o= X-Gm-Message-State: AOJu0YxQskQ/pWi6HOC+vWIsmIfN2JGXxPki8c/esXBmeVzkdeb+ChTT z1+IhzjzhI7+8yUOk+RmE64P/9fakt0e7DrL1UmIdWBMFXNIb8ajgYSzaxoMAP0CGkzSv3Pbhtw rmrKu4G7gMcKdzALCe5Q5jE6+EkJQ6c1G/AI= X-Google-Smtp-Source: AGHT+IF0R5BgCTXuyKnvqxFQvL6XRVSJDooTZOIGpY03y59f2GUNkvU07qou6QlY9rTPcVFo6ZrZX1lk0RORYy3rTuI= X-Received: by 2002:a2e:928c:0:b0:2d2:7813:6ca3 with SMTP id d12-20020a2e928c000000b002d278136ca3mr2437341ljh.9.1710081653854; Sun, 10 Mar 2024 07:40:53 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281398 Archived-At: On Sun, Mar 10, 2024 at 2:28=E2=80=AFPM Daniel Pettersson wrote: > As I have previously stated I am willing to take on the maintainer role > for Jsonrpc. Thank you Daniel. It'll be in very good hands. > > + ;; `timer-activate' orders timers by time, which is an > > + ;; very expensive operation when jsonrpc-mqueue is large, > > + ;; therefore the time object is reused for each timer > > + ;; created. > > I am interested in what both of you think about relying on undocumented > behavior. > > To grasp the scope of this issue, an adapter server sent 50 000 > messages. With `read-process-output-max' set to the platforms max, each > of those messages where placed on `timer-list' in the same call to > jsonrpc's filter function, which then had to be sorted as O(N^2) > (calls to timer--time-less-p). > > Which makes Jsonrpc unusable for that particular server. I think your analysis is sound, Daniel. As you have noticed the run-at-time= 0 is not to actually use a timer, but just to get a call that is independent from the current call stack which may be nested because of the use case of bug#67945. The calls must be processed in the order of the queue though, but in theory that shouldn't lead to O(N^2) if a suitable technique is found (perh= aps different from (run-at-time 0)). Finally 50.000 is a gigantic amount -- are all of these essential? Can't t= he server coalesce this data into fewer messages within the DAP protocol? Jo=C3=A3o