From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Date: Thu, 5 Mar 2020 13:54:08 +0000 Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <21dc455e-b56e-3971-86f2-4773a57be64b@yandex.ru> <84206f04-6947-1440-9138-a950dfecb63a@yandex.ru> <2c5f6c44-7ca3-f1c9-d18d-3bf0d65548b9@yandex.ru> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000a1e05b05a01bdf69" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="8454"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 38992@debbugs.gnu.org, Stefan Monnier , waah@yellowfrog.io To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 05 14:56:07 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9qys-00022x-CA for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Mar 2020 14:56:06 +0100 Original-Received: from localhost ([::1]:49524 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9qyr-00076F-AQ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Mar 2020 08:56:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56220) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9qxs-0005ru-0v for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 08:55:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9qxq-0005Jt-MC for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 08:55:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36385) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9qxq-0005J0-H1 for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 08:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j9qxq-0003r5-Ed for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 08:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 13:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs Original-Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158341646714772 (code B ref 38992); Thu, 05 Mar 2020 13:55:02 +0000 Original-Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 13:54:27 +0000 Original-Received: from localhost ([127.0.0.1]:42358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9qxH-0003qB-6D for submit@debbugs.gnu.org; Thu, 05 Mar 2020 08:54:27 -0500 Original-Received: from mail-il1-f175.google.com ([209.85.166.175]:43548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9qxF-0003pz-Qc for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 08:54:26 -0500 Original-Received: by mail-il1-f175.google.com with SMTP id o18so5057520ilg.10 for <38992@debbugs.gnu.org>; Thu, 05 Mar 2020 05:54:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GzBuRZNalhxRnmk61kNrQRJ75BxEdXFes2BONRPNS6k=; b=W8Hvwy3Wl767GtHMkVzG8QZ/R+1eCGLddV1d3/F2Ze8YG/gOBJdHSoZec+GVN2U2dV E7wQ3iX+j4oC8p3/z9IGT3bl3u6TRFEZoO50oc+8vZ3+af5+cAx/ljSKyOYWQQJgDIVB A6HTjoD6s6PUqu+eZjAcYQjXsVj/FMFVCn2iEN50cb90TiDiS/JFfyq9qkLbvu+nSK5p hcOnEwd2HQg0dViwtBYkVfKh0hiODFetRmZA2w/PvXI45FXxd5uD/1VykOpErgN/ZcUo v6Dl78QVDnN+t/4MwEOdWzv0X7MYwZnuji2m/AzGFBzbB/bUBXvVvU1KQHIhg9JrmbLD s0tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GzBuRZNalhxRnmk61kNrQRJ75BxEdXFes2BONRPNS6k=; b=KVWYcoTA+MoBUzulsN58DpppOorlJTiKfF6I+gyJxHW24BNBFpgw9ygEkouoAb+f43 6UOg45AXYF/SgJX0nxZB76zAdVpt4nrgmBQWsOckdFEmKcpsEO24bkO1DR41sDdEAX1f JaAbgxxwgpvdQyBE6apPSkmGmkPZwTuxAAq3oVf4SBFkHu1iRxdwZz/w+9vH+sozj+aX EVQGs6HBE1KLJh5hu65EN03oUd1ShvHm/hii4kJ7D5FM9l6Gj1nYu1ENcUbh8gKuGFGE jNj+MHBo7vPiEtBTR7LxtOS4BBfIVcUsRq3BI+IjhnkojUFNlr0Q4LJgDLZRUfBJuo0j L90g== X-Gm-Message-State: ANhLgQ0AtJJExerFD7VvFYbv2guU56wOIivhsBgi/RV1obTkuDAqv4Q1 YVACg7fRMRLf64jmbwaMi/GNz2BPOxfEGaEgub4= X-Google-Smtp-Source: ADFU+vuvuDASZZ25fuorGbJpGuGTGnnaCIFo7ATKZOqDOE6dYO3VTEhmCAoKEcB2dooCGuXQ7Lnu7vUICtMkWaOuX+U= X-Received: by 2002:a92:8f91:: with SMTP id r17mr7572466ilk.97.1583416460040; Thu, 05 Mar 2020 05:54:20 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176904 Archived-At: --000000000000a1e05b05a01bdf69 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 5, 2020 at 1:40 PM Dmitry Gutov wrote: > On 05.03.2020 14:30, Jo=C3=A3o T=C3=A1vora wrote: > > And when they use that "out", and the program behaves randomly, > they'll > > get annoyed, file confusing bug reports, etc. Why would we want tha= t? > > > > > > Any of those things are better than the feeling of being trapped in a > > UI. > > First: I disagree with that assessment. > > Second: trapped by the UI or not, we are still limited by what values > the program that called completing-read is prepared to handle. > Of course. What I'm saying it that there may be completing-read that may benefit from an informed exit with something not in the completion list. Calculating a completion list is fickle and often it fails by scarceness. I mean... if your idea of an "out" is to give it a "finger-contorting" > binding and a secret password, of course that's unlikely to cause many > problems. > Yep, that's my idea. Or a C-u to your icomplete-fido-exit would do just fine, too. Assume "secret password" is you being funny. > I don't know how (or why) to add instructions to the docstring for > something that we advise against doing, though. What phrasing to use, etc= . > Well, I don't advise against it, you do. I just want to give users a better library. But if you're fine with C-u. > > Well, as I said I do remember binding M-j to it for this specific > > circumstance, but that's before your fix (which I am still to try out). > > Please do when you have the time. > Sure. > And also, here's a thought: anytime you feel like using > 'exit-minibuffer' to counter the REQUIRE-MATCH=3Dt argument, that should > probably be accompanied by a patch to the caller function to change that > argument to nil. > Sure, time-permitting, of course. But again, not that the changing of the argument might _not_ be the fix. I expect the real fix in those situations to be about the computation of the allowed completions. Those are probably more complex fixes. --=20 Jo=C3=A3o T=C3=A1vora --000000000000a1e05b05a01bdf69 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Mar 5, 2020 at 1:40 PM Dmitry Gutov <dgutov@yandex.ru> wrote:
On 05.03.202= 0 14:30, Jo=C3=A3o T=C3=A1vora wrote:
>=C2=A0 =C2=A0 =C2=A0And when they use that "out", and the pro= gram behaves randomly, they'll
>=C2=A0 =C2=A0 =C2=A0get annoyed, file confusing bug reports, etc. Why w= ould we want that?
>
>
> Any of those things are better than the feeling of being trapped in a<= br> > UI.

First: I disagree with that assessment.

Second: trapped by the UI or not, we are still limited by what values
the program that called completing-read is prepared to handle.

Of course.=C2=A0 What I'm saying it that there = may be completing-read
that may benefit from an informed exi= t with something not in the
completion list. Calculating a comple= tion list is fickle and often
it fails by scarceness.

I mean... if your idea of an "out" is to give it a "finger-c= ontorting"
binding and a secret password, of course that's unlikely to cause many =
problems.

Yep, that's my idea. Or a= C-u to your icomplete-fido-exit would do just fine,
too.=C2= =A0 Assume "secret password" is you being funny.
= =C2=A0
I don't know how (or why) to add instructions to the docstring for
something that we advise against doing, though. What phrasing to use, etc. =

Well, I don't advise against it, y= ou do. I just want to give users
a better library. But if yo= u're fine with C-u.
=C2=A0
> Well, as I said I do remember binding M-j to it for this specific
> circumstance, but that's before your fix (which I am still to try = out).

Please do when you have the time.

Sure.=
=C2=A0
--
Jo=C3=A3o T=C3=A1vora
--000000000000a1e05b05a01bdf69--