From: "João Távora" <joaotavora@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: master 73f37da: Disable undo in the process buffers of a JSONRPC connection
Date: Fri, 13 Dec 2019 22:09:04 +0100 [thread overview]
Message-ID: <CALDnm52mPj3Qx6jjjEtVUT-kJ3Ax5EzREDv3-tNnoNv8KkBYcQ@mail.gmail.com> (raw)
In-Reply-To: <jwvimmkrsjp.fsf-monnier+emacs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]
Hi Stefan,
They are indeed intended to be seen by the user. They hold important
communications between server and client, and I ask users to post their
contents when making Eglot bug reports.
Well I suppose the stdout one less useful than stderr.
And this is more of an LSP requirement than an jsonrpc one. I could
theoretically make Eglot tell. Jsonrpc to promote the buffer's visibility,
but that seems like overkill right now.
João
On Fri, Dec 13, 2019, 19:28 Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> Hi João,
>
> > Disable undo in the process buffers of a JSONRPC connection
> > + (buffer-disable-undo)
> > (set-marker (process-mark proc) (point-min))
> > (let ((inhibit-read-only t)) (erase-buffer) (read-only-mode t)
> proc))
> > + (with-current-buffer stderr
> > + (buffer-disable-undo))
>
> Assuming those buffers are only used internally and are not intended to
> be displayed to the end-user (other than for debugging purposes), then
> using buffer names with a leading space should take care of this
> (undo is disabled by default in those buffers).
>
> If you're already using a leading space in those buffers's names, then
> I wonder how/why their undo was enabled in the first place.
>
>
> Stefan
>
>
[-- Attachment #2: Type: text/html, Size: 1889 bytes --]
prev parent reply other threads:[~2019-12-13 21:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191213163543.19521.86114@vcs0.savannah.gnu.org>
[not found] ` <20191213163544.A0FEF2111A@vcs0.savannah.gnu.org>
2019-12-13 18:28 ` master 73f37da: Disable undo in the process buffers of a JSONRPC connection Stefan Monnier
2019-12-13 21:09 ` João Távora [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm52mPj3Qx6jjjEtVUT-kJ3Ax5EzREDv3-tNnoNv8KkBYcQ@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.