bug#74338: 29.1; JSON RPC timeout too short in some cases

["João Távora" <joaotavora@gmail.com>]

On Sat, Nov 23, 2024 at 1:26 PM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > From: Daniel Pettersson <daniel@dpettersson.net>
> > Cc: Jurgen De Backer <jurgen.de-backer.ext@eurocontrol.int>,
> >   74338@debbugs.gnu.org
> > Date: Sat, 23 Nov 2024 01:23:16 +0100
> >
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> > >> Date: Wed, 13 Nov 2024 12:43:20 +0000
> > >> From:  Jurgen De Backer via "Bug reports for GNU Emacs,
> > >>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> > >>
> > >>
> > >> Hi,
> > >> When using emacs together with eglot/ada_language_server,
> > >> some requests may take longer than the 10 seconds specified in
> > >> jsonrpc.el (defconst jsonrpc-default-request-timeout 0).
> > >> It would be better to be able to change this default value.
> > >
> > > Daniel, any comments or suggestions?  Maybe we should make that
> > > variable a defcustom?
> >
> > No real harm in converting it, it might be better of it was configured
> > on eglot as eglot-default-request-timeout but that would require some
> > work in eglot I believe.  The argument against it is that it could
> > have unintended consequences for other users of jsonrpc, but I think
> > it's something we can live with.
>
> João, any reasons not to make this variable a defcustom?

Not at all, if you're talking about jsonrpc-default-request-timeout,
but that's up to Daniel jsonrpc.el maintainer.

I'm against introducing eglot-default-request-timeout .  If your servers
are  really that slow, just increase the default timeout (what's the harm?)
or set jsonrpc-default-request-timeout buffer-locally in
eglot-managed-mooe.

João Távora