From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#73279: [PATCH] Eglot: use immediate-mode eglot--request for :completionItem/resolve Date: Mon, 16 Sep 2024 14:43:31 +0100 Message-ID: References: <87v7ywoh7m.fsf@taipei.mail-host-address-is-not-set> <86wmjbdehl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1838"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Brennan Vincent , 73279@debbugs.gnu.org To: Eli Zaretskii , Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 16 15:46:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sqC3i-0000JB-QD for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Sep 2024 15:46:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqC3D-0003BI-Cy; Mon, 16 Sep 2024 09:45:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqC34-0003Ac-Ih for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2024 09:45:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqC32-0001nj-W3 for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2024 09:45:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=bAXl7SX2xAGw2XqyNPOixPIQM3numhg+kkPeVgVjqv0=; b=pLGIT1Ald0Dou6IUc4MVohfmtOuvqzuTP2GpFOSbvk/UbGZkVWMtjmRFbLWpq7AVg5sWw8n/2vFvNJqKsIqP6IQUCxuTDRjUL/eHAWpNec57VXVQTPKnDwVpI7MwZ2GJnL+gfLLOSegQMpTQLyTxKxLU4EBHYMZ5VeoUQDXF0s+ZPS+v6Zc9692VS/2QoheWFsY6qn9IwNGge+T4tZEbqrRgsIiFXZIElW2LbITuk5S8/DvAGzuf6ujul8/MddyY1txcTV8UWbHHl8m0FPevS1B9K3364GjRXg1KipFljmQdh8XDc9c3+v2YRwsjhn5TfBrsEe9w69qyn12mIOemhw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sqC3G-0000lp-7i for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2024 09:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Sep 2024 13:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73279 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73279-submit@debbugs.gnu.org id=B73279.17264943052360 (code B ref 73279); Mon, 16 Sep 2024 13:46:02 +0000 Original-Received: (at 73279) by debbugs.gnu.org; 16 Sep 2024 13:45:05 +0000 Original-Received: from localhost ([127.0.0.1]:51343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqC2K-0000c0-Ol for submit@debbugs.gnu.org; Mon, 16 Sep 2024 09:45:05 -0400 Original-Received: from mail-ot1-f54.google.com ([209.85.210.54]:54688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqC2I-0000b5-Fy for 73279@debbugs.gnu.org; Mon, 16 Sep 2024 09:45:03 -0400 Original-Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-7092dd03223so492048a34.1 for <73279@debbugs.gnu.org>; Mon, 16 Sep 2024 06:44:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726494223; x=1727099023; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bAXl7SX2xAGw2XqyNPOixPIQM3numhg+kkPeVgVjqv0=; b=Ac5uhmSxJbj66Qvvw46bDy+aRghHHTG538izgTWi4nEfpQzXTDhlnbOf2SJnNiNWG5 6EEoo0b/FVFm1H91io/V5mjohmcxvO4y6xwG6ouGRsB4ASr2Si8HQ3Y36WGkdMXUdpXT QTwlboU0Fr5K/gyrsiT9noOezZcxN+sZhI7XC27uDpnfvqqvDetwvqlIPnJCZy5iTQlZ EuRbYT7B4Wr8YVjfxFqqAiWh1J3++B5YzTbZUhXyq9ciBSo2BWOENiho3nyNM0chtH5s 3Czf2LYx7qsTMaWsLj/QIAGovC7+p2IMoRCBs5pzfAlTC47nhcppcSq2JSryqnuORBIq k2sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726494223; x=1727099023; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bAXl7SX2xAGw2XqyNPOixPIQM3numhg+kkPeVgVjqv0=; b=fYTNhmxnEaPTQKebv9abGtvPfx3KvovfTmxXgRjST1OjKPYO0AnkygmZOz72V62qoH lQNWGWQPowFwdUoVi/W+X4ZYdGRoE2xCrwzVpcOAZUxagXHK9qopzW7est1YkU2mnOpo eyr9CPklFp2gSY4EPGbV5wI1m2BY4N7rWwPkMugLY6kij8ohsOyA3qfVOiUhTcWccuDR MVq5tlO73w05bkfmaRv6+lxS+YgallJvL7ZLwfUuVY4PtOtlg16athNfEat+D2euF+ab Tel2VrBb4HSRM0ohn0/Z1vmJ1lCNeloIjI33UcgcyJNu4y1q2dv2mi8kgQo86pnKZCNm 3vVA== X-Forwarded-Encrypted: i=1; AJvYcCW7AJaqZVLiggdT/LykgX6r5ReHKSPJXJMdaAEjCS2f5if2Ahn+X/2IAp905IvVV89uK+uKcw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxONjxdV6Uo3FzObgqzHzFPPNx174H+ZxtvtGv609H61qqp6HXX i80P7e9SEJeF9eUe5FhycRyUsXRNM7VVZhm46OFmKhsCVgYs3cj50i+qd48RUzhjriwgd0IZ7VE wXideDJZPkydsThUNNH+7EaTmWEs= X-Google-Smtp-Source: AGHT+IGqnK34Gf+pw79x0KYX30+870ejJkzPeqOMBm3AZp3s37Pt3VVmQ4U8Q8m+JGUjIz3/OzAgKFcUXbYQKmtXkqQ= X-Received: by 2002:a05:6830:90d:b0:710:e987:2659 with SMTP id 46e09a7af769-71116c67ac7mr7311426a34.22.1726494223215; Mon, 16 Sep 2024 06:43:43 -0700 (PDT) In-Reply-To: <86wmjbdehl.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291890 Archived-At: On Mon, Sep 16, 2024 at 12:28=E2=80=AFPM Eli Zaretskii wrote= : > > > From: Brennan Vincent > > Date: Sun, 15 Sep 2024 15:22:05 -0400 > Jo=C3=A3o, any comments? Yes, I have yet to try the reproduction recipe of this alleged problem but one thing stands out. Brennan, you wrote "as it did in Emacs 29.4". So this is a recent regression of sorts, is that what you're saying? I don= 't think that code has changed much over the past years. I also don't recognize the timing you're describing, but I'll comment on that after I've done my investigation. Usually there's a low chance a patch will easily go through in this very sensitive area of the code. But a low change is nonetheless non-0 :-) Maybe Dmitry can also have a look, as he's been tinkering with Eglot completion lately. Jo=C3=A3o T=C3=A1vora