From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] New option to make C-x 4 a use file-less ChangeLog buffers (was Re: git history tracking across renames (and emacs support)) Date: Sat, 21 Jul 2018 14:02:04 +0100 Message-ID: References: <86wp12qtgo.fsf@dod.no> <83tvw6chqv.fsf@gnu.org> <86shbprix7.fsf_-_@dod.no> <838t6jgl1k.fsf@gnu.org> <601m6cc6.fsf@lifelogs.com> <83o9fefnv9.fsf@gnu.org> <83in5lg4ol.fsf@gnu.org> <83efg9fxnj.fsf@gnu.org> <838t6hfa4h.fsf@gnu.org> <87h8l4lt9q.fsf@gmail.com> <831sc8fttu.fsf@gnu.org> <87sh4lwwg6.fsf_-_@gmail.com> <83r2k389j9.fsf@gnu.org> <87zhyqbx7s.fsf@gmail.com> <837elozx7j.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000009845be0571820562" X-Trace: blaine.gmane.org 1532178028 24680 195.159.176.226 (21 Jul 2018 13:00:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 21 Jul 2018 13:00:28 +0000 (UTC) Cc: tzz@lifelogs.com, Lars Ingebrigtsen , cpitclaudel@gmail.com, Stefan Monnier , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 21 15:00:24 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgrUi-0006Gx-7s for ged-emacs-devel@m.gmane.org; Sat, 21 Jul 2018 15:00:20 +0200 Original-Received: from localhost ([::1]:52380 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgrWp-0002wU-3s for ged-emacs-devel@m.gmane.org; Sat, 21 Jul 2018 09:02:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgrWf-0002wO-Av for emacs-devel@gnu.org; Sat, 21 Jul 2018 09:02:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgrWe-0005jZ-GH for emacs-devel@gnu.org; Sat, 21 Jul 2018 09:02:21 -0400 Original-Received: from mail-it0-x242.google.com ([2607:f8b0:4001:c0b::242]:52055) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fgrWc-0005iA-1W; Sat, 21 Jul 2018 09:02:18 -0400 Original-Received: by mail-it0-x242.google.com with SMTP id h2-v6so18282826itj.1; Sat, 21 Jul 2018 06:02:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pamm5t/PUXh7Y7UakqGimo4e2rpDtKMX39kCgzVQozI=; b=vQW4xzgutK1FXITSsvHWsH1YKBtRrI2lX+ZFdAVknIE2m/kyrCVPfnTsbWWB8gWZNX MwKOp5f0pQketGPYkGSprp5326LPzeT0t2c7fUabI8l+u6Ng63h3H+RUUojkCzEruZ9A yMbH2Hdc+z7qzOow30obzZezWRgBZ4Xm/nsgUWhAob1NowiqAzmCG8Xa/Y0PdlZhZMlI YGHvWlqRq18lWnOTnaLoqYfFGcj7RRH7R/HJPhuFq3Te0ZapQogQQcbvkRJldyNxTfZA zQOUAN28pNoKtkCclPcFiVm1It/2jAP2A8aD+3wGi0LidSfouB7rW9WhMJ5Dux6TQYOj WCOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pamm5t/PUXh7Y7UakqGimo4e2rpDtKMX39kCgzVQozI=; b=JI1jeD9i1JctoDl7P/UqM+fVeS8AOJ3xnJHb97AnNK3e7qxtJsOtkHhcLuYUFoHL/c 8vIdxppkDrK5JUTQrEOnWDFnFoJgGBwYnCmh3BiUk8pHNGzTPdvdyUgPcasfGUuzuU26 w0Ne2yv/jDduv3h+q/FXqHjqaWu9ojqZarPaIPtZl/2+cFQABeSWofw5iEN/wvTKj3O+ dNQi7FleKMw2yp+DTbpuYDPbfHwHKJit/VQu7EJhkk546EhAkzlPXxCfIo8D3t7BgBV/ CDJSvD4763MEiGffzl2z+5XyrWz6H44uQ9yJSgn6ba4ZJ3+8J7vyeMiBasixUKAyuuy3 baYQ== X-Gm-Message-State: AOUpUlF8YOBRpbVtJ3iU77O5dEbmxwaKXf3/nk1kEFYC4nJCdiq8NsNH Q1TPHHKN30cfB++e99cf+1xDRDr/tropJANhejrYsQ== X-Google-Smtp-Source: AAOMgpcaaVpEgZAbxt1aJmac+LNFxdRCoL0TQ1hbWXTH1BhO4QrcfCxvTJuguL8Eb6pq7x+0X1k7NZDVu3G0/RcfxOU= X-Received: by 2002:a24:ca06:: with SMTP id k6-v6mr4994151itg.104.1532178137103; Sat, 21 Jul 2018 06:02:17 -0700 (PDT) In-Reply-To: <837elozx7j.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4001:c0b::242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227613 Archived-At: --0000000000009845be0571820562 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Jul 21, 2018, 11:43 Eli Zaretskii wrote: > > Looks reasonable, thanks. > > > +(defcustom add-log-use-pseudo-changelog t > > + "If non-nil, don't create ChangeLog files for log entries." > > + :type :boolean) > > I frequently find that what we say in the doc string is a very good > hint on how to name the variable. So how about > add-log-don't-create-change-log-file instead? > Fine by me. But even with the apostrophe? > > Also, this needs a :version tag. > Right. 27.1? > > +(defun add-log--pseudo-changelog-buffer-name (changelog-file-name) > > + "Compute suitable name for a pseudo-ChangeLog buffer." > > + (format "*changes to %s*" > > + (abbreviate-file-name > > + (file-name-directory changelog-file-name)))) > > Would the name of the buffer be something like "*changes to ChangeLog*"? > That's awkward, IMO. How about just "*ChangeLog*" instead? > Yeah, that would be pretty awkward, hehe, but it's not what happens, because of the file-name-directory call. > > The above are minor nits, so what else is left that needs to be agreed > upon? > Nothing, afaik. Stefan had said he would probably enhance this later with uniquify support. I'll do the NEWS, should the manual also mention it? Jo=C3=A3o --0000000000009845be0571820562 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


= On Sat, Jul 21, 2018, 11:43 Eli Zaretskii <eliz@gnu.org> wrote:

Looks reasonable, thanks.

> +(defcustom add-log-use-pseudo-changelog t
> +=C2=A0 "If non-nil, don't create ChangeLog files for log ent= ries."
> +=C2=A0 :type :boolean)

I frequently find that what we say in the doc string is a very good
hint on how to name the variable.=C2=A0 So how about
add-log-don't-create-change-log-file instead?

Fine by me.=C2=A0 But even= with the apostrophe?

Also, this needs a :version tag.

Right. 27.1?


> +(defun add-log--pseudo-changelog-buffer-name (changelog-file-name) > +=C2=A0 "Compute suitable name for a pseudo-ChangeLog buffer.&quo= t;
> +=C2=A0 (format "*changes to %s*"
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (abbreviate-file-name
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(file-name-directory changel= og-file-name))))

Would the name of the buffer be something like "*changes to ChangeLog*= "?
That's awkward, IMO.=C2=A0 How about just "*ChangeLog*" inste= ad?

Yeah, that would be pretty awkward, hehe, but it's not what happens,= because of the file-name-directory call.

The above are minor nits, so what else is left that needs to be agreed
upon?

Nothing, afaik.=C2=A0 Stefan had said he would probably enhance this l= ater with uniquify support.

I'll do the NEWS, should the manual also mention it?

Jo=C3=A3o

=
--0000000000009845be0571820562--