From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#66041: 30.0.50; Should 'flymake-note-echo' inherit from 'compilation-info'? Date: Mon, 25 Sep 2023 09:59:22 +0100 Message-ID: References: <1f9e98be-3248-56cf-b7fd-8301666675c6@gmail.com> <1e19cc18-9942-aa51-c49e-9441e873f037@gmail.com> <83edivg3rg.fsf@gnu.org> <83zg1jemi8.fsf@gnu.org> <8d01b781-abac-e22b-39fe-8697a173ad7a@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23428"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66041@debbugs.gnu.org To: Jim Porter , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 25 10:58:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkhPw-0005up-0e for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Sep 2023 10:58:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qkhPe-0000lq-T5; Mon, 25 Sep 2023 04:57:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkhPa-0000lc-Ma for bug-gnu-emacs@gnu.org; Mon, 25 Sep 2023 04:57:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qkhPa-00023V-Ck for bug-gnu-emacs@gnu.org; Mon, 25 Sep 2023 04:57:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qkhPm-0007iZ-Ai for bug-gnu-emacs@gnu.org; Mon, 25 Sep 2023 04:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Sep 2023 08:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66041 X-GNU-PR-Package: emacs Original-Received: via spool by 66041-submit@debbugs.gnu.org id=B66041.169563222429605 (code B ref 66041); Mon, 25 Sep 2023 08:58:02 +0000 Original-Received: (at 66041) by debbugs.gnu.org; 25 Sep 2023 08:57:04 +0000 Original-Received: from localhost ([127.0.0.1]:44149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkhOq-0007hR-Fz for submit@debbugs.gnu.org; Mon, 25 Sep 2023 04:57:04 -0400 Original-Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]:60516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkhOm-0007gt-Jx for 66041@debbugs.gnu.org; Mon, 25 Sep 2023 04:57:02 -0400 Original-Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-50444e756deso5472122e87.0 for <66041@debbugs.gnu.org>; Mon, 25 Sep 2023 01:56:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695632202; x=1696237002; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gS5e7aIPAPbUcHmhBu+R9qry8srLeY0fiPugBPfkbfM=; b=gV3zM7QlR7cAzgCspgQ3GunMbQO7E+qDpjXvgwfNREx66jEQ/HYd7ps8e9rMMCqhrB yJWOVP2JqS5ZwddV4+u3MvOruLaDYbA4MOGEK1GoUcuVZgFKma1qcJJ8BTOdWLm6Q+81 3/FpF7uPF1aPiYi1L4P4/GDkpgEeW+gKCMCe8poEM11g+vzDOqWH490NOzt4u5QTIBQ1 j+wqIDGyGCKprdGNOCEZfhjntRcHbLcJsPNLRCg6YMTiUfY00dk48lgyfKuHS/4nNGKa mrg/Wd82mMfuB2/HhpoGDbXxCUjJs5SxAkDMHKB+gJQFxZzfdxrCU9g1sEY5Ugab/xeG ASFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695632202; x=1696237002; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gS5e7aIPAPbUcHmhBu+R9qry8srLeY0fiPugBPfkbfM=; b=hkecXwTxI72BhhKMv7c1Ctz3lIDUQcLEqV8QTShfrwOCbIaYsI92Vj+9T3MQ2Hmkfr 7r+M8i3RMpNhpitnTnG6xOyN6IeS5odq+7VV1285BL4SYUhlj0tN4RnC8GcaaOL52FDH vpLo3EHVDkyd8XoW0nbsKEwDSHz2aZL0LA8qyRlyNXbF5cO8urEJOXSEr7RN8lPnzd5A SkyLxgKGS0eCqmMFoCiekfdJvgOXgKYgMwyRjvKeRTnhtMSDzfWnUuppm1LRsz5i4/Zs AC+OVU1g9TN+IxI9CMx1XdrKGaHMcJMz1ekgo0oK+tYICrLxPij/67qQDr90/2JontJt XsFw== X-Gm-Message-State: AOJu0YxXTv7eSL+waUPKYeTKMYWdQeWWuPZQ9wY1RTmy8GepJ/dTeT5K kT5FFwwgptHLm4Ks3HOLZhhmjCHCSz9sEfK4GNA= X-Google-Smtp-Source: AGHT+IEY4h2omwoZFVsI7rcowyUKyEQZhrvBtEI/UwVvl/mV5X+PplpRWfaBPyodqhFBjlpaOadP2JKrAxtw2GNg8bk= X-Received: by 2002:a19:2d56:0:b0:4fe:1681:9377 with SMTP id t22-20020a192d56000000b004fe16819377mr4171257lft.44.1695632201976; Mon, 25 Sep 2023 01:56:41 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271311 Archived-At: On Sun, Sep 24, 2023 at 9:18=E2=80=AFAM Jo=C3=A3o T=C3=A1vora wrote: > Yes, I thought I had seen it sort itself out, but it didn't, I just > confirmed. > > Shouldn't be very hard, I'll look at this later this evening. As usual, this turned out not to be true. It seems that even if though the overlay dedicated to the "warning" diagnostic has higher priority than the overlay dedicated to the "note/info" diagnostic the latter's 'before-string' property, which is: #("!" 0 1 (display (left-fringe exclamation-mark compilation-info))) still trumps the former's, which is: #("!" 0 1 (display (left-fringe exclamation-mark compilation-warning))) The priorities being used here are of the (PRIMARY . SECONDARY) form. Maybe that has something to do with it, but I tried just "normal" fixnum priorities and that didn't fix it. Pinging Eli again. Eli, here's the recipe again: emacs -Q -f flymake-mode M-x erase-buffer RET y h e l l o SPC On the left fringe, we expect to see an orange exclamation mark (compilation-warning face). Instead, we see a green one (compilation-info face). Using M-x describe-text-properties, one can see two overlays, one from 1 to 6, another from 6 to 7, with priorities (nil . 42) and (nil . 41), respectively. The 'before-string' chosen for display on the fringe seems to have more to do with the overlay that appears later in the line, rather than with priorities. Another thing worth mentioning is that this bug seems to happen in both pre- and post- noverlay code by Stefan Monnier, since I can reproduce back to Emacs 28. Also worth noting that this is a bug of relatively minor importance IMO. Jo=C3=A3o