From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#73279: [PATCH] Eglot: use immediate-mode eglot--request for :completionItem/resolve Date: Mon, 16 Sep 2024 17:21:21 +0100 Message-ID: References: <87v7ywoh7m.fsf@taipei.mail-host-address-is-not-set> <86wmjbdehl.fsf@gnu.org> <8734lz7hn2.fsf@taipei.mail-host-address-is-not-set> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14426"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 73279@debbugs.gnu.org, Dmitry Gutov To: Brennan Vincent Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 16 18:22:13 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sqEUP-0003aQ-LB for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Sep 2024 18:22:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqEU3-0000YU-5p; Mon, 16 Sep 2024 12:21:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqEU1-0000Y8-JX for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2024 12:21:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqEU0-0003TK-Og for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2024 12:21:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:From:In-Reply-To:References:MIME-Version:To:Subject; bh=WGwYciY86OWeRZ5Rb5XIU7kzNHWtOgoHG/D5YAGCwpw=; b=nQq5cvfsq1dAm0zBJUOu0TPVngPXljnq3lmbmz3PwyrJgHHLEOy7FLXEXMFiGNOTlvabz0hSaoASEREC/QQ+/1ERVEugvP5qihMpvvpIdHzQE78zNLIZDGl6qThqKxfc4EVLVrOoSefY/DOHD5w6HxDAFOkqlO8sUau1z1kgO3vGjLCx+Oduf6Eh8xkqvkSCg4o18PKUWiSy3okXdFZ2bEmq7J/t58kH2XXl3mjaLsi95akpcj3AgxoijMyXsKXCD3T6JpoPfoRU8Gm2/5seYM0JmiGe4lvh+CMLUta2uBD3tgA+Nf3LYMY82ZKPJGpi32nOPvAexartnRQ77W6Z+Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sqEUE-0001MM-1X for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2024 12:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Sep 2024 16:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73279 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73279-submit@debbugs.gnu.org id=B73279.17265036785167 (code B ref 73279); Mon, 16 Sep 2024 16:22:02 +0000 Original-Received: (at 73279) by debbugs.gnu.org; 16 Sep 2024 16:21:18 +0000 Original-Received: from localhost ([127.0.0.1]:53142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqETW-0001LG-1X for submit@debbugs.gnu.org; Mon, 16 Sep 2024 12:21:18 -0400 Original-Received: from mail-oo1-f50.google.com ([209.85.161.50]:61877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqETU-0001Ko-HB for 73279@debbugs.gnu.org; Mon, 16 Sep 2024 12:21:17 -0400 Original-Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-5daa93677e1so2413344eaf.3 for <73279@debbugs.gnu.org>; Mon, 16 Sep 2024 09:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726503596; x=1727108396; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WGwYciY86OWeRZ5Rb5XIU7kzNHWtOgoHG/D5YAGCwpw=; b=a4U5LH5Flu5ikH5XvM4Ed2iVP8HUQ2wjt8/Q7IsH/0EcTq9C26XBsq9693UMau3rAP F+OZa6NYVVcwrklQEQpOjtrppPcWXCULiHdNBP7nIowp87oYFNF2zwVutYKDLWupmFDL 7kAH+sEmChos4aj+Lfgg96PSGQAgJF9b7RhxKH9VvMbvDZ0zubPjJDjt3pGNpEKzPBVr 3WawR4qTefkFs7DrFQoTzSui+NHpaMUKfanIBNGuR5bvNBXuFAmozK/+E9qtscrP2ShP lnTmK19Fr2TqeUQmib8F9i9YUpJfBccSnaHQglYC3z9mategSIxP4JlVZ2PUfi79aI3t nnxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726503596; x=1727108396; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WGwYciY86OWeRZ5Rb5XIU7kzNHWtOgoHG/D5YAGCwpw=; b=SQWx/KY4DeSJEHWQjgtN05e1+/e2cQpfmLQQza9EENcqJXgctuPCrlm8K14MYHP3u1 gUXvSWF4W2NjWHyaiEAnj4Z7ctqJ0faC41zPPgok0UjyMF//7M6x7aGYbSM0wxU/98ZK 4y4IyeRttle2DcJzTjK1f/MsQe1vOVFMBHJw5M386fGO8XQ8tkA1CPMPFl7jJgjNtqNx LJL0vPyTUJPYAq++W8nmDnUjAj7T7CfAdRanR96FEoI1degWTW3mY9xol9cHI+2QvEvn 87S6sntpoOkIiDsCnulfUtkUnuuf5AZqXLExyKQd6cGMIGoG3eVQs+sQzZ+GSzUK+vT5 hFqg== X-Forwarded-Encrypted: i=1; AJvYcCVhdfaTIX+z7LNu2bGUXDgUet5hvhoYNMnNgIWXNlPuP+ZgsMCiJ7MQsVp287zMzAgr7YkJOg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyuBQ2dPvpTLrhMTkJ13JPyskTOMnvS+ZVxF5O1R9aLzP7YXVrT bmZSB4HZmpIyJuOYMFXaUPtuTIiN+X5YhIVhTewb90rTO9XTJ8eD9AfyEQshEa1I/nGabSjiVvQ Zg7RaVcPJ0YXlqcIMPCh1uYO4ElU= X-Google-Smtp-Source: AGHT+IHv5Nejya/iwNPkxPYXPabkFnloT/7Z9U1rc8gI4a7cH4aXM41t/MtFQcMXStqtB8HYCaPHKio8u8RfZqD2wx4= X-Received: by 2002:a05:6820:16a8:b0:5e1:e1a4:add1 with SMTP id 006d021491bc7-5e20145f832mr7479316eaf.7.1726503596256; Mon, 16 Sep 2024 09:19:56 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291898 Archived-At: On Mon, Sep 16, 2024 at 4:50=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > On Mon, Sep 16, 2024 at 4:40=E2=80=AFPM Jo=C3=A3o T=C3=A1vora wrote: > > > > On Mon, Sep 16, 2024 at 4:17=E2=80=AFPM Brennan Vincent wrote: > > > > > As for the regression: yes, it's a regression from 29.4, and in fact = I > > > have bisected to the commit that regressed it: > > > a8c1559a663d9bc21776e33303251e244f86f0d7 > > > > Oh alright, that clears it up. It was an oversight indeed, so I think > > your patch is TRT. I'll install it in emacs-30. > > Actually, not so fast. The code before that allegedly broken commit > _also_ sent outstanding changes to the server before resolving > (via the advice that was then removed). > > So I must be missing something, and must investigate more > closely. Brennan, can you provide an excerpt of the Eglot event log (M-x eglot-events-buffer) for your MRE recipe before and after a8c1559a663d9bc21776e33303251e244f86f0d7? It should highlight what has changed in the client-server communication, if anything. Jo=C3=A3o