From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Indentation of def* Date: Wed, 20 Oct 2021 10:32:51 +0100 Message-ID: References: <878ryw1ptl.fsf@gnus.org> <87czo2lq0d.fsf@gnus.org> <87v91s876d.fsf@gnus.org> <87ee8gnlar.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7227"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Richard Stallman , emacs-devel To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 20 11:34:31 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1md7zT-0001kK-KL for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Oct 2021 11:34:31 +0200 Original-Received: from localhost ([::1]:36280 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1md7zR-0002lz-Jx for ged-emacs-devel@m.gmane-mx.org; Wed, 20 Oct 2021 05:34:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1md7y6-00024q-DE for emacs-devel@gnu.org; Wed, 20 Oct 2021 05:33:06 -0400 Original-Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]:37571) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1md7y4-000464-PK; Wed, 20 Oct 2021 05:33:06 -0400 Original-Received: by mail-pl1-x62b.google.com with SMTP id n11so15723076plf.4; Wed, 20 Oct 2021 02:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=My8Ivoq3QA21Sw1x6Hx8AzQeefiIdpii19DXSfk3+Rk=; b=enIpEC1dNLvIZYvHEIe6wuk42havccH0apergTEYc9DjN7lrmr4snFx5Y5sXy1RLUw w90C0TE9DvHuqHL+uZVlhz6S/sgZxeZNZyHY6nRuRua1HIG6hRwfGNVDYlAYLzrTCmxS 3BomGradXCHOuCWLYxRyWO1xAqKKNDuqGQkoGQiRMZoUkvOTNUA/wTg3nFXcevIZFviG 5blIFL8cz8bFZ/BYcHe0+/5r9zUVF7Tc7pKlTPCOMcfWt8C4Lj0O2ot8W7Bz+ywX7icx Uih9wkvb5oEjUzSE3zwGQ6BipTkWAxmHq3AqNKrBt8WJiMzZ6KzYr0bj9Jio3BddrZCt rk/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=My8Ivoq3QA21Sw1x6Hx8AzQeefiIdpii19DXSfk3+Rk=; b=sD7LroKVSEN1npx9ZtmzEozktpXxWeC+qZmgErWjvmnJFuo+Hs1jKdEOPMjCfsmKlQ 8RTB3Xx+mBSnOAgpkAxyc9T6Qp0jIDibNx/zf/O5xutfYHg52zHY8Z+jZYcidcbsybWq BfjZi86SbVCXnn9Afg8HG4N6u7h7xBZKJpq1a0E2+VaE9+293jCc4yM802V7IseTiJnO +yYzGMazK5CA7NtsD6FZR+PS5XxFtNu7IF18OYAWSiYvWF7nwKu7nVz4MWoXLWWsbEh1 G6pdM6fPm0gnIsTXgX4UJYE50oxVJdLnGFGt9wef/BmfVEBb5EZoTS6vlpaHWaJVOMWO i+4Q== X-Gm-Message-State: AOAM533dfZlJiYMS5o61zPByoRRb/i98B6Q1Xb5DSg4PlcRIibX0i+o8 bQeyTQdYv+oYtHNJoGE1K0+IiF3PK+qwVlNae6Vx/Yt4BWU= X-Google-Smtp-Source: ABdhPJyjR0Km7RfHbzvaHjG/mxtpiLNOh1ggiD4+e04Mv4vcVWS1hG5/BnZ+4AcUJOYIILexs2l2Xq0xg3itB0a1B6M= X-Received: by 2002:a17:902:728b:b0:13f:c086:bdfe with SMTP id d11-20020a170902728b00b0013fc086bdfemr15492427pll.6.1634722383090; Wed, 20 Oct 2021 02:33:03 -0700 (PDT) In-Reply-To: <87ee8gnlar.fsf@gnus.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::62b; envelope-from=joaotavora@gmail.com; helo=mail-pl1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277433 Archived-At: On Wed, Oct 20, 2021 at 9:38 AM Lars Ingebrigtsen wrote: > > Jo=C3=A3o T=C3=A1vora writes: > > > Right. And your example is a _function_. Why don't you _at least_ keep > > the heuristic for macros? Isn't that a worthy compromise, a "no-worse" > > situation? It would fix your default-boundp example and, if Richard's > > example deffoober is a macro (I'd say there's a good chance it is, > > statistically speaking) then the calls to that macro would also be > > indented correctly. > > What am I missing? > We've been over this. There's both functions and macros that want to be > indented like a defun, and there both functions a macros that don't want > to be, and sometimes they're called something that starts with def* and > sometimes they don't. Right, I know. I was referring to the example you gave. I've also asked you for the listings that you've supposedly collected on those things so we can make a better informed decision. But, regardless, is it not so that there are various grades of change here? a - do nothing b - keep heuristic but only for macros, delete for everything else. c - delete heuristic entirely >From your perspective, isn't 'b' better than 'a'? Yes I get that, for you, 'c' > 'b' and that's why you did it. But I think there are at least some situations where 'b' is preferrable. So I'd like to have 'b' please. A compromise. We could add those debug specs to the def _functions_ like your example. Whoever these functions are and however many there are. Again, it'd be great to have the data. Some data. Thanks, Jo=C3=A3o