From: "João Távora" <joaotavora@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Daniel Colascione <dancol@dancol.org>,
Yuan Fu <casouri@gmail.com>,
emacs-devel@gnu.org
Subject: Re: treesit indentation "blinking"
Date: Sat, 25 Mar 2023 09:05:26 +0000 [thread overview]
Message-ID: <CALDnm52Ub6MXf=OgLYg2jbBazVFf098tTKTDvkkVcMBnHzAsdg@mail.gmail.com> (raw)
In-Reply-To: <f7ec55fb-86de-6d90-c3c2-a3f4671cd58e@yandex.ru>
On Thu, Mar 23, 2023 at 9:24 PM Dmitry Gutov <dgutov@yandex.ru> wrote:
>
> On 23/03/2023 23:10, Daniel Colascione wrote:
> > Editing can cause all sorts of transient nonsense in the AST, and it's
> > impossible to predict in a general manner what this nonsense might be.
> > The wrong kind of bracket can cause the entire rest of the file to be
> > parsed as nonsense. This or that error recovery rule isn't going to
> > solve the problem: such a strategy is a fragile whack a mole. There
> > needs to be some general solution to prevent indentation blinking. This
> > blinking makes TS modules unusable for me.
>
> It seems to me it will only be feasible to support a number of
> "incomplete" syntax constructs. Maybe it will constitute a majority of them.
I don't think this problem has anything to do with tree-sitter. It
would happen just as well in regular c++-mode if electric-indent-mode
were on by default there (but it isn't).
So it's just the fact that electric-indent-mode is on by default
_and_ c-ts-mode.el does this:
(setq-local electric-indent-chars (append "{}():;,#" electric-indent-chars))
so people are getting what the mode author (and Emacs defaults) ask for:
electric indentation doing its thing.
> Have you tried using electric-pair-mode, though? I'd hate to make it our
> strong recommendation for all ts modes, but it does reduce the odds of
> incomplete code a lot.
Maybe you'd hate it, but it would at least be consistent with the
setting for electric-indent-mode, which is much more jarring.
See also bug#62412 which is basically the same problem with a recipe.
João
next prev parent reply other threads:[~2023-03-25 9:05 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 20:49 treesit indentation "blinking" Daniel Colascione
2023-03-23 0:00 ` Yuan Fu
2023-03-23 0:07 ` Daniel Colascione
2023-03-23 1:02 ` Yuan Fu
2023-03-23 4:51 ` Daniel Colascione
2023-03-23 20:04 ` Yuan Fu
2023-03-23 21:10 ` Daniel Colascione
2023-03-23 21:24 ` Dmitry Gutov
2023-03-25 9:05 ` João Távora [this message]
2023-03-25 12:42 ` Dmitry Gutov
2023-03-25 14:42 ` Eli Zaretskii
2023-03-25 16:18 ` João Távora
2023-03-28 22:11 ` João Távora
2023-03-28 23:57 ` Daniel Colascione
2023-03-29 2:26 ` Eli Zaretskii
2023-03-29 22:30 ` João Távora
2023-03-29 22:37 ` Herman, Géza
2023-03-29 23:25 ` João Távora
2023-03-30 7:47 ` Herman, Géza
2023-03-29 22:56 ` Lynn Winebarger
2023-03-30 7:43 ` Eli Zaretskii
2023-03-30 8:58 ` Dmitry Gutov
2023-03-30 9:15 ` João Távora
2023-03-30 9:06 ` João Távora
2023-03-30 9:20 ` Dmitry Gutov
2023-03-30 9:28 ` João Távora
2023-03-30 9:36 ` Dmitry Gutov
2023-03-30 10:00 ` João Távora
2023-03-30 16:29 ` Dmitry Gutov
2023-03-30 17:14 ` João Távora
2023-03-30 10:07 ` Eli Zaretskii
2023-03-30 10:26 ` Herman, Géza
2023-03-30 13:39 ` Eli Zaretskii
2023-03-30 15:03 ` Herman, Géza
2023-03-30 14:58 ` Eli Zaretskii
2023-04-01 19:39 ` Yuan Fu
2023-04-02 1:49 ` Yuan Fu
2023-04-02 5:31 ` Eli Zaretskii
2023-04-02 14:26 ` Alan Mackenzie
2023-04-02 15:48 ` João Távora
2023-04-02 17:04 ` Alan Mackenzie
2023-04-02 17:23 ` João Távora
2023-04-02 17:51 ` Eli Zaretskii
2023-04-02 18:04 ` João Távora
2023-04-02 18:14 ` Eli Zaretskii
2023-04-02 21:38 ` João Távora
2023-04-02 21:21 ` Dmitry Gutov
2023-04-02 21:40 ` João Távora
2023-04-03 9:59 ` Alan Mackenzie
2023-04-03 10:28 ` João Távora
2023-04-03 12:07 ` Dmitry Gutov
2023-04-03 12:56 ` Alan Mackenzie
2023-04-03 20:58 ` Dmitry Gutov
2023-04-03 21:59 ` Daniel Colascione
2023-04-03 22:10 ` Dmitry Gutov
2023-04-04 8:31 ` João Távora
2023-04-07 14:20 ` Daniel Martín
2023-04-08 1:32 ` Dmitry Gutov
2023-04-08 2:42 ` Yuan Fu
2023-04-08 18:59 ` Daniel Martín
2023-04-03 21:47 ` parser error recovery algorithm vs " Stephen Leake
2023-04-04 12:01 ` John Yates
2023-04-04 13:40 ` Dmitry Gutov
2023-04-04 16:00 ` Stephen Leake
2023-04-04 13:50 ` Stephen Leake
2023-04-04 14:05 ` Dmitry Gutov
2023-03-30 11:05 ` João Távora
2023-03-30 14:00 ` Eli Zaretskii
2023-03-30 14:43 ` João Távora
2023-03-30 14:52 ` Eli Zaretskii
2023-03-30 15:42 ` João Távora
2023-03-25 16:14 ` João Távora
2023-03-24 11:39 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm52Ub6MXf=OgLYg2jbBazVFf098tTKTDvkkVcMBnHzAsdg@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=casouri@gmail.com \
--cc=dancol@dancol.org \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.