From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#34077: bug#34116: 27.0.50; minibuffer-force-complete-and-exit mostly broken Date: Wed, 23 Jan 2019 16:36:07 +0000 Message-ID: References: <87tvi5pq35.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="76022"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34116@debbugs.gnu.org, 34116-done@debbugs.gnu.org, 34077-done@debbugs.gnu.org, bug#34077 <34077@debbugs.gnu.org> To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 23 17:37:37 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmLWy-000Jh5-PD for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Jan 2019 17:37:36 +0100 Original-Received: from localhost ([127.0.0.1]:37947 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmLWw-0006Ds-Jz for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 Jan 2019 11:37:34 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gmLWm-0006DJ-7l for bug-gnu-emacs@gnu.org; Wed, 23 Jan 2019 11:37:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gmLWg-000683-FM for bug-gnu-emacs@gnu.org; Wed, 23 Jan 2019 11:37:22 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43715) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gmLWR-0005xS-CY for bug-gnu-emacs@gnu.org; Wed, 23 Jan 2019 11:37:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gmLWR-0004wM-5p for bug-gnu-emacs@gnu.org; Wed, 23 Jan 2019 11:37:03 -0500 Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Jan 2019 16:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 34077 X-GNU-PR-Package: emacs Mail-Followup-To: 34077@debbugs.gnu.org, joaotavora@gmail.com, joaotavora@gmail.com Original-Received: via spool by 34077-done@debbugs.gnu.org id=D34077.154826138918916 (code D ref 34077); Wed, 23 Jan 2019 16:37:02 +0000 Original-Received: (at 34077-done) by debbugs.gnu.org; 23 Jan 2019 16:36:29 +0000 Original-Received: from localhost ([127.0.0.1]:42992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gmLVs-0004uw-N7 for submit@debbugs.gnu.org; Wed, 23 Jan 2019 11:36:29 -0500 Original-Received: from mail-qt1-f182.google.com ([209.85.160.182]:33392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gmLVo-0004uJ-PU; Wed, 23 Jan 2019 11:36:25 -0500 Original-Received: by mail-qt1-f182.google.com with SMTP id l11so3096323qtp.0; Wed, 23 Jan 2019 08:36:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=0m4/Retqoqrbx+KIjNQy3/qp1kCArgII3M356X6l79M=; b=T3riDgv3hHuvneMEf915AdZR0GDPNxbizsGQEHYCT1VartGvH+JA/45NZPIob/qK8n 247FiFgV0/wuuJnED6/41uZiabdeOb9EYfhsBIzJImcZmwHjPA/P4w4+/WLQHs63l9wX sreh596dtSE6yQ9fPGaKKE2dz6XJh+w1akdemIWhxZ9aUdNivZ62ITvuAcwfp6LbIbTl 67ufP5FhKS93ReJmOTPJdExuAuVBkKurIxpKL3n2dMU0tuh7mHea0PE+sgdWQ9HCPWv7 Gyw4AdeLmVajpDdSLQLKZPogiacpysRqZ4Hg8Ah/RfIrRQSTtjgRm8VIH8FX+qkol/xt UCeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=0m4/Retqoqrbx+KIjNQy3/qp1kCArgII3M356X6l79M=; b=DeYCdSrjl//uRe1xe9/t/jgP2Z0jiYukIKEdMAmxu7QsOO1Gzoa2XPehl/ZTDxjCEJ KhDo09XkdQW5OOemV7GOBqP25hp9zPsdKy4f8Nw6+/WyD+LeAyFMwcU+u30gUh6zoVLL ngTCOEH7LSzJjCMemP2zpOYmHCARdARX+/AmmFnsl4SWu6wjV7TAC+TQIMPD/YAsAczJ M23qwOAQkWPoTr5UP3OAkx+5QIenW320Vv2vflZc0takwOSCjQw/I4pD/n4nViv3aRsV pJJ21fJwq1mj8qOQKBYooTuTk+9Xr90DiUpmR6uUzyf5voHxDMQz+Qkkth98oJZGZR53 RGBg== X-Gm-Message-State: AJcUukfuN0Tf+t8WZ2MbAGZ75yo3oIfGBSkVB7T6KD5bfCkM1IreMNgx 6FNOZZI6pO77EsF6smWLFv438K6OeoZkkp4axsQ= X-Google-Smtp-Source: ALg8bN6kZQn0Fa+Ks/TnGQvKKMACeZXLh6jyBqGrjif2c67CdbLHJgm+g0BpnPah6kxkfROh5fX3p0foKlaCIgGlBas= X-Received: by 2002:ac8:3790:: with SMTP id d16mr3085670qtc.20.1548261379042; Wed, 23 Jan 2019 08:36:19 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154707 Archived-At: On Wed, Jan 23, 2019 at 4:09 PM Stefan Monnier w= rote: > > > But what about this which solves both problems bug#34077 > > and bug#34116? > > LGTM, > Stefan Great! commit b9add0a5a7eddcf80a189c478b39a5cb7a12befe (HEAD -> master, origin/master, origin/HEAD) Author: Jo=C3=A3o T=C3=A1vora Date: Wed Jan 23 16:30:41 2019 +0000 Force completion in icomplete with C-M-i, but don't cycle (bug#34077) Cycling after forcing a completion with C-M-i in icomplete can be confusing, as it leaves rotated prospects in the minibuffer. In C-x C-f, for example it is very difficult to understand if the prospects refer to subdirectories of the directory being completed to, which happens naturally when the completion is unique; or if they are a cycled version of prospects that match the new completion pattern, in case the completion happens to still match other items. To resolve this confusion, never cycle with C-M-i in icomplete: non-ambiguous cycling can be achieved with C-. and C-, The former behaviour can still be restored with: (define-key icomplete-minibuffer-map (kbd "C-M-i") 'minibuffer-force-complete) * lisp/icomplete.el (icomplete-force-complete): New command. (icomplete-minibuffer-map): Bind C-M-i to icomplete-force-complete. commit 210e592e55ade154c8d58bd467711fb69368f6cb Author: Jo=C3=A3o T=C3=A1vora Date: Wed Jan 23 16:17:03 2019 +0000 Avoid cycling in minibuffer-force-complete-and-exit (bug#34116) * lisp/minibuffer.el (minibuffer-force-complete-and-exit): Check completion-cycling before minibuffer-force-complete.