From: "João Távora" <joaotavora@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 34116@debbugs.gnu.org, 34116-done@debbugs.gnu.org,
34077-done@debbugs.gnu.org, bug#34077 <34077@debbugs.gnu.org>
Subject: bug#34077: bug#34116: 27.0.50; minibuffer-force-complete-and-exit mostly broken
Date: Wed, 23 Jan 2019 16:36:07 +0000 [thread overview]
Message-ID: <CALDnm52Pmk4oe4Mvc8pvVJF-BsQCGVYpz3wBCmro+PPO_FC-bg@mail.gmail.com> (raw)
In-Reply-To: <jwvimyf4apv.fsf-monnier+emacsbugs@gnu.org>
On Wed, Jan 23, 2019 at 4:09 PM Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
> > But what about this which solves both problems bug#34077
> > and bug#34116?
>
> LGTM,
> Stefan
Great!
commit b9add0a5a7eddcf80a189c478b39a5cb7a12befe (HEAD -> master,
origin/master, origin/HEAD)
Author: João Távora
Date: Wed Jan 23 16:30:41 2019 +0000
Force completion in icomplete with C-M-i, but don't cycle
(bug#34077)
Cycling after forcing a completion with C-M-i in icomplete can be
confusing, as it leaves rotated prospects in the minibuffer. In
C-x
C-f, for example it is very difficult to understand if the
prospects
refer to subdirectories of the directory being completed to, which
happens naturally when the completion is unique; or if they are a
cycled version of prospects that match the new completion pattern,
in
case the completion happens to still match other items.
To resolve this confusion, never cycle with C-M-i in icomplete:
non-ambiguous cycling can be achieved with C-. and C-,
The former behaviour can still be restored with:
(define-key icomplete-minibuffer-map (kbd "C-M-i")
'minibuffer-force-complete)
* lisp/icomplete.el (icomplete-force-complete): New command.
(icomplete-minibuffer-map): Bind C-M-i to
icomplete-force-complete.
commit 210e592e55ade154c8d58bd467711fb69368f6cb
Author: João Távora
Date: Wed Jan 23 16:17:03 2019 +0000
Avoid cycling in minibuffer-force-complete-and-exit (bug#34116)
* lisp/minibuffer.el (minibuffer-force-complete-and-exit): Check
completion-cycling before minibuffer-force-complete.
prev parent reply other threads:[~2019-01-23 16:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 13:56 bug#34116: 27.0.50; minibuffer-force-complete-and-exit mostly broken João Távora
2019-01-17 14:57 ` Stefan Monnier
2019-01-17 15:03 ` João Távora
2019-01-18 12:13 ` João Távora
2019-01-18 13:09 ` Stefan Monnier
2019-01-18 13:28 ` João Távora
2019-01-18 18:00 ` Stefan Monnier
2019-01-18 22:18 ` João Távora
2019-01-19 2:31 ` Stefan Monnier
2019-01-23 15:49 ` João Távora
2019-01-23 16:09 ` Stefan Monnier
2019-01-23 16:36 ` João Távora [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm52Pmk4oe4Mvc8pvVJF-BsQCGVYpz3wBCmro+PPO_FC-bg@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=34077-done@debbugs.gnu.org \
--cc=34077@debbugs.gnu.org \
--cc=34116-done@debbugs.gnu.org \
--cc=34116@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.