From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: eldoc-docstring-format-sym-doc Date: Sat, 25 Jul 2020 10:26:31 +0100 Message-ID: References: <86lfj9rl57.fsf@m12000.fhaun.de> <87sgdgsngn.fsf@gnu.org> <835zacdsqj.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000008efd805ab40b02f" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34901"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel , fh@fhaun.de, Tassilo Horn To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 25 11:27:19 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jzGSc-0008yx-M0 for ged-emacs-devel@m.gmane-mx.org; Sat, 25 Jul 2020 11:27:18 +0200 Original-Received: from localhost ([::1]:39346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzGSb-0005kR-MQ for ged-emacs-devel@m.gmane-mx.org; Sat, 25 Jul 2020 05:27:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jzGS8-0005LL-6k for emacs-devel@gnu.org; Sat, 25 Jul 2020 05:26:48 -0400 Original-Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]:46389) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jzGS6-0003ag-HZ; Sat, 25 Jul 2020 05:26:47 -0400 Original-Received: by mail-wr1-x42a.google.com with SMTP id r12so10273484wrj.13; Sat, 25 Jul 2020 02:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NtIr63QYmdu6veFC4lLeYkA7FPqmFyH+TyaGB70YCOI=; b=DOQ0wVb6uXuhEx7668tpPmhlNDczyvNyNK+yL9FXC4oC1rwvaA4ashh/5f5BljlBB+ 20iVNGFMVwCLFFo+1efqWf/eILffPXvOlSMZb3mlGjlfcxexpwayNnwG3unWtuWuWCz6 2mFCuq2LHLtNUy/hEMKumxhqpCAS38m9jGth7E50NvdqeQDr/uX6giNPVTjMzF7oufXy kHe/W6UxjNMJZOA+EfQEkRw9G7kY91ugiP9l1auOxYesTCxWU1fBDh47SElrlXJTHehO 35ca/dCST/35S5TGJ669l8fIPcRMv9nEkdY9efBcxGfUGef4hk9kK904TaCt7QsPepFS sHUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NtIr63QYmdu6veFC4lLeYkA7FPqmFyH+TyaGB70YCOI=; b=k8n29bItH/YkKrRv0Mb/fpymffFUs1LUN0NJLVgbtmTgu0UVyqVTTrN4HGWWd5Bolj scdQ14Q/7z8LrdL+ww53+tA6hSrt/s5Cp744BTkkzMWrVMiLCLjo27bmlJ8DR0FbuCNV rxOOBCaSs6Vgi8Yv3TNaWAsA7bZp7K7CGzcia/rUtAnquckSGGxe9ILmRWHh7wUhKxzW Cu6SBF5DufAo1PFopLjMAU1OlF9uiTwhKDjishVYqa8Wnjg9/U7LH2++hwzy+0dy7eLM 7/OKyZ89TQj2few3C11hky544HOFzb3sKgI0a+iDyL5kLXLiRotMKThDgmKUxDvYAJpI E7Eg== X-Gm-Message-State: AOAM533MK4WuYKDEmjATfBSITZaAxdJ6w86TKN4ObEpKiuVoC+GWWd0P 55YyvPASgZUkW7n3dHfvWbwdQvZ6+HxgimxLWs1lwJgg X-Google-Smtp-Source: ABdhPJypyEAsteicig+3JsdhKMJuwO8O1bMZG6aScADd8WVLvoC/K0PUixkcpeR2fn1dV0euyOamCoh2O1tuasyVHIo= X-Received: by 2002:adf:8405:: with SMTP id 5mr6425363wrf.393.1595669203183; Sat, 25 Jul 2020 02:26:43 -0700 (PDT) In-Reply-To: <835zacdsqj.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=joaotavora@gmail.com; helo=mail-wr1-x42a.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253208 Archived-At: --00000000000008efd805ab40b02f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Jul 25, 2020 at 7:16 AM Eli Zaretskii wrote: > > From: Tassilo Horn > > Date: Fri, 24 Jul 2020 21:49:12 +0200 > > Cc: emacs-devel@gnu.org > > > > > when was the function "eldoc-docstring-format-sym-doc" removed? I can= t > > > find nothing in the logs. > > > > In this commit: > > > > commit 1203626f472b0d99d2746f5999711137c0c1fd0c > > Author: Jo=C3=A3o T=C3=A1vora > > Date: Sat Jun 6 14:04:48 2020 +0100 > > > > > Elpy is using it. > > > > It seems like it was removed including allmost all calls except for in > > semantic/grammar.el: > > > > * lisp/cedet/semantic/grammar.el > (semantic--docstring-format-sym-doc): > > New function. > > (semantic-grammar-eldoc-get-macro-docstring): Adjust. > > > > Basically semantic--docstring-format-sym-doc is the old > > eldoc-docstring-format-sym-doc. But I guess the plan is to remove that > > eventually, too. Eldoc got a overhaul recently... > > Jo=C3=A3o, based on this report, do we need some backward-compatibility > shim to help 3rd party packages which use this removed function? > >From memory, maybe just bringing back the function as-is should do the trick, since eldoc-docstring-format-sym-doc is just a string formatting function, I seem to recall. I hope this can wait for monday, as I don't have much time for emacs devel this weekend. Ideally though, elpy would rely on the new API, if possible. Is Elpy using the new eldoc.el because it's being started with Emacs 28 or because it's fetching the package from GNU ELPA? Jo=C3=A3o --00000000000008efd805ab40b02f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Jul 25, 2020 at 7:16 AM Eli Zaret= skii <eliz@gnu.org> wrote:
> From: Tassilo Horn <tsdh@gnu.org>
> Date: Fri, 24 Jul 2020 21:49:12 +0200
> Cc: emacs-dev= el@gnu.org
>
> > when was the function "eldoc-docstring-format-sym-doc" = removed? I cant
> > find nothing in the logs.
>
> In this commit:
>
>=C2=A0 =C2=A0commit 1203626f472b0d99d2746f5999711137c0c1fd0c
>=C2=A0 =C2=A0Author: Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com>
>=C2=A0 =C2=A0Date:=C2=A0 =C2=A0Sat Jun 6 14:04:48 2020 +0100
>
> > Elpy is using it.
>
> It seems like it was removed including allmost all calls except for in=
> semantic/grammar.el:
>
>=C2=A0 =C2=A0 =C2=A0* lisp/cedet/semantic/grammar.el (semantic--docstri= ng-format-sym-doc):
>=C2=A0 =C2=A0 =C2=A0New function.
>=C2=A0 =C2=A0 =C2=A0(semantic-grammar-eldoc-get-macro-docstring): Adjus= t.
>
> Basically semantic--docstring-format-sym-doc is the old
> eldoc-docstring-format-sym-doc.=C2=A0 But I guess the plan is to remov= e that
> eventually, too.=C2=A0 Eldoc got a overhaul recently...

Jo=C3=A3o, based on this report, do we need some backward-compatibility
shim to help 3rd party packages which use this removed function?

From memory, maybe=C2=A0 just bringi= ng back the function as-is should
do the trick, since eldoc-docst= ring-format-sym-doc is just a
string formatting function, I = seem to recall.

I hope this can wait for monday, a= s I don't have much time
for emacs devel this weekend.

Ideally though, elpy would rely on the new API, if p= ossible.
Is Elpy using the new eldoc.el because it's being st= arted
with Emacs 28 or because it's fetching the package from=
GNU ELPA?

Jo=C3=A3o
=

--00000000000008efd805ab40b02f--