From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#56407: 29.0.50; desktop.el shouldn't be saving/restoring eglot--managed-mode, which is not for interactive use Date: Wed, 6 Jul 2022 14:19:43 +0100 Message-ID: References: <87y1x7pd53.fsf@gmail.com> <83v8sb73ga.fsf@gnu.org> <87tu7vpc8y.fsf@gmail.com> <83tu7v6kjv.fsf@gnu.org> <83r12y7b0y.fsf@gnu.org> <83let676fe.fsf@gnu.org> <83h73u75bi.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000076be7105e322ced5" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6907"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56407@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 06 15:19:24 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o94w7-0001gN-NM for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 15:19:23 +0200 Original-Received: from localhost ([::1]:38684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o94w6-0003yO-G5 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Jul 2022 09:19:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52074) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o94vm-0003y1-HO for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 09:19:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58957) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o94vl-0004h6-LZ for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 09:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o94vl-0003tz-IJ for bug-gnu-emacs@gnu.org; Wed, 06 Jul 2022 09:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Jul 2022 13:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56407 X-GNU-PR-Package: emacs Original-Received: via spool by 56407-submit@debbugs.gnu.org id=B56407.165711352314970 (code B ref 56407); Wed, 06 Jul 2022 13:19:01 +0000 Original-Received: (at 56407) by debbugs.gnu.org; 6 Jul 2022 13:18:43 +0000 Original-Received: from localhost ([127.0.0.1]:52854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o94vS-0003tO-Mi for submit@debbugs.gnu.org; Wed, 06 Jul 2022 09:18:43 -0400 Original-Received: from mail-ot1-f43.google.com ([209.85.210.43]:38758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o94vR-0003tA-Ex for 56407@debbugs.gnu.org; Wed, 06 Jul 2022 09:18:41 -0400 Original-Received: by mail-ot1-f43.google.com with SMTP id cb12-20020a056830618c00b00616b871cef3so11806793otb.5 for <56407@debbugs.gnu.org>; Wed, 06 Jul 2022 06:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OvzR0YzTtFcd6IITISp6cc4u1wz4WXuZbpS8sobOaCc=; b=RWaJMLFQ5bnFsVrcX7y/H/MwTfyHSrO7BP/Yl+7ZMAwBOPCI0m0IwDEf0pxwaqKYD4 /ztiHDRO9njeg/XiBdyAyXh9vVJsbfdCa+NgfMhw8FJNjmxamFPp3U/01tCj5va8PKm2 eO7Ffv+5UbUAGITOaD2v93YkDmSwDLN9H/fyNGktAn4bcRwJLk6OWmKeuF6QI0pHUOAX b+Hl1m9b1ECHVpjvdWrrGSHz5sns5gf/mz2l9Sqnf7disjSRzSDnSN+wZFqePcy4vdex dGdJ5Mos6EwumJeErbcXbByUqdjP5oOlyHYr6WNNDeLZMWBSsahWt44GO0FMH0zuryfQ bBZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OvzR0YzTtFcd6IITISp6cc4u1wz4WXuZbpS8sobOaCc=; b=eqZQX78XoSaWVToLjB15jfH0EcuF/b7TZUJFtxnJVlmF8CEsxCSVAv3isXinlF3W3b HIzo9gg1K3btmzG5k2cc5aeDDuF226cjPKyl0fB0g919UkIwvEDpSCqTq13KcOd7cigF 7itkP64DVw3TwtriNx0P6tSbvc2KFIhd3xFnyGdyYuitrFuRFmWW+sTEOqkxXBZWbUGJ ZdYUddOOopXEGgZ/ow/O8EEJ/POpZg7Mvse7qGZUaJ4ZT6gL9lqbg7wFAZSmUTSy4gmX PlbHh73Ujt62BTl/xBdfY9Y4TuVlFbD0o6XFGXcFsGmIy5N1wa53pA/zAOzUSKAh2k50 ei5g== X-Gm-Message-State: AJIora9ts1OxMabNhYGZW9vbIE9/wb34RQ/nxRSY1T1AtFn7LeOnfydR anggfaP9X7r/4DBDw7Iaxdwatu9mbjs/KdFrPRM= X-Google-Smtp-Source: AGRyM1uq7U8qY/+ivMzwNH4XWEMXvTenJF9DJ6ZAXZyXNZ4cJfe7baqiJ6hx2BiALRWXzqt1OGRBbnMv/2j7rf28GAw= X-Received: by 2002:a9d:4e91:0:b0:616:8273:76e6 with SMTP id v17-20020a9d4e91000000b00616827376e6mr17291278otk.340.1657113515833; Wed, 06 Jul 2022 06:18:35 -0700 (PDT) In-Reply-To: <83h73u75bi.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236239 Archived-At: --00000000000076be7105e322ced5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jul 6, 2022 at 2:12 PM Eli Zaretskii wrote: > > From: Jo=C3=A3o T=C3=A1vora > > Date: Wed, 6 Jul 2022 13:59:51 +0100 > > Cc: 56407@debbugs.gnu.org > > > > That's okay: it's desktop.el's job to know about some implementation > > details. Just look at how much it knows about what the various modes > > and variables do in Emacs. > > > > Wait, you're saying it's "okay" to have to do a commit to Emacs's repo > > everytime someone makes a third-party package that has a minor mode > > that needs special handling? Or everytime someone changes the name > > or shape of a minor mode? > > eglot is not a third-party package. We intended to add it to core, I > think? > Indeed we do. But it's not yet, because I've been so very busy. But if what I suggest isn't to your liking, you can always tell users > to customize desktop-minor-mode-table by themselves. Or do what you > didn't want to do: cause desktop.el to be autoloaded by eglot. > Yes, those are alternatives. But not as good. > > But we do have that mechanism. It's called symbol properties and it's a > nice > > feature of lisp. So let's use it, please. > > If you insist. But then don't come back crying when this is broken by > some change in desktop.el that the "loosely coupled packages" didn't > pick up. > Thanks. I can't vouch for my future emotions, but I also can't see how this mechanism, which I've used and seen used so often, could fail in such ways. I'll prepare a patch. Jo=C3=A3o --00000000000076be7105e322ced5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Jul 6, 2022 at 2:12 PM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> > Date: Wed, 6 Jul 2022 13:59:51 +0100
> Cc: 56407@d= ebbugs.gnu.org
>
>=C2=A0 That's okay: it's desktop.el's job to know about som= e implementation
>=C2=A0 details.=C2=A0 Just look at how much it knows about what the var= ious modes
>=C2=A0 and variables do in Emacs.
>
> Wait, you're saying it's "okay" to have to do a comm= it to Emacs's repo
> everytime someone makes a third-party package that has a minor mode > that needs special handling?=C2=A0 Or everytime someone changes the na= me
> or shape of a minor mode?

eglot is not a third-party package.=C2=A0 We intended to add it to core, I<= br> think?

Indeed we do.=C2=A0 But it's= not yet, because I've been so very busy.

=C2=A0But = if what I suggest isn't to your liking, you can always tell users
to customize desktop-minor-mode-table by themselves.=C2=A0 Or do what you didn't want to do: cause desktop.el to be autoloaded by eglot.

Yes, those are alternatives. But not as good.
=C2=A0
> But we do have that mechanism. It's called symbol properties and i= t's a nice
> feature of lisp. So let's use it, please.

If you insist.=C2=A0 But then don't come back crying when this is broke= n by
some change in desktop.el that the "loosely coupled packages" did= n't
pick up.

Thanks. I can't vouch for = my future emotions, but I also can't see how
this mechanism, = which I've used and seen used so often, could fail
in such wa= ys.

I'll prepare a patch.
=C2=A0
Jo=C3=A3o
--00000000000076be7105e322ced5--