From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Adding refactoring capabilities to Emacs Date: Thu, 31 Aug 2023 09:02:16 +0100 Message-ID: References: <83fs4f36wi.fsf@gnu.org> <61621120-8f6d-5884-e7c8-33581b8e0ca4@gutov.dev> <87edjkuv0s.fsf@gmail.com> <0bba73a6-f9a5-91c8-ef56-a58951706490@gutov.dev> <838r9rg5x3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000004571740604337722" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25414"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , Yuri Khan , emacs-devel , "Philip K." To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 31 10:03:28 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbceF-0006ON-Sc for ged-emacs-devel@m.gmane-mx.org; Thu, 31 Aug 2023 10:03:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbcdS-000060-7B; Thu, 31 Aug 2023 04:02:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbcdR-00005m-8k for emacs-devel@gnu.org; Thu, 31 Aug 2023 04:02:37 -0400 Original-Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbcdO-0003DP-DV; Thu, 31 Aug 2023 04:02:36 -0400 Original-Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2bcb89b476bso10146251fa.1; Thu, 31 Aug 2023 01:02:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693468951; x=1694073751; darn=gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OUnqsw/OkwJVUqTBdMvyaNhziaip8u5tYQz54/giWCc=; b=b9vxkVtbFoa+npQQadORriM0g3+qvPb4LotGiltxtp3ncgVyeiy/51amC/Cto6P54J kRDgt8Xpv1msgm6bT7kdhNwMgcUx3le0TlOhgY6S4z5+XAou3woXd5vGK5E4kheRrPiG vh4YH/YCMoBYXLZ/C4w2etzoXN7OsGS/EsPZK2sQYdUqyz2MhTnN7vpLYO/V+6K2Yt5n QdIyZUReWU+Bxvryf/QjADooGAchEVIxYHjXKi9Sz86lSI3+CcrLDPirB0ktQ/y4lRVi wITYXiFXGDOzQ9UAkW2dSPfHcS+Mvl4mP8058Nh3uMNYAE27zhP8WbtdWkvsoP0FQ4Qa nZFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693468951; x=1694073751; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OUnqsw/OkwJVUqTBdMvyaNhziaip8u5tYQz54/giWCc=; b=hq7sx58YcQQEXQfoeb5SRmEcaAr9NGY/mhpyiIRPbZkzv7jf9pm8AMt5Yc6H8njx91 Za2AoAfIEn7As/WUbUf8+znIZMLy2OqzN6+c78pU4viUxlWYG6QR4iHna4Kqx+4nMv44 yljDsrjjA2wB5yYYMz/ms8tWkcyHh+F5ildaPvjofKtolXVo/d94s538PxUh4GO9ijxJ ZjUMlEl3Q0MyJIb7P6it3PvWtA80x65lPFFWQnsm5C66JCQCa9xm8VLy+n9IBKN8O4iD j27Wc9z5iRq0puIgtqzcEYm2ZaS9q+OV7O31nqGbStKKRleVFQ1xQDc7YQ/8D2P7EDZm rLVQ== X-Gm-Message-State: AOJu0YwdMecCkKnso578mfo7JcJXOtpLq+8BOQLYw7uUSMokCLgINXUq cnC/h1xx37vpTUg9RnImRwNM1JDU0l2eL+/XWXYmsL4u X-Google-Smtp-Source: AGHT+IEzw/ECllO7+VcLRXEza63S+crpfF8CZksNS+zrwYVq9RzdUiqvwJ/1kZsXhPTLmpLRsjmrAN3Px/UJSrGMHLw= X-Received: by 2002:a2e:9959:0:b0:2b9:e230:25ce with SMTP id r25-20020a2e9959000000b002b9e23025cemr3935795ljj.12.1693468951145; Thu, 31 Aug 2023 01:02:31 -0700 (PDT) In-Reply-To: <838r9rg5x3.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::236; envelope-from=joaotavora@gmail.com; helo=mail-lj1-x236.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, MIME_BOUND_DIGITS_15=0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:309605 Archived-At: --0000000000004571740604337722 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Aug 31, 2023, 06:03 Eli Zaretskii wrote: > > Date: Thu, 31 Aug 2023 00:49:53 +0300 > > Cc: Yuri Khan , Eli Zaretskii , > > emacs-devel , "Philip K." > > From: Dmitry Gutov > > > > > I don't know how VSCode does it, but refactorings -- at least the kin= d > > > provided by LSP servers -- aren't in general as trivial as simple > > > renamings. They are arbitrary sets of changes to code, like moving > > > whole functions from one file to another, adding new sections or new > > > files, removing sections or whole files, etc, etc. > > > > I previously posted a link to a screenshot from VS Code, here it is > > again: > > > https://bobbyhadz.com/images/blog/rename-variable-vscode/refactor-preview= .webp > > Having never used VSCode, I have difficulty understanding what I see > there. Could you (or someone else) please post a detailed description > of what is shown there and what kind of refactoring is going on? TIA. > I had seen this screenshot already. I think it is a very simple rename. If like to see how it handles clangd's move function to out-of-line action, for example. Jo=C3=A3o > --0000000000004571740604337722 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Aug 31, 2023, 06:03 Eli Zaretskii <eliz@gnu.org> wrote:
> Date: Thu, 31 Aug 2023 00:49:53 +0300
> Cc: Yuri Khan <yuri.v.khan@gmail.com>, Eli Zaretskii <= eliz@g= nu.org>,
>=C2=A0 emacs-devel <emacs-devel@gnu.org>, "Philip K.&qu= ot; <philipk@posteo.net>
> From: Dmitry Gutov <dmitry@gutov.dev>
>
> > I don't know how VSCode does it, but refactorings -- at least= the kind
> > provided by LSP servers -- aren't in general as trivial as si= mple
> > renamings.=C2=A0 They are arbitrary sets of changes to code, like= moving
> > whole functions from one file to another, adding new sections or = new
> > files, removing sections or whole files, etc, etc.
>
> I previously posted a link to a screenshot from VS Code, here it is > again:
> https:= //bobbyhadz.com/images/blog/rename-variable-vscode/refactor-preview.webp

Having never used VSCode, I have difficulty understanding what I see
there.=C2=A0 Could you (or someone else) please post a detailed description=
of what is shown there and what kind of refactoring is going on?=C2=A0 TIA.=


--0000000000004571740604337722--