From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#47388: 27.1; eldoc-documentation-function is ignore in updated eldoc Date: Fri, 26 Mar 2021 20:34:16 +0000 Message-ID: References: <871rc35nwr.fsf@gmail.com> <87o8f53h3q.fsf@tcd.ie> <87im5dg36l.fsf@gmail.com> <87czvlraus.fsf@gmail.com> <87a6qpg02v.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000056efe905be7675d8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13995"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Basil L. Contovounesios" , 47388@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 26 21:43:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lPtIa-0003VC-R3 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Mar 2021 21:43:16 +0100 Original-Received: from localhost ([::1]:34064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPtIZ-00080M-QO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Mar 2021 16:43:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPtAd-0006tL-Lh for bug-gnu-emacs@gnu.org; Fri, 26 Mar 2021 16:35:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59290) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lPtAc-0004Uo-CZ for bug-gnu-emacs@gnu.org; Fri, 26 Mar 2021 16:35:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lPtAc-00028t-97 for bug-gnu-emacs@gnu.org; Fri, 26 Mar 2021 16:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Mar 2021 20:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47388 X-GNU-PR-Package: emacs Original-Received: via spool by 47388-submit@debbugs.gnu.org id=B47388.16167908758194 (code B ref 47388); Fri, 26 Mar 2021 20:35:02 +0000 Original-Received: (at 47388) by debbugs.gnu.org; 26 Mar 2021 20:34:35 +0000 Original-Received: from localhost ([127.0.0.1]:42603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPtAA-000286-Pa for submit@debbugs.gnu.org; Fri, 26 Mar 2021 16:34:35 -0400 Original-Received: from mail-io1-f52.google.com ([209.85.166.52]:35673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lPtA9-00027u-7n for 47388@debbugs.gnu.org; Fri, 26 Mar 2021 16:34:33 -0400 Original-Received: by mail-io1-f52.google.com with SMTP id x17so6725276iog.2 for <47388@debbugs.gnu.org>; Fri, 26 Mar 2021 13:34:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K2KODolrtIsIFXl235vFlwT6aCmODMiaFV25dPilGxE=; b=BrwFOJEUI/2QrPEjycQU4238TETmd+YpjLudDfvhglZXbYiKP6CtnIIviY84eXu6gI o4AA0KiDO1jjTviMXCZ7PjCt++4iL6QasChlrI2XKCHbd9Jee7SCXUsUt/Ds9ZhgGbuw pYLu/JTAJNwdy2eLjunt+Y0oIx4970Vfe1VRoxs+AhDFIpBP5CVCKexMDDo5yKc+Tx3z ufQgUoM9qewF5d8xLVPPM7VCbv/0F7fDcQaiyJHDPRdH8UH62eHoN4RAbf8FzKBI5UZT cBwlxIjjqBVgKbho2XCc13tF5bthmUEDbF+gP1yLeIh7jyxZhhIKzMYqBrUVqWF9gePB o17A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K2KODolrtIsIFXl235vFlwT6aCmODMiaFV25dPilGxE=; b=ouByaBiYnWIc5BqjIcqSoyd6jxTkFWKvq9fqa1FG6aupqUeuh8wLxTl8ah06lDUkRN TU9ejcDZiIP/ILrFcmpJRXqTyUswN3x12n6BYqsPhS7CuM1VCX8WAw4/iQc7M/L2ZO/6 /KElun2jT8pjEIRARkhG6pnsPF7SjZ0gczaqF1T6bvruoyrrpXJ5Pj0nhLmiqd1RplwT 8pFSvdXgK3rA+Ak8C6QkccWZZZ6L0DadYABdA1I6bvLMIaEaq6Kfs/fqIjSDZCIH5Lao dBOPUr9AO3df12U1jOnkV/CuArAQFY33rQibkXcBaJfBcpkjJvuz8h2zBh/uvQH3rXch gfYg== X-Gm-Message-State: AOAM531V94sU+qyxNHqHXfPe/IL7AcFLOY0AAMoiy2STcvOwuza2ILKv D/MgFX0Flj2j6v4va3egZaBujS/T7xgIf2zRDzU= X-Google-Smtp-Source: ABdhPJxyUAjeV3INfuo3CDN8y9lLg5WmofhmZ48M6IBfeTt+IXpaoIvSixRp22jAZzuHmCzZ0IsZB+cOET2jMG3GQro= X-Received: by 2002:a5e:c00a:: with SMTP id u10mr11645596iol.165.1616790867602; Fri, 26 Mar 2021 13:34:27 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203075 Archived-At: --00000000000056efe905be7675d8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Mar 26, 2021 at 8:24 PM Alex Branham wrote= : > Because then we modify el-doc-functions because of the newer version of > eldoc loaded. > > But the ignore value of el-doc-function prevents eldoc from working > > Hopefully that helps, sorry for the brevity am on phone > Ah, I get it, so ess-mode does something different. Then maybe it should also set eldoc-documentation-strategy to something sensible. Eldoc-documentation-strategy is just the new name of eldoc-documentation-function. If you find an `ignore` there, you're safe to change it , buffer-locally, as you did before. Maybe you should even do it even if you _don't_ find an ignore there. The fact that it's now defcustom doesn't change much in my opinion, I don't see defcustom's as off-limits to major/minor modes, as long as the user is still given override power in the mode hooks. Alternatively, ess-mode should just use the old interface. It's still available and functional. But I think you should select a strategy that suits `ess-mode`'s functions. Hope this helps, Jo=C3=A3o --00000000000056efe905be7675d8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Mar 26, 2021 at 8:24 PM Alex Branham <alex.branham@gmail.com> wro= te:
Because then we modify el-doc-functions because of the newer version = of eldoc loaded.=C2=A0

But the= ignore value of el-doc-function prevents eldoc from working

Hopefully that helps, sorry for the b= revity am on phone

Ah, I = get it, so ess-mode does something different.=C2=A0 Then
may= be it should also set eldoc-documentation-strategy
to something s= ensible.=C2=A0 Eldoc-documentation-strategy is
just the new name = of eldoc-documentation-function.
If you find an `ignore` there, y= ou're safe to change it
, buffer-locally, as you did bef= ore.=C2=A0 Maybe you should
even do it even if you _don't_ fi= nd an ignore there.
The fact that it's now defcustom doesn= 9;t change much
in my opinion, I don't see defcustom's as= off-limits to major/minor
modes, as long as the user is still gi= ven override power
in the mode hooks.

Al= ternatively, ess-mode should just use the old interface.
It&= #39;s still available and functional.=C2=A0

B= ut I think you should select a strategy that suits `ess-mode`'s
functions.=C2=A0

Hope this helps,
Jo=C3=A3o

--00000000000056efe905be7675d8--