From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#44689: 28.0.50; Use appropriate face for Flymake unknown backend Date: Wed, 18 Nov 2020 08:29:22 +0000 Message-ID: References: <875z65i5lt.fsf@protesilaos.com> <87pn4dueoq.fsf@gnus.org> <87r1os5yqk.fsf@protesilaos.com> <87mtzg5n8o.fsf@protesilaos.com> <87lff0j67w.fsf@gmail.com> <87y2izxl2c.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000094fc2b05b45d69f6" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22008"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44689@debbugs.gnu.org, Lars Ingebrigtsen To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 18 09:30:43 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kfIrM-0005FP-6Y for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Nov 2020 09:30:36 +0100 Original-Received: from localhost ([::1]:56718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfIrL-0007Ot-7v for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Nov 2020 03:30:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kfIqp-0006ya-JS for bug-gnu-emacs@gnu.org; Wed, 18 Nov 2020 03:30:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50610) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kfIqp-0004M9-9s for bug-gnu-emacs@gnu.org; Wed, 18 Nov 2020 03:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kfIqp-0004e8-6R for bug-gnu-emacs@gnu.org; Wed, 18 Nov 2020 03:30:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Nov 2020 08:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44689 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44689-submit@debbugs.gnu.org id=B44689.160568818717796 (code B ref 44689); Wed, 18 Nov 2020 08:30:03 +0000 Original-Received: (at 44689) by debbugs.gnu.org; 18 Nov 2020 08:29:47 +0000 Original-Received: from localhost ([127.0.0.1]:33922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfIqZ-0004cx-9Y for submit@debbugs.gnu.org; Wed, 18 Nov 2020 03:29:47 -0500 Original-Received: from mail-io1-f48.google.com ([209.85.166.48]:46545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfIqX-0004ch-F3 for 44689@debbugs.gnu.org; Wed, 18 Nov 2020 03:29:46 -0500 Original-Received: by mail-io1-f48.google.com with SMTP id r1so1075155iob.13 for <44689@debbugs.gnu.org>; Wed, 18 Nov 2020 00:29:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8bwoOIAktWFa5NDgdoleOZaVbt66clokflVOITi3H/U=; b=C21YjawV+bCMVKRB0L/gTIoHteMRbhVumnq3QjqKrMXQWxs5YvkR2Of024NlOQdK3P a1yw1F/akWbrrXYd99taSSueSM6AmupX7hkRB4Y+H6t2an9mQ/UDq16khoiLZvkYblUt HWVSDaKcVZ0uh6VFg6vGgglsed6CPmuqSreQ2FigluLlcMGVya7ZaBmXym9RwlxE2pmZ xvjdq4oARLOoefSZFPL8I0JAZaeX8oPwHBgRuMPLk7t5DcbPOQBj+wr2e0/UZIk+g631 Jm5z91ZCT8PKm5D0Af/dQ3BD9hqqRuC+1BvI+kXwbsNlPiRgZDNP0PBjs7+826Y/1Y7G 9IuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8bwoOIAktWFa5NDgdoleOZaVbt66clokflVOITi3H/U=; b=q0yMbZVBt3XN51/eWo99/cEdlFhR1vnHwJ1kNvVGFOCDxd7mMCo/AfX4jHJdOZLkPa EmggxJLvQecc5F9xlJli+5MlSfAi5MR3FGo3dIUdIqyhcfTDumYtOYuCh7l8FPIUrIqZ /K0sTyv1jV3T/duQxU0GfTriQ/NkHVs5cygCFzajp5IfQmuurXGgEu1FKqHSkOSnUWBp l2a/xKbS0u/1LeSAp6PHfQ+bD2QyaScvbPNjH3zbOyo/wohWgrt0MYYpmbgc3g0xtx8Q wOnrZ2MRQznM5KCUf4CK99yUPbPy7JV9CddrugWR5n5RrceXHQW+Guq2vN8lCOKCdDRO fqmw== X-Gm-Message-State: AOAM533letfCKzzlCXLmzCnoqUooDGi54qjcJsUbVpnMfqkY5Sd6yyjH QUBUBVq0gihgo9TwpYM8ZUy7AxJJJ0Hv3ULMCc0= X-Google-Smtp-Source: ABdhPJyBCmFlpyrUHEYCfXGIABbA2uy6SFW9YvaaGg/WP+bAt2Y/9FotQlO3xUGRW26J36RojT2Vshx+x4bZCTFpYJ8= X-Received: by 2002:a02:c6bb:: with SMTP id o27mr7516247jan.136.1605688179881; Wed, 18 Nov 2020 00:29:39 -0800 (PST) In-Reply-To: <87y2izxl2c.fsf@protesilaos.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193601 Archived-At: --00000000000094fc2b05b45d69f6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Nov 18, 2020, 05:58 Protesilaos Stavrou wrote: > On 2020-11-17, 16:30 +0000, Jo=C3=A3o T=C3=A1vora = wrote: > > >> [...] > >> > >> just to point out that the "?" is easy to get. > >> > >> On 'emacs -Q': > >> > >> (require 'flymake) > >> (setq flymake-start-on-flymake-mode nil) > >> > >> Now visit an '*.el' file. Activate 'flymake-mode' and check the > >> modeline. > > > > Indeed, that's not a misconfiguration. But I'd say it's an edge case: > > normally one does want to start checking when enabling flymake, I just > > kept that option there for backward compatibility. I personally see no > > use for it, do you? > > The fact that the option exists means that some people might be using > it. Is there any immediate downside to keeping it around? Personally, > I am fine with any decision you may take and agree that it is not what > one would normally expect when activating 'flycheck-mode'. > > What I wanted to suggest when I opened this issue is merely this: if > this "edge case" option remains present, please consider reviewing the > face it uses (with 'mode-line-emphasis' being more appropriate than > 'mode-line'). > Yes, I am totally fine with changing the face, or using some other character to indicate this situation. I just don't see it as super priority because it's an odd setting to have, in my opinion, but patches welcome. Jo=C3=A3o > --00000000000094fc2b05b45d69f6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Nov 18, 2020, 05:58 Protesilaos Stavrou <info@protesilaos.com> wrote:
=
On 2020-11-17, 16:30 +0000, Jo=C3=A3o T=C3= =A1vora <joaotavora@gmail.com> wrote:

>> [...]
>>
>> just to point out that the "?" is easy to get.
>>
>> On 'emacs -Q':
>>
>>=C2=A0 =C2=A0 =C2=A0(require 'flymake)
>>=C2=A0 =C2=A0 =C2=A0(setq flymake-start-on-flymake-mode nil)
>>
>> Now visit an '*.el' file.=C2=A0 Activate 'flymake-mode= ' and check the
>> modeline.
>
> Indeed, that's not a misconfiguration.=C2=A0 But I'd say it= 9;s an edge case:
> normally one does want to start checking when enabling flymake, I just=
> kept that option there for backward compatibility.=C2=A0 I personally = see no
> use for it, do you?

The fact that the option exists means that some people might be using
it.=C2=A0 Is there any immediate downside to keeping it around?=C2=A0 Perso= nally,
I am fine with any decision you may take and agree that it is not what
one would normally expect when activating 'flycheck-mode'.

What I wanted to suggest when I opened this issue is merely this: if
this "edge case" option remains present, please consider reviewin= g the
face it uses (with 'mode-line-emphasis' being more appropriate than=
'mode-line').

Yes, I am totally fine with changing the face, or usin= g some other character to indicate this situation. I just don't see it = as super priority because it's an odd setting to have, in my opinion, b= ut patches welcome.

Jo= =C3=A3o
--00000000000094fc2b05b45d69f6--