From: "João Távora" <joaotavora@gmail.com>
To: Robert Pluim <rpluim@gmail.com>, Eli Zaretskii <eliz@gnu.org>
Cc: Brian Leung <leungbk@posteo.net>,
Lars Ingebrigtsen <larsi@gnus.org>,
53853@debbugs.gnu.org
Subject: bug#53853: [PATCH] Don't use string-replace in flymake
Date: Tue, 8 Feb 2022 09:58:06 +0000 [thread overview]
Message-ID: <CALDnm52KrN-w5_ru3_qtsTBU0KtiQDMG4nQ8jmz5r+oN4KtKoA@mail.gmail.com> (raw)
In-Reply-To: <CALDnm5305VY1QM8DW+KfVzWW9q8oaUa2VfYkNkn_6ahYH7bJFw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]
Eli, how are you? I hope well.
This change:
commit 6b8957852476e4ba31873424aa8f81d9e55bc34c
Author: Eli Zaretskii <eliz@gnu.org>
Date: Thu Dec 9 17:01:57 2021 +0200
; * lisp/progmodes/flymake.el: Update the minimum Emacs version.
diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -9,1 +9,1 @@
-;; Package-Requires: ((emacs "26.1") (eldoc "1.1.0") (project "0.7.1"))
+;; Package-Requires: ((emacs "28.1") (eldoc "1.1.0") (project "0.7.1"))
breaks "downstream" users of flymake.el as a "core" package, eglot.el
most notably.
Can you explain it? I'm not 100% sure if we have discussed this before.
If we have, I'm very sorry, but I forgot the context.
Thanks,
João
On Tue, Feb 8, 2022 at 9:54 AM João Távora <joaotavora@gmail.com> wrote:
> On Tue, Feb 8, 2022 at 9:50 AM Robert Pluim <rpluim@gmail.com> wrote:
>
>> >>>>> On Tue, 8 Feb 2022 09:20:07 +0000, João Távora <
>> joaotavora@gmail.com> said:
>>
>> João> I'm not in front of my computer right now, but as far as I
>> recall, there is
>> João> a note in the preamble of flymake.el asking maintainers not to
>> use
>> João> functionality incompatible with the given emacs dependency.
>>
>> There is, and the current flymake.el says emacs-28.
>>
>
> Does it? That's news to me. It shouldn't, I think. That breaks a lot of
> downstream
> users, eglot.el most notably.
>
> I have to M-x vc-region-history that bit.
>
> João
>
>
>
--
João Távora
[-- Attachment #2: Type: text/html, Size: 2715 bytes --]
next prev parent reply other threads:[~2022-02-08 9:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 16:11 bug#53853: [PATCH] Don't use string-replace in flymake Brian Leung
2022-02-07 17:32 ` Robert Pluim
2022-02-08 2:17 ` Brian Leung
2022-02-08 6:16 ` Lars Ingebrigtsen
2022-02-08 8:21 ` Robert Pluim
2022-02-08 8:28 ` Brian Leung
2022-02-08 8:35 ` Robert Pluim
2022-02-08 9:20 ` João Távora
2022-02-08 9:50 ` Robert Pluim
2022-02-08 9:54 ` João Távora
2022-02-08 9:58 ` João Távora [this message]
2022-02-08 13:03 ` Eli Zaretskii
2022-02-08 13:18 ` João Távora
2022-02-08 13:54 ` Eli Zaretskii
2022-02-08 14:09 ` João Távora
2022-02-08 15:07 ` Robert Pluim
2022-02-08 15:30 ` João Távora
2022-02-08 15:47 ` Robert Pluim
2022-02-08 15:51 ` João Távora
2022-02-08 16:02 ` Robert Pluim
2022-02-08 16:43 ` João Távora
2022-02-08 17:02 ` Robert Pluim
2022-02-08 17:55 ` Dmitry Gutov
2022-02-08 17:08 ` Dmitry Gutov
2022-02-09 8:55 ` Robert Pluim
2022-02-08 9:52 ` João Távora
2022-02-08 10:19 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm52KrN-w5_ru3_qtsTBU0KtiQDMG4nQ8jmz5r+oN4KtKoA@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=53853@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=leungbk@posteo.net \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.