From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Fwd: Flymake and the 'face' property Date: Tue, 29 Jan 2019 19:58:52 +0000 Message-ID: References: <20190128152540.6870.46132@vcs0.savannah.gnu.org> <20190128152541.12A4D20B50@vcs0.savannah.gnu.org> <30bm401x64.fsf@fencepost.gnu.org> <83r2cw35jq.fsf@gnu.org> <83munk33gj.fsf@gnu.org> <83h8dr2yll.fsf@gnu.org> <83bm3z2vyv.fsf@gnu.org> <87munj2tzz.fsf@gnu.org> <837een2rz1.fsf@gnu.org> <8336pb2qjy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000018c2e405809e3b07" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="31686"; mail-complaints-to="usenet@blaine.gmane.org" Cc: bojohan@gnu.org, emacs-devel To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 29 20:59:58 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1goZY5-00085v-Jr for ged-emacs-devel@m.gmane.org; Tue, 29 Jan 2019 20:59:57 +0100 Original-Received: from localhost ([127.0.0.1]:54831 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goZY4-0007yr-EG for ged-emacs-devel@m.gmane.org; Tue, 29 Jan 2019 14:59:56 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goZXx-0007yl-1H for emacs-devel@gnu.org; Tue, 29 Jan 2019 14:59:49 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1goZXw-0003jQ-0J for emacs-devel@gnu.org; Tue, 29 Jan 2019 14:59:48 -0500 Original-Received: from mail-qt1-x834.google.com ([2607:f8b0:4864:20::834]:41372) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1goZXp-0003dr-P8; Tue, 29 Jan 2019 14:59:44 -0500 Original-Received: by mail-qt1-x834.google.com with SMTP id l12so23684795qtf.8; Tue, 29 Jan 2019 11:59:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U5pDj4DZKzjNeU77Ousyny0QuaszUkZsUQ3rPkLtvSM=; b=VOtP7lJNzlLRg4nCOMaAKCwN+ZzP0ULAhe+TQfkNJl7fek6sMzG/+DCikSbdeli+Pm TaH3NjUgonkxhgimavDMbA/3gjpnQ44jzEWt+ybD4h0ttIGfVhqnkBot5FdVsGITWgA6 5T3AhEPeT6xqW1NT9s2lG38x0e2k3fwaPWoKrIkxhOTq/xkHJPSEqGQU0f3aBMbzppPx Y86/xZSQy2HGHcIuNFAub1x2xA4vEfg03kP1s66NBAUSX1HLJ+EIuqyqH0NlHpwYODcQ gTY7rPGntWZDNu38Qx7h3Q6PxhhtnwZyykRIkJGRNVYkfBruoe36Y6XPsmr0QZnasTCA hEwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U5pDj4DZKzjNeU77Ousyny0QuaszUkZsUQ3rPkLtvSM=; b=dN9t17zYuLUNeO9ebnSbWSBoGI2H51mqp+7fNR8vKBjo8F8vx5wTlMVMm48wWCc6vd GSQ1cVUihhkVR2yRqFG/oE8CjwnM8AQDB9DBhPWZY4IhFF817CCJeyhNWz6+strWzi9V BxNwvVPZ+a9SGWKidH4bqbnWpyr4LjSTGfyvmZZ7PVf1v7Tp4Eu9ypCfzNLBQ/LhEog/ DLG2/BuPBSZrzY4H9EdedGYDEbY5PrIM1XgxfWC/0kDptymyVP+SXAiVAmdTH79cjC9Y /LXUN5E/MAxLh29pmv8gtAzOjfEmZ9uj8TOcyOhGnxFLT44RmzibBpzwX5sEEwo9D9Bx grgA== X-Gm-Message-State: AJcUukc3aKa6HxmS42Vgxo16vADNXqY3zIwO6tlDpvZ9xeTC3ph5HC0w 5J/v3Iyg/ssFmWXlV98e33dIpcVH3HIhZ4vVv7z8Mw== X-Google-Smtp-Source: ALg8bN7aeKFGCOSwBAy0/I//LloCAB0S1JM187jm8H/MtnYa3LEzHCNJp/gp2UNwCp311gnNCYgLvQpXhJdRVCR+2LE= X-Received: by 2002:ac8:88:: with SMTP id c8mr27834796qtg.218.1548791968218; Tue, 29 Jan 2019 11:59:28 -0800 (PST) In-Reply-To: <8336pb2qjy.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::834 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232811 Archived-At: --00000000000018c2e405809e3b07 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jan 29, 2019, 19:48 Eli Zaretskii > From: Jo=C3=A3o T=C3=A1vora > > Date: Tue, 29 Jan 2019 19:33:33 +0000 > > Cc: Johan Bockg=C3=A5rd , > > emacs-devel > > > > > > > A 'face' property is documented for general use only for text, no= t > for > > > > > symbol plists. > > > > (put 'rng-error 'face 'rng-error) > > > > > > I don't see how this contradicts what I said. Do you? > > > > Well you did say that 'face should *not* be put on symbol plists, > > but the documentation and the code states otherwise. > > A single well-documented exception doesn't invalidate the rule. > You must mean the unwritten, inadvertently created rule, right? Ok, no problem, exceptions are fine as long as we document them. But I think flymake is using the exception that I meant to document, i.e. it is using overlay categories. It can either stop using them or change the face name. Both alternatives are backward incompatible to users, thought perhaps not "by much", as that part of flymake might have been a wee bit overdesigned. Have to check better. I still wonder, as Daniel, if using some other symbol for the display code would be very disruptive. Jo=C3=A3o > --00000000000018c2e405809e3b07 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, = Jan 29, 2019, 19:48 Eli Zaretskii <eliz@= gnu.org wrote:
> From: Jo=C3= =A3o T=C3=A1vora <joaotavora@gmail.com>
> Date: Tue, 29 Jan 2019 19:33:33 +0000
> Cc: Johan Bockg=C3=A5rd <bojohan@gnu.org>,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0emacs-devel <emacs-devel@gnu.org>=
>
> > > > A 'face' property is documented for general use= only for text, not for
> > > > symbol plists.
> > > (put 'rng-error 'face 'rng-error)
> >
> > I don't see how this contradicts what I said.=C2=A0 Do you? >
> Well you did say that 'face should *not* be put on symbol plists,<= br> > but the documentation and the code states otherwise.

A single well-documented exception doesn't invalidate the rule.

=
You must mean the unwritten, inadvertently created rule, = right? Ok, no problem, exceptions are fine as long as we document them.

But I think flymake is usin= g the exception that I meant to document, i.e. it is using overlay categori= es. It can either stop using them or change the face name. Both alternative= s are backward incompatible to users, thought perhaps not "by much&quo= t;, as that part of flymake might have been a wee bit overdesigned. Have to= check better.

I still w= onder, as Daniel, if using some other symbol for the display code would be = very disruptive.

Jo=C3= =A3o
--00000000000018c2e405809e3b07--