all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: bojohan@gnu.org, emacs-devel <emacs-devel@gnu.org>
Subject: Re: Fwd: Flymake and the 'face' property
Date: Tue, 29 Jan 2019 19:58:52 +0000	[thread overview]
Message-ID: <CALDnm52HpTKocmXSbQR4qSTZFJpZKSmdhnnWOP4tZQ6J1M11-w@mail.gmail.com> (raw)
In-Reply-To: <8336pb2qjy.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1272 bytes --]

On Tue, Jan 29, 2019, 19:48 Eli Zaretskii <eliz@gnu.org wrote:

> > From: João Távora <joaotavora@gmail.com>
> > Date: Tue, 29 Jan 2019 19:33:33 +0000
> > Cc: Johan Bockgård <bojohan@gnu.org>,
> >       emacs-devel <emacs-devel@gnu.org>
> >
> > > > > A 'face' property is documented for general use only for text, not
> for
> > > > > symbol plists.
> > > > (put 'rng-error 'face 'rng-error)
> > >
> > > I don't see how this contradicts what I said.  Do you?
> >
> > Well you did say that 'face should *not* be put on symbol plists,
> > but the documentation and the code states otherwise.
>
> A single well-documented exception doesn't invalidate the rule.
>

You must mean the unwritten, inadvertently created rule, right? Ok, no
problem, exceptions are fine as long as we document them.

But I think flymake is using the exception that I meant to document, i.e.
it is using overlay categories. It can either stop using them or change the
face name. Both alternatives are backward incompatible to users, thought
perhaps not "by much", as that part of flymake might have been a wee bit
overdesigned. Have to check better.

I still wonder, as Daniel, if using some other symbol for the display code
would be very disruptive.

João

>

[-- Attachment #2: Type: text/html, Size: 2393 bytes --]

  reply	other threads:[~2019-01-29 19:58 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190128152540.6870.46132@vcs0.savannah.gnu.org>
     [not found] ` <20190128152541.12A4D20B50@vcs0.savannah.gnu.org>
2019-01-28 16:05   ` [Emacs-diffs] master cd06d17: Fix bug with face-id after restoring from pdump Daniel Colascione
2019-01-28 18:14     ` Eli Zaretskii
2019-01-28 19:37       ` Daniel Colascione
2019-01-28 20:19         ` Eli Zaretskii
2019-01-28 17:58   ` Glenn Morris
2019-01-28 20:05     ` Eli Zaretskii
2019-01-28 20:12     ` Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) Eli Zaretskii
2019-01-28 20:39       ` João Távora
2019-01-28 20:57         ` Eli Zaretskii
2019-01-28 21:38           ` João Távora
2019-01-29 16:54             ` Eli Zaretskii
     [not found]               ` <CALDnm53FnkT+fjneg3uLNMsCu1MxJK1aKWQyvz85EjVdOyr4bg@mail.gmail.com>
2019-01-29 17:26                 ` Fwd: " João Távora
2019-01-29 17:51                   ` Eli Zaretskii
2019-01-29 17:54                     ` Daniel Colascione
2019-01-29 18:30                       ` Eli Zaretskii
2019-01-29 18:43                         ` Fwd: Flymake and the 'face' property Daniel Colascione
2019-01-29 19:19                           ` Eli Zaretskii
2019-01-29 18:47                       ` Fwd: Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) João Távora
2019-01-29 18:53                         ` Fwd: Flymake and the 'face' property Daniel Colascione
2019-01-29 19:00                           ` João Távora
2019-01-29 19:21                         ` Fwd: Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) Eli Zaretskii
2019-01-29 19:28                           ` João Távora
2019-01-29 18:28                     ` João Távora
2019-01-29 18:34                     ` Fwd: Flymake and the 'face' property Johan Bockgård
2019-01-29 18:49                       ` João Távora
2019-01-29 19:17                       ` Eli Zaretskii
2019-01-29 19:33                         ` João Távora
2019-01-29 19:48                           ` Eli Zaretskii
2019-01-29 19:58                             ` João Távora [this message]
2019-01-30  9:37                     ` Stefan Monnier
2019-01-30 15:40                       ` Eli Zaretskii
2019-01-30 17:05                         ` João Távora
2019-01-30 18:01                           ` Eli Zaretskii
2019-01-30 20:56                         ` Stefan Monnier
2019-01-31  3:38                           ` Eli Zaretskii
2019-02-02  8:23                             ` Stefan Monnier
2019-02-02 10:12                               ` Eli Zaretskii
2019-02-02 22:49                                 ` Stefan Monnier
2019-02-03  3:39                                   ` Eli Zaretskii
2019-02-03 12:35                                     ` Stefan Monnier
2019-01-29 17:52                   ` Fwd: Flymake and the 'face' property (was: master cd06d17: Fix bug with face-id after restoring from pdump) Daniel Colascione

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALDnm52HpTKocmXSbQR4qSTZFJpZKSmdhnnWOP4tZQ6J1M11-w@mail.gmail.com \
    --to=joaotavora@gmail.com \
    --cc=bojohan@gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.