From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: master a33e7c0286c 2/2: Disable workDoneProgress if defcustom is nil Date: Wed, 17 Apr 2024 16:49:41 +0100 Message-ID: References: <171182835532.14560.17113012267608349468@vcs2.savannah.gnu.org> <20240330195235.E717BC1FB61@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17240"; mail-complaints-to="usenet@ciao.gmane.io" To: Theodor Thornhill , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 17 17:50:31 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rx7YN-0004IW-0m for ged-emacs-devel@m.gmane-mx.org; Wed, 17 Apr 2024 17:50:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rx7Xq-0005uB-9u; Wed, 17 Apr 2024 11:49:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rx7Xo-0005tt-WD for emacs-devel@gnu.org; Wed, 17 Apr 2024 11:49:57 -0400 Original-Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rx7Xn-0006WG-AS for emacs-devel@gnu.org; Wed, 17 Apr 2024 11:49:56 -0400 Original-Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2da88833109so44404261fa.0 for ; Wed, 17 Apr 2024 08:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713368993; x=1713973793; darn=gnu.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eQjjI8UQz3k+UITgMpHgruuGjqF8b8f0MaeHf3TiBRA=; b=ATfAjvmDg6UihRLBfcTd6PMAKPvpApsnApWCSo/oqQjjI4bT4uV526CddSQ818+n1e dBQJp4Wk25TZ9XPevgdPiztisiUNAcKwQJvOrfckdsLASEMoG4jHZGkPLvtjqezpqMUj 1IYwKarSvHiPDX2oPKvx+5cK9iB5krbwEeEvoQQQcc3pSt9eABaDle63fYshiIlR/4l/ EHoEPNbnD9AQ9a9KUGKr9/snCzhgGQoBSxb1N+x91u8US+hpU2W82BOn/OpoFCuusRbN olVXdWNVXQiEQrKXxa80jMywZMl+ZLMwEAHg8yjfIF5R4lJhz5XUEz9tHpUMC5g2sZ1Y edkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713368993; x=1713973793; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eQjjI8UQz3k+UITgMpHgruuGjqF8b8f0MaeHf3TiBRA=; b=NzERQJiKN64Z5bhG6YXAFrBqbIs1hruyWF2qgi8cZnx7iCv/879Rc3CWbuBn0FzvJe YCSxhOvQWv+w53hPirLWfZAx8BdcTTjSfa3V0ww2H/boiL8/RJ475de5JEmF9ObJlLi1 XKtJJ07hdlZmHiNQJ5T1bEmpZ+gOwk7dtVzgxFgIL+IqLlrRHl6TUYKO5ia90lv1pXi4 cXCyeBD/OyA35dLs8ERPLXfuu51X7t2ab89GxfNRLFtFKsSxU1cK8aHzNPrYnbe3Jn6G C6IJiqLYv88yzb8mzwK2l4JFoEdTeD4UiaGx2MHjEZul+619V4/USCu0JdnteRthBCqQ 91XA== X-Forwarded-Encrypted: i=1; AJvYcCUwpyBaQ3sbn0Ishg7wigxlgc4VLfHBCF9Retv+ha8VB0j/+eeNDr7QFuCiWpBavzULk8YVGalohkXynIoo4MAeGuVW X-Gm-Message-State: AOJu0Yw+efXs0VGWqYdYPcGzp9vWqIBC7wGaa5vDe1IbIEuEWuTpf+JQ vM2ydnoxBvAD6amTllBcii9q5GDJ617JOLouiL+kMtezNO3OlTmUTCyRUR7IdgopH62ChHOPyl3 hJKMfuYQRUZYCikicQQZGk/gGoHE= X-Google-Smtp-Source: AGHT+IHnHFpv9lCqq4ENJzkM2kWkaT0RW07TUlGa39PNghjz6iV+gYEyv5mSON8MptqYQNDJp8DLuP/O8gQvGq+9WJ0= X-Received: by 2002:a2e:9659:0:b0:2d8:2710:c64c with SMTP id z25-20020a2e9659000000b002d82710c64cmr12338372ljh.1.1713368993057; Wed, 17 Apr 2024 08:49:53 -0700 (PDT) In-Reply-To: <20240330195235.E717BC1FB61@vcs2.savannah.gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::229; envelope-from=joaotavora@gmail.com; helo=mail-lj1-x229.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317774 Archived-At: On Sat, Mar 30, 2024 at 7:52=E2=80=AFPM Theodor Thornhill via Mailing list = for Emacs changes wrote: > > branch: master > commit a33e7c0286c2a9c8af1c96db42f5c0c37611c9db > Author: Theodor Thornhill > Commit: Theodor Thornhill > > Disable workDoneProgress if defcustom is nil > > There is no need to receive the $/progress notifications from the ser= ver > if we don't want to render them. Because they are effectively ignored > when eglot-report-progress is nil we'd rather not waste cycles on ser= de > of the messages. I agree with this, but it has the side-effect that a user experimenting with setting eglot-report-progress _during_ a session won't see the effects live and needs to reconnect. Which is perfectly fine, IMO, but probably could be documented somewhere. See the similar situation eglot-events-buffer-config and its docstring for an idea. Jo=C3=A3o