From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Indentation of def* Date: Thu, 14 Oct 2021 22:41:11 +0100 Message-ID: References: <878ryw1ptl.fsf@gnus.org> <871r4nn9ty.fsf@yahoo.com> <87ilxzzwn1.fsf@gnus.org> <878ryvzw7s.fsf@gnus.org> <87h7djlskn.fsf@yahoo.com> <87v91zyfiy.fsf@gnus.org> <87wnmfkd7p.fsf@yahoo.com> <877defybbc.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000990d3205ce56f05f" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22126"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , emacs-devel To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 14 23:42:41 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mb8Ur-0005XP-Rc for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Oct 2021 23:42:41 +0200 Original-Received: from localhost ([::1]:55268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mb8Uq-0001nq-A4 for ged-emacs-devel@m.gmane-mx.org; Thu, 14 Oct 2021 17:42:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mb8Te-0000lw-Io for emacs-devel@gnu.org; Thu, 14 Oct 2021 17:41:26 -0400 Original-Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]:46698) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mb8Tc-00017J-2u for emacs-devel@gnu.org; Thu, 14 Oct 2021 17:41:26 -0400 Original-Received: by mail-pg1-x52c.google.com with SMTP id m21so6692640pgu.13 for ; Thu, 14 Oct 2021 14:41:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l9DbrnCTeKvmPKU8MNYoTt+GCw5oLAMiEDR093+gpbk=; b=mAfDR5LpoDGicyNFxBmbiYO6Om4a3E2gvLpq+yZCzYwQnfHqEyi7DWgqAOCiqWoyQY MTfiznnqTQaIFxpSXcULX27k9jAIeQhKSwmeMksUtOgaU0qiX+BhIFJMefdv0waKTGrA Fq5DI+t7NdA1Ns+FnNBVbNTIULnXnNNtkgHpfckbhTSMHMswmaeus3LqnOeZVBn/aeM8 cknvobUXAAldR3tH92z4mOSSRMnBf1oskRUEhPedKA0XjbYSMMyVsWDiibwOFy39LMEr kG4uitiy9QxTqeFvA7VCTY9Ni+dsZwhyHFFNBZKH3D5j19cZy6ePvXPxx4Wqpq1mf3Ck Ei7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l9DbrnCTeKvmPKU8MNYoTt+GCw5oLAMiEDR093+gpbk=; b=VjjrYzY4ntwSdtK/kqQL5zZzRA2LInki04/0+obDN+u+uKXDASlFeQNenNJss8tclL TPAyzNTmW9+97NPjHZ6WY3Gjo6Ch4iTPOl+vk7z1B33HrTEjfbXvSAdlMG7zULVkr8aY wsnCMf5QhjQ8urruPDURggCF0b/MYNBu5czOJXqw87t6znHkDEZh9dsO4Cxx9YbCYMvl ZbjwEbPZ+NrKE2qV8aut0u2fa6f0ENEu3swGmWyoy5J8gThpZVOoeAzqUZ0/Cdswilna mYVzHrmCk7AyelWS86pnllAx50b5L06NqHq67PoHPjXGOj8mUzQhL1WSx9yYRJQGQvp2 kXUQ== X-Gm-Message-State: AOAM532Bs8TBrFJFaDo7+zfHCeYSss7UBYhGPdESBqoK9M7a1g16eciD iYFb7ZYuNL1HejAVfQfI/GoLJyQ0uRyF3E8nq24= X-Google-Smtp-Source: ABdhPJwSTeVkGcV4sjgluYF+5mnvu7Ge4ceSdahcJVrC078Xe6V6DCx0ctk+OMToHidlR4d7XfYclYWgszW9vHRut9M= X-Received: by 2002:a05:6a00:c1:b0:44c:ec40:b47 with SMTP id e1-20020a056a0000c100b0044cec400b47mr7840169pfj.76.1634247682623; Thu, 14 Oct 2021 14:41:22 -0700 (PDT) In-Reply-To: <877defybbc.fsf@gnus.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::52c; envelope-from=joaotavora@gmail.com; helo=mail-pg1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277070 Archived-At: --000000000000990d3205ce56f05f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Oct 14, 2021 at 2:40 PM Lars Ingebrigtsen wrote: > Jo=C3=A3o T=C3=A1vora writes: > > > I'm in favor of tweaking the heuristic and applying it only to macro > > definitions, which are (or should be) the majority of definition > > creating forms. > > In-tree, there are more 2x as many macros that are called def* than > functions, and of those functions, about half of them really wants to > have (indent defun). (And most of the macros, but not all.) > > So the macro/function thing is significant, but not compelling. I'm sorry I couldn't parse this. I sense you're trying to make some kind of argument backed by statistics, but I cannot understand it. Can you explain again in some more detail, for my benefit?. Maybe with a short example for each of the classes you mentioned. And in-tree counts for each of those classes. Thanks, Jo=C3=A3o --000000000000990d3205ce56f05f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Oct 14, 2021 at 2:40 PM Lars Inge= brigtsen <larsi@gnus.org> wrote= :
Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> writes:

> I'm in favor of tweaking the heuristic and applying it only to mac= ro
> definitions, which are (or should be) the majority of definition
> creating forms.

In-tree, there are more 2x as many macros that are called def* than
functions, and of those functions, about half of them really wants to
have (indent defun).=C2=A0 (And most of the macros, but not all.)

So the macro/function thing is significant, but not compelling.

I'm sorry I couldn't parse this.=C2=A0 I sense= you're trying to make
some kind of argument backed by s= tatistics, but I cannot
understand it.=C2=A0 Can you explain= again in some more detail,
for my benefit?.

Maybe with a short example for each of the classes you
mentioned.=C2=A0 And in-tree counts for each of those classes.
<= br>
Thanks,
Jo=C3=A3o
--000000000000990d3205ce56f05f--