From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Date: Sat, 7 Mar 2020 14:10:22 +0000 Message-ID: References: <288610218.111246.1578330546916@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> <834kv3wcyd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="1856"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 38992@debbugs.gnu.org, Dmitry Gutov , Stefan Monnier , waah@yellowfrog.io To: Eli Zaretskii , 38992-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 07 15:11:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jAaAf-0000NM-Fh for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Mar 2020 15:11:17 +0100 Original-Received: from localhost ([::1]:49150 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAaAe-0008Qh-2Y for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Mar 2020 09:11:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46472) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jAaAV-0008QW-Im for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2020 09:11:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jAaAT-0000po-SZ for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2020 09:11:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40473) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jAaAR-0000nK-6c for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2020 09:11:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jAaAR-0003ly-2Q for bug-gnu-emacs@gnu.org; Sat, 07 Mar 2020 09:11:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Mar 2020 14:11:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs Original-Received: via spool by 38992-done@debbugs.gnu.org id=D38992.158359024214465 (code D ref 38992); Sat, 07 Mar 2020 14:11:03 +0000 Original-Received: (at 38992-done) by debbugs.gnu.org; 7 Mar 2020 14:10:42 +0000 Original-Received: from localhost ([127.0.0.1]:46443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAaA6-0003lD-3k for submit@debbugs.gnu.org; Sat, 07 Mar 2020 09:10:42 -0500 Original-Received: from mail-il1-f180.google.com ([209.85.166.180]:35421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAaA4-0003kx-38; Sat, 07 Mar 2020 09:10:40 -0500 Original-Received: by mail-il1-f180.google.com with SMTP id g126so4708673ilh.2; Sat, 07 Mar 2020 06:10:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7E5biPJ1mtf8VZJqqTcfJGuqmUNH11eMOMU/LQfsR2o=; b=bjh6ZN4nBhYfZNEzKdwtZF86UeTqoPtV9S5QxCNO4t5fYDxmg7/ZSyBovkaWfh9iMd 02ru27/URdutAqiDCdJm/Kc3uPziBrJ/sU9jlJiL+bwBmUTA5fN8maP7K0QlQ1X0F0VM E9A3EjPa7NODt85puhawOhXdBPLUMNYWptAzF3/R182zUhxJF8vBBUeX/IPzYgCNl3dB D77171XWwqbGlJ+w4LVsF5UWYduPxIsRR2CoxvXWe+rJvWn+LY+LBBmHskHVL6hvz0d+ AtG4fz1JECroh7kRuPXXUnDjYhoaNczHfnAf/p8RlBTTjibN03tGi6VH4A7zK6QNIZph 428A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7E5biPJ1mtf8VZJqqTcfJGuqmUNH11eMOMU/LQfsR2o=; b=e3cw5Fr1FHWG7h/GFNPWCGVnDNele3F4+drcs0sDzw7dPGw5XrLieTford15fJM//I WXyesuE3D5YJuz6QrmbcvfexgS4f69Pn3CfH5ZeF+au59e1+nD7EZYDTpxRQ8x3vxuPD 1+Aj2vPbYv1eFAQkvsdTdm7VF2Q2cHXVggLfQHiPHgyumDH8XHCjbSn9RmwrFYzXaWzv ekS2BNdHCuCJX1kGuF5Z333hdm6gG4aSJrVk48nFUh/0urFF3WzFGWy8VRLNnebjH2nV uuSiKo3p+3lNNwY9tE0BjKf4n4wK0G7isPEchmgLlPbMFRyd/jacjbJ39cJEk9Zotonc qa4g== X-Gm-Message-State: ANhLgQ0gnQVgnCWa2SVCfg7xD8cXJE8IKWhs9lC0M4xQTPdjTIxtw4WW 3oifZwvanenB5t/Y5RL+g5WUPcA/doMEv3bY99I= X-Google-Smtp-Source: ADFU+vs83kl9nm2BW2j4DXTOzVKY75puW8UlpKLZ7Wscbst8jK3c1dUflaC7O0axhuLFZjc8sdBqHd/jQDmWmCqMFWo= X-Received: by 2002:a92:8f91:: with SMTP id r17mr7083310ilk.97.1583590234295; Sat, 07 Mar 2020 06:10:34 -0800 (PST) In-Reply-To: <834kv3wcyd.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177010 Archived-At: After a few days of successful testing, I've taken the liberty of pushing Dmitry's fixes to emacs-27. Dmitry's fix is fully backward-compatible (doesn't remove any variables or change their meanings), and merely fixes a pre-existing bug in lisp/minibuffer.el by introducing a new internal, user-invisible variable, which we can later remove/rework in master. I'm also marking this bug done (not sure if it wasn't already), Jo=C3=A3o On Thu, Mar 5, 2020 at 6:09 AM Eli Zaretskii wrote: > > > Cc: 38992@debbugs.gnu.org, joaotavora@gmail.com, monnier@iro.umontreal.= ca, > > waah@yellowfrog.io > > From: Dmitry Gutov > > Date: Thu, 5 Mar 2020 02:15:21 +0200 > > > > > diff --git a/lisp/icomplete.el b/lisp/icomplete.el > > > index a1a67e2330..52429fdf37 100644 > > > --- a/lisp/icomplete.el > > > +++ b/lisp/icomplete.el > > > @@ -541,7 +541,7 @@ icomplete-exhibit > > > (icomplete--completion-table) > > > (icomplete--completion-predicate) > > > (if (window-minibuffer-p) > > > - (not minibuffer-completion-confirm)= )))) > > > + (eq minibuffer-completion-confirm t= ))))) > > > (buffer-undo-list t) > > > deactivate-mark) > > > ;; Do nothing if while-no-input was aborted. > > > > The above is a simple bugfix of "why the hell not" variety: I don't > > think that code worked well before that patch, i.e. it treated the > > values of nil and t of REQUIRE-MATCH the same. Good thing that only > > affected the choice of parens to print in the minibuffer. > > > > > IOW, some code which just assumes that anything non-nil and > > > non-confirm must be confirm-after-completion, or the other way > > > around. It's an incompatible change. > > > > I'm not arguing that is isn't. But looking at the actual uses out there= , > > the chief popular alternatives to completing-read-default don't seem to > > be affected. And this variable is bound inside completing-read-default, > > so only particular kind of code could really use it. Breakage is > > possible, of course, but I'm fairly sure the affected audience would be > > minimal. > > > > Anyway, see the alternative patches in the branch 'fido-mode-fix' I jus= t > > pushed. > > > > > Is the problem this attempts to fix really serious? Or is it just a > > > minor inconvenience? It isn't the original one that started the bug > > > report, right? > > > > The patches fix both an inconvenience (one that started this bug report= , > > I'd say it is serious enough to make users stumped) and a bug. See my > > previous message in this bug report for details. > > Thanks for the explanations. > > Stefan, any thoughts on whether this is safe for emacs-27? --=20 Jo=C3=A3o T=C3=A1vora