From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#60557: [PATCH] Fix eglot prompt when connection already exists Date: Mon, 16 Jan 2023 14:42:25 +0000 Message-ID: References: <83cz7kksd2.fsf@gnu.org> <87sfggrplc.fsf@gmail.com> <87y1q24rx1.fsf@gmail.com> <83pmbe4lbz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000054704b05f26292d6" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15019"; mail-complaints-to="usenet@ciao.gmane.io" Cc: evgeni.d.kolev@gmail.com, 60557@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 16 15:42:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pHQgq-0003hl-Np for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Jan 2023 15:42:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHQga-0006mH-3G; Mon, 16 Jan 2023 09:42:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHQgU-0006lV-KQ for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2023 09:42:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHQgU-00084R-CS for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2023 09:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pHQgU-0006gz-8G for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2023 09:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Jan 2023 14:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60557 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60557-submit@debbugs.gnu.org id=B60557.167388006825657 (code B ref 60557); Mon, 16 Jan 2023 14:42:02 +0000 Original-Received: (at 60557) by debbugs.gnu.org; 16 Jan 2023 14:41:08 +0000 Original-Received: from localhost ([127.0.0.1]:32780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHQfb-0006fj-Ur for submit@debbugs.gnu.org; Mon, 16 Jan 2023 09:41:08 -0500 Original-Received: from mail-ot1-f43.google.com ([209.85.210.43]:36545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHQfY-0006eo-SU for 60557@debbugs.gnu.org; Mon, 16 Jan 2023 09:41:06 -0500 Original-Received: by mail-ot1-f43.google.com with SMTP id x25-20020a056830115900b00670932eff32so16206258otq.3 for <60557@debbugs.gnu.org>; Mon, 16 Jan 2023 06:41:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XNWWB+9W7W+q3PIdlm2P2NQeSAsfvSMjbKeTjEaGXEM=; b=bt9MemOkQy3xQaDmxjvS23J0b/TaA2mU08L2gZhAgyEDQsAUQqPComxc1XISjRSyrI XP3Ri2td53RkYM0/+G0NIoHN+fJv5dLvUIskxchYTJza2dF7mjEG6jQRiG9rn6Ib2nJl LSOaR8wvvsYjNvO5KHQx/IhmD0xmUL16S+PbhshUtE+U6OUvhP+TLvf1hBZAcMZQ7xwg dmFSWnsnZnx5V+3Khs739X3bEC23FskhnXfMoA8J21hcU3ZMArVdAJUSqn89OYuj07Nf ckbCkmZV+xLQ1smWdWHh19xx/TD3heDZBFOaaVWeLNOxyJMhU/bB2DYmj2WJhpkMdeYF CBfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XNWWB+9W7W+q3PIdlm2P2NQeSAsfvSMjbKeTjEaGXEM=; b=yzT1b71HmKuZSv/zIUl6TkHgFVExxkhSJuW8ExvEQ1b65kkK0uj4hRuXR7Sm2hd0w3 XyyJk984qz/OpUFJVT21TVkPpZyxxOFaZSJ6/YCz+hfQZ3ohGPTjWAktAGKbQUvxNGgb TxAX71S7hfVBrfV1FuqN6gh5p2A60ucE6AMQrP4v5+vJpdP3lNNjPJ7lu9SHt//I3cOi INZVpqwgnvcW4H3sFI3eKP65tZnrK99zDrZoAWeMZBSM+yS9Vnrq19QLk3I7U9PrN5X4 P1/8gMETvAECZOUO7aFNGzU6NTdQDaA/BbsxxpvJKZ64wUQKnO3gfqaJzf0zkZdJKfkY Yq3A== X-Gm-Message-State: AFqh2kpCxOUqJFx94uBwmssrPw+lU0msktUxujN+9Re25BJ2cwxfXecH 2gqnz9WuEzKkJHFkCjPLrpFzHhp9iKQl91i/n/o= X-Google-Smtp-Source: AMrXdXu0S/bpjkVKRV7BYlbqUyGpZhf6fFrRqzWoGQf/hVMrJNhd90IKUrwWmBukAikuR4NehvIBO+WMLIeWWiQDnYY= X-Received: by 2002:a05:6830:6481:b0:684:9f72:3fe3 with SMTP id ck1-20020a056830648100b006849f723fe3mr1453724otb.201.1673880059276; Mon, 16 Jan 2023 06:40:59 -0800 (PST) In-Reply-To: <83pmbe4lbz.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253497 Archived-At: --00000000000054704b05f26292d6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jan 16, 2023 at 2:15 PM Eli Zaretskii wrote: > > > From: Jo=C3=A3o T=C3=A1vora > > Cc: Eli Zaretskii , 60557@debbugs.gnu.org > > Date: Mon, 16 Jan 2023 11:53:14 +0000 > > > > [ Eli, I pushed this change to emacs-29 as this in effect a bugfix and > > Eglot is a new package anyway. Let me know if you'd rather I push this > > to master instead (it doesn't make much of a difference in practice > > since eglot.el is a GNU ELPA packge) ] > > The release branch is OK for this kind of changes, thanks. > > However, note that this change now causes > > In eglot: > progmodes/eglot.el:1078:44: Warning: Unused lexical argument `interactive' > > because the INTERACTIVE argument is now unused. You're right, I missed that. Sorry. > Should it be renamed to _interactive? Yes, that would be fine. As would removing the argument entirely. M-x eglot is _not_ meant to be called from Lisp at at all, but some time ago I found at least one user on emacs-devel was doing so. So removing it may break some code (that is probably already broken anyway, but still...). Jo=C3=A3o --00000000000054704b05f26292d6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Jan 16, 2023 at 2:15 PM Eli Zaretskii <eliz@gnu.org> wrote:
>
> &g= t; From: Jo=C3=A3o T=C3=A1vora <= joaotavora@gmail.com>
> > Cc: Eli Zaretskii <eliz@gnu.org>, =C2=A060557@debbugs.gnu.org
> > Date: Mon, 16 Jan 202= 3 11:53:14 +0000
> >
> > [ Eli, I pushed this change to e= macs-29 as this in effect a bugfix and
> > Eglot is a new package = anyway.=C2=A0 Let me know if you'd rather I push this
> > to m= aster instead (it doesn't make much of a difference in practice
>= > since eglot.el is a GNU ELPA packge) ]
>
> The release br= anch is OK for this kind of changes, thanks.
>
> However, note = that this change now causes
>
> =C2=A0 In eglot:
> =C2=A0= progmodes/eglot.el:1078:44: Warning: Unused lexical argument `interactive&= #39;
>
> because the INTERACTIVE argument is now unused.
You're right, I missed that. Sorry.
=C2=A0
> Shou= ld it be renamed to _interactive?

Yes, that would be fine.=C2=A0 As = would removing=C2=A0 the argument entirely.

M= -x eglot is _not_ meant=C2=A0 to be called from Lisp at at all, but some ti= me
ago I found at least one user on emacs-devel was doing so= .=C2=A0 So removing
it may break some code (that is probably= already broken anyway, but still...).

Jo=C3=A3o
--00000000000054704b05f26292d6--