From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62198: eglot feature request: set Initialize.ClientInfo.{Name, Version} Date: Thu, 3 Aug 2023 11:15:50 +0100 Message-ID: References: <87cz1es23m.fsf@betli.tmit.bme.hu> <87351psckc.fsf@betli.tmit.bme.hu> <831qgkzi9d.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18633"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62198@debbugs.gnu.org, Felician Nemeth , adonovan@google.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 03 12:14:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qRVLe-0004fJ-Og for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Aug 2023 12:14:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRVLI-0001yN-TQ; Thu, 03 Aug 2023 06:14:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRVLH-0001xu-Kl for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 06:14:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qRVLG-0002ed-Fy for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 06:14:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qRVLG-0005Oj-1o for bug-gnu-emacs@gnu.org; Thu, 03 Aug 2023 06:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Aug 2023 10:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62198 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62198-submit@debbugs.gnu.org id=B62198.169105761020699 (code B ref 62198); Thu, 03 Aug 2023 10:14:02 +0000 Original-Received: (at 62198) by debbugs.gnu.org; 3 Aug 2023 10:13:30 +0000 Original-Received: from localhost ([127.0.0.1]:50922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRVKj-0005Nn-Kq for submit@debbugs.gnu.org; Thu, 03 Aug 2023 06:13:29 -0400 Original-Received: from mail-ot1-x32d.google.com ([2607:f8b0:4864:20::32d]:60424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qRVKh-0005NX-JA for 62198@debbugs.gnu.org; Thu, 03 Aug 2023 06:13:28 -0400 Original-Received: by mail-ot1-x32d.google.com with SMTP id 46e09a7af769-6bc9811558cso709950a34.0 for <62198@debbugs.gnu.org>; Thu, 03 Aug 2023 03:13:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691057602; x=1691662402; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SYGUY/u3A6Dm1I9SO/2StB9viJSbpjVonDKb7IlxBI0=; b=L1IC3UbPptOuVOPcrUV1nhQbCe8XFx71HxH4BSlsYvJEeRtO7c5+BIJ49PuxpJaanO qvIB/Tm2+X6NHceh7qg6U6fr7t3RoC2yxA4c8V8zHrXsHNRHrSBfAvblXnxVqeR5KF9h fw/Ej3k3uzTFI4yqCdm8tp3a+m+Q2in8APsJeF7AsKci/kPnEc+A4ofmgGmvrFKmWJ76 zzNZKNccOXY4zxLE55VSFCD80oikG9BQo9SdNwgMOIGn4hwQf0s3CY+OrW+MqdfmFXfj F0ryMtYyYG2H6J2JeokNXR1FWON8xaAzhd2E9CQOJA8hzcn78Er2D2SwGrs5bf6OkDuv cv6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691057602; x=1691662402; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SYGUY/u3A6Dm1I9SO/2StB9viJSbpjVonDKb7IlxBI0=; b=hldr3ok4ql9PCdcXx4Ll4vVyNikk8+rX2MxYEPRkytMBDTI6fyIJ7TCyvlTbD1MUN3 Zhg3YmXRt/RLikUgwST6BbswS9OohIYqTOM4u2QBKSaq+eh1CTgp1bKrXvcjTVm6DTBs IbLYOAiL5wfslAKbep1LSWh/TbkfvtNvrrOfce2AUCxegt+RjR0c+wF2AXzM3+/kLHqS K9TH5gyPInVSAhoIBhzQPgHrlkzUWJmsrUEThs8uuprvLzx7+zLsse4UF2Q7LaPojZjc ONufH4jCxBCGDFjW4bR86tDleDOBQO99Z2MK8yELz2cw+zSgcxHAXrXt2iNEA74rYU1R Tidg== X-Gm-Message-State: ABy/qLaYeX8ZF/JNUPAv1uhnGGkeAAHAE8eR//bz0ICGrmoVSVEy7DZz nSoTj56Etx+rGtwSvr87FTpUYgYr2aHtblFrcPo= X-Google-Smtp-Source: APBJJlFc6/c6cAxNcyw0DYdm1z/wo23sQNAyJtuzQ8XYcA4JwUDp2rUBSyrUwiTsaXXbzxRmC/EeV1qzYTJl9mWm5GY= X-Received: by 2002:a05:6871:723:b0:1b0:5bf7:3bac with SMTP id f35-20020a056871072300b001b05bf73bacmr19831704oap.37.1691057601689; Thu, 03 Aug 2023 03:13:21 -0700 (PDT) In-Reply-To: <831qgkzi9d.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266579 Archived-At: Sorry, I think Felici=C3=A1n's patch looks good, and we should push it to master. Jo=C3=A3o On Thu, Aug 3, 2023 at 8:39=E2=80=AFAM Eli Zaretskii wrote: > > > Cc: 62198@debbugs.gnu.org, Alan Donovan > > From: Felician Nemeth > > Date: Sat, 15 Jul 2023 12:18:11 +0200 > > > > >> If Eglot is installed, then it is byte-compiled as well. The earlie= r > > >> patch in this bug report made sure that the helper library ('lisp-mn= t) > > >> was required only at compile time. However, the patch worked even i= f > > >> Eglot was not installed with package.el (but Eglot still needed to b= e > > >> byte-compiled). > > > > > I thinkt the lisp-mnt-at-compile-time solution is preferable, as I'm > > > not sure 'eglot always lives in package-alist (sometimes it is a > > > built-in and that is a royal pain). Can you show an > > > updated patch for it, when you have time, Felici=C3=A1n? > > > > I've attached the updated patch. > > Ping! Jo=C3=A3o, how should we proceed with this issue? > > Thanks. --=20 Jo=C3=A3o T=C3=A1vora