Re: emacs-29 9c0d7bb73b 2/2: Add automated tests for Eglot

["João Távora" <joaotavora@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1476 bytes --]

Hi Stefan,

Are you seeing these failures on Emacs's CI infrastructure (EMBA,
If I'm not mistaken), or on your own machine? Tests run fine on
my machine.

I'm going to assume this was on your machine from now on.

It seems you have some language servers and language
toolchains installed but that, for some reason, they are not behaving
as they should.

In tests such as 'project-wide-diagnostics-rust-analyzer' an additional
"skip-unless"  check for "cargo" was missing.  I've now fixed that.  Can you
explain why you have a "rust-analyzer" executable, but not "cargo"? Is
this a usual Rust setup?

In other tests, such as 'javascript-basic',
'project-wide-diagnostics-typescript',
the error is strange:

(error "[eglot] -32603: Request initialize failed with message:
  Could not find a valid tsserver version. Exiting.")

I don't know what this can mean. Again, it seems you have
"typescript-language-server", but somehow "no valid tsserver".

In general, I don't know if it's a good idea to keep these tests in the
normal 'make check' run, since many Eglot tests are dependent
on having correctly working servers.  Or at least what I and other test
authors believe to be "correctly configured".  Which is generally the
simplest installation method for said servers, with the fewest bells
and whistles.

Let me know if you've investigated your setup for these servers (again,
I'm assuming this is on your machine and not EMBA).

João

[-- Attachment #2: Type: text/html, Size: 1781 bytes --]