From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#67152: [PATCH] Fix flymake integration in lua-ts-mode Date: Tue, 14 Nov 2023 14:23:29 +0000 Message-ID: References: <583004a793d54e48e65df38209bace3b6932c98b@pub.pink> <83wmuks9rq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000088ebe9060a1d8802" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11777"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67152@debbugs.gnu.org, jm@pub.pink To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 14 15:24:39 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r2uLH-0002mq-Mk for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Nov 2023 15:24:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r2uL1-0005xp-W1; Tue, 14 Nov 2023 09:24:24 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r2uKz-0005xd-NI for bug-gnu-emacs@gnu.org; Tue, 14 Nov 2023 09:24:21 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r2uKy-0004qi-4s for bug-gnu-emacs@gnu.org; Tue, 14 Nov 2023 09:24:20 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r2uLe-0005zo-9o for bug-gnu-emacs@gnu.org; Tue, 14 Nov 2023 09:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Nov 2023 14:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67152 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67152-submit@debbugs.gnu.org id=B67152.169997187222994 (code B ref 67152); Tue, 14 Nov 2023 14:25:02 +0000 Original-Received: (at 67152) by debbugs.gnu.org; 14 Nov 2023 14:24:32 +0000 Original-Received: from localhost ([127.0.0.1]:60644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2uLA-0005yn-E0 for submit@debbugs.gnu.org; Tue, 14 Nov 2023 09:24:32 -0500 Original-Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]:44351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r2uL7-0005yV-QU for 67152@debbugs.gnu.org; Tue, 14 Nov 2023 09:24:31 -0500 Original-Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-507f1c29f25so7770678e87.1 for <67152@debbugs.gnu.org>; Tue, 14 Nov 2023 06:23:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699971821; x=1700576621; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=agvgmt2LN567Ba9b8B95KlbztuboEhZqrIm9oGFtdnw=; b=Gq344DN4RxVfYtMa/LG6BxJvExQzpd25IZu31T1wKiF9ySUHMFyZbFsPMZyMPgke7l kZRP89pY7Xw4Ieskupl4CkRdYhk9s5sJ8baLJbPqqGeTX7OlRTrYfl+pRIhtlY7cbnp4 a1Y4/jtoOOg7b9mHjnT4jqnc6faHCsT1l8o8rIAMEHfPSvjfLJKOYnFWf+vmuSFMgbqX O3RA/gHWPwfi8aIY16WqDaO5af+UfMT0xMLaulyhrzDSOJE56fA1TVa3f7qIUul82H1o CYYfp3+HgWS+eVCTk80uBMx6jDcj0IJ+RQrx9N67W67hCwA+8YWD6p+0FRKhZ+3F9ylL C5dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699971821; x=1700576621; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=agvgmt2LN567Ba9b8B95KlbztuboEhZqrIm9oGFtdnw=; b=Aa5WBuzdZMSRVS2P/uIpaoYP3xvExg6UGKrbKFdcrwWtd6J6ikzpn8AMoLiViHtuX/ N3da2twX89Pk4BzzOiF9W+BaQeEiPbAj+BpjE+wFf/9si3jwSb2EU1QINXdE4qmvHwnQ +NrViPehzObpmX042o6a2AWQTxiNsrPMXZ2Z4WO/EUdRbAuzT9+NDAy/w1Mb8jhj/DZx 5z63aFOqGSDHLy7jPh34NyMQIfbcP6xlUzcZwRjcnuRvVOTAhVIVbH7ByMFOYZyMtv18 hQh5EtkjB7pBK8e021RvI9lrq7C7q/bGHEypmG5uzaBXSlfr6ruDkcZOSYeTR4hTchPa J9qQ== X-Gm-Message-State: AOJu0Yyc0B1Qw8O4Wl6i9Mn3P9YH88yFakMVDMTVZ04wezZJoVV8izF5 dA/40X6iATNGj7Bzyoo3pSW7HqxA3r9U3FcWaKU= X-Google-Smtp-Source: AGHT+IEw0vCZroCl7fDiE2iwrbxMxbJESOOGFuz42uCpBqJZEZq5RWXUnVKiWAJmC8MEIuCAPqR+QISVCetX0CsRmII= X-Received: by 2002:a05:6512:b82:b0:503:8fa:da21 with SMTP id b2-20020a0565120b8200b0050308fada21mr8930501lfv.43.1699971821266; Tue, 14 Nov 2023 06:23:41 -0800 (PST) In-Reply-To: <83wmuks9rq.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274319 Archived-At: --00000000000088ebe9060a1d8802 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Nov 14, 2023 at 2:13=E2=80=AFPM Eli Zaretskii wrote: > > Date: Mon, 13 Nov 2023 22:40:36 +0000 > > TLS-Required: No > > From: jm--- via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > > Jo=C3=A3o, is this OK? > Oooof hard to say. But no I don't think so. You see the type of the object changing in the call to flymake-make-diagnostic? That could be seriously problematic for non-buffer-local diagnostics of some backends. And another call to flymake-diag-region? Can you point me to the first message in this thread via a debbugs URL, or to one where a clear Emacs -Q recipe is given? Thanks, Jo=C3=A3o --00000000000088ebe9060a1d8802 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Nov 14, 2023 at 2:13=E2=80=AFPM Eli Zaretskii <eliz@gnu.org> wrote:
= > Date: Mon, 13 Nov 2023 22:40:36 +0000
> TLS-Required: No
> From: jm--- via "Bug reports for GNU Emacs,
>=C2=A0 the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>

Jo=C3=A3o, is this OK?

Oooof hard to sa= y.=C2=A0 But no I don't think so.=C2=A0 You see the type
of t= he object changing in the call to flymake-make-diagnostic?
That could be seriousl= y problematic for non-buffer-local diagnostics of=C2=A0
some=C2=A0=C2=A0backends.

<= /div>
And another call to flymake-diag-region?

Can you = point me to the first message in this thread via a debbugs
URL, o= r to one where a clear Emacs -Q recipe is given?

T= hanks,
Jo=C3=A3o
--00000000000088ebe9060a1d8802--