From: "João Távora" <joaotavora@gmail.com>
To: 44671@debbugs.gnu.org
Cc: david@dgreaves.com
Subject: bug#44671: 28.0.50; Require Emacs 26.1, nor Emacs 26.3, in project.el and xref.el core packages
Date: Mon, 16 Nov 2020 00:45:10 +0000 [thread overview]
Message-ID: <CALDnm52-SFOdHRFnux8SmBiUJG5SDdZ-QeSj5O0kyscMYuHbbg@mail.gmail.com> (raw)
In-Reply-To: <877dqmkwtr.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2198 bytes --]
Forgot to include the link to the original bug report
https://github.com/joaotavora/eglot/issues/562
João
On Sun, Nov 15, 2020 at 11:47 PM João Távora <joaotavora@gmail.com> wrote:
> Hi,
>
> Some time ago, I made these two files into GNU ELPA "core" packages, and
> I chose Emacs 26.3 as the minimum required version. That was rather
> arbitrary and I should have selected Emacs 26.1 instead.
>
> This is because these packages are required by Eglot, which for now, is
> specified to work in Emacs 26.1.
>
> Recently an Eglot user complained that he could no longer run Eglot in
> that Emacs version, stating that Emacs 26.1 is the version of Emacs
> distributed with Debian stable.
>
> So, I've (briefly) tested these two files in Emacs 26.1 and things seem
> to work, so I propose the simple change in the patch after my sig. If
> no-one opposes, I'll push in few days or so.
>
> João
>
> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
> index a395453491..82eb6f6976 100644
> --- a/lisp/progmodes/project.el
> +++ b/lisp/progmodes/project.el
> @@ -1,8 +1,8 @@
> ;;; project.el --- Operations on the current project -*-
> lexical-binding: t; -*-
>
> ;; Copyright (C) 2015-2020 Free Software Foundation, Inc.
> -;; Version: 0.5.2
> -;; Package-Requires: ((emacs "26.3") (xref "1.0.2"))
> +;; Version: 0.5.3
> +;; Package-Requires: ((emacs "26.1") (xref "1.0.2"))
>
> ;; This is a GNU ELPA :core package. Avoid using functionality that
> ;; not compatible with the version of Emacs recorded above.
> diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
> index e1dd6e56bb..0fd1770cc1 100644
> --- a/lisp/progmodes/xref.el
> +++ b/lisp/progmodes/xref.el
> @@ -1,8 +1,8 @@
> ;;; xref.el --- Cross-referencing commands
> -*-lexical-binding:t-*-
>
> ;; Copyright (C) 2014-2020 Free Software Foundation, Inc.
> -;; Version: 1.0.3
> -;; Package-Requires: ((emacs "26.3"))
> +;; Version: 1.0.4
> +;; Package-Requires: ((emacs "26.1"))
>
> ;; This is a GNU ELPA :core package. Avoid functionality that is not
> ;; compatible with the version of Emacs recorded above.
>
>
>
>
--
João Távora
[-- Attachment #2: Type: text/html, Size: 2863 bytes --]
next prev parent reply other threads:[~2020-11-16 0:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 23:46 bug#44671: 28.0.50; Require Emacs 26.1, nor Emacs 26.3, in project.el and xref.el core packages João Távora
2020-11-16 0:45 ` João Távora [this message]
2021-01-27 3:39 ` Lars Ingebrigtsen
2021-01-27 10:09 ` João Távora
2021-01-27 18:14 ` Dmitry Gutov
2021-01-28 3:18 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm52-SFOdHRFnux8SmBiUJG5SDdZ-QeSj5O0kyscMYuHbbg@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=44671@debbugs.gnu.org \
--cc=david@dgreaves.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.