From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Eglot tests on EMBA Date: Wed, 29 Mar 2023 15:46:36 +0100 Message-ID: References: <87y1nyi5cq.fsf@gmx.de> <87tty3eide.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000bba59a05f80b0ba0" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7063"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 29 16:47:57 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1phX5g-0001YP-27 for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Mar 2023 16:47:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phX4g-0005EC-7W; Wed, 29 Mar 2023 10:46:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phX4e-0005Dq-LB for emacs-devel@gnu.org; Wed, 29 Mar 2023 10:46:52 -0400 Original-Received: from mail-il1-x130.google.com ([2607:f8b0:4864:20::130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1phX4c-0000W2-5W for emacs-devel@gnu.org; Wed, 29 Mar 2023 10:46:52 -0400 Original-Received: by mail-il1-x130.google.com with SMTP id e6so8204182ilu.9 for ; Wed, 29 Mar 2023 07:46:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680101209; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=i4G57A3VOaP5QmcTGIJJeG6Eou6xwxLtQy/4d5L4bXE=; b=nJDgnhKhAXIbJYIjXnEDoQRBtFtUWGXNWCh/7gX5a1FEtGkMvJsmIFJwhRXMWxVk0w 4dPH0LV3UZ4kDNknSY5uMsgAbRL0UQbf0JJHlmAA+6H3aZV7qRvICB3Ef6v9MQ7xjF3d giv0rbL211GKoVpA/v0KfpJfYWvLH1jWjr/AxVQSY4Mz4Dot3eSP+fVLipyL2/vE+fOq tO1l4FESmpUv6KEYbnWHtdHCf+dcxqxBFzouBkUKV9a3gPdU3RMBwPINSEMtnhdlJgbK vPAXVcsRHDIJ8kVOpbK7V7auWQXn+h4VmBbhyurFFREgoN9qOyzaL6tva2BDnHmueQDN F9kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680101209; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i4G57A3VOaP5QmcTGIJJeG6Eou6xwxLtQy/4d5L4bXE=; b=NhRLazESIVIGYvlI7ocTQHs6OUtP5ahhLf4SLdIVZT+VzoxmrOu1BTDVKHKtXzy+s1 atuDmQahSxSWa7hk3RGGPKkJ0EFrOaelMLZbxNuBr8v8sFe7DCHM66osfmAd9VwaP+YL 8b5arDzcnaSJQcM/Ax2aBvOi39I3OL2mduV/Vomz0XYNGHVFGlq9rkuoMT5nTWuKYY4U SJn056dxJvxc+f5F/kSimdexqgGW4UoYGXAecWBYMXHEzdUqwEi7ussJ50HJzYPYwyMA quyNgVUhNzGtmlgGLZkvkseGBmNs7xYl+2xXBTLvxbdZFpoOfvqtTkfBaKQ0u7ASbHBk zJTg== X-Gm-Message-State: AAQBX9e3xyKGIhG9ozU1zEg3ODTuhcvHwOiccMryacah23AQ6n4GM18c BGJMhjIRAaESLjj+WGPWrqRCva8rBSC17ndUXQJAi2pm X-Google-Smtp-Source: AKy350aOQ/2EvQ29UN55pZ+/LLlgnto1JVQIna/stzVUauOt/WlVE37kniAiMUb3a6pxmANAT4oU2ku44rw6V/5HyYU= X-Received: by 2002:a05:6e02:1bed:b0:314:24e2:5189 with SMTP id y13-20020a056e021bed00b0031424e25189mr10272645ilv.0.1680101208726; Wed, 29 Mar 2023 07:46:48 -0700 (PDT) In-Reply-To: <87tty3eide.fsf@gmx.de> Received-SPF: pass client-ip=2607:f8b0:4864:20::130; envelope-from=joaotavora@gmail.com; helo=mail-il1-x130.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304820 Archived-At: --000000000000bba59a05f80b0ba0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I can check the eldoc/eglot tests later, looks like I introduced it in a recent commit and the test might need updating. Jo=C3=A3o On Wed, Mar 29, 2023, 15:34 Michael Albinus wrote: > Michael Albinus writes: > > Hi, > > > FTR, I have changed test/infra/Dockerfile.emba to install also clangd o= n > > the server. This shall enable some of the Eglot tests, which are skippe= d > > at all ATM. Pushed to the emacs-29 branch. > > This has been extended for the master branch. On EMBA, there are now two > jobs build-image-eglot and test-eglot, which run in every scheduled > pipeline for the master branch. See for example > and > . The result, > eglot-tests.log from the latter job, can be retrieved as artifact via > . > > While 36 (of 50) tests pass, we have also one failing and 13 skipped jobs= : > > --8<---------------cut here---------------start------------->8--- > Ran 50 tests, 36 results as expected, 1 unexpected, 13 skipped (2023-03-2= 9 > 14:07:00+0000, 75.388590 sec) > > 1 unexpected results: > FAILED eglot-test-multiline-eldoc "eglot--tests-force-full-eldoc > didn't deliver" > > 13 skipped results: > SKIPPED eglot-test-eclipse-connect ((skip-unless (executable-find > "jdtls")) :form (executable-find "jdtls") :value nil) > SKIPPED eglot-test-javascript-basic ((skip-unless (and > (executable-find "typescript-language-server") (executable-find > "tsserver"))) :form (and (executable-find "typescript-language-server") > (executable-find "tsserver")) :value nil) > SKIPPED eglot-test-json-basic ((skip-unless (executable-find > "vscode-json-languageserver")) :form (executable-find > "vscode-json-languageserver") :value nil) > SKIPPED eglot-test-path-to-uri-windows ((skip-unless (eq system-type > 'windows-nt)) :form (eq gnu/linux windows-nt) :value nil) > SKIPPED eglot-test-project-wide-diagnostics-rust-analyzer > ((skip-unless (executable-find "rust-analyzer")) :form (executable-find > "rust-analyzer") :value nil) > SKIPPED eglot-test-project-wide-diagnostics-typescript ((skip-unless > (and (executable-find "typescript-language-server") (executable-find > "tsserver"))) :form (and (executable-find "typescript-language-server") > (executable-find "tsserver")) :value nil) > SKIPPED eglot-test-python-autopep-formatting ((skip-unless (and > (executable-find "pylsp") (executable-find "autopep8"))) :form (and > (executable-find "pylsp") (executable-find "autopep8")) :value nil) > SKIPPED eglot-test-python-yapf-formatting ((skip-unless (and > (executable-find "pylsp") (not (executable-find "autopep8")) (or > (executable-find "yapf") (executable-find "yapf3")))) :form (and > (executable-find "pylsp") (not (executable-find "autopep8")) (or > (executable-find "yapf") (executable-find "yapf3"))) :value nil) > SKIPPED eglot-test-rust-analyzer-hover-after-edit ((skip-unless > (executable-find "rust-analyzer")) :form (executable-find "rust-analyzer"= ) > :value nil) > SKIPPED eglot-test-rust-analyzer-watches-files ((skip-unless > (executable-find "rust-analyzer")) :form (executable-find "rust-analyzer"= ) > :value nil) > SKIPPED eglot-test-rust-on-type-formatting ((skip-unless > (executable-find "rust-analyzer")) :form (executable-find "rust-analyzer"= ) > :value nil) > SKIPPED eglot-test-snippet-completions ((skip-unless (and > (executable-find "pylsp") (functionp 'yas-minor-mode))) :form (and > (executable-find "pylsp") (functionp 'yas-minor-mode)) :value nil) > SKIPPED eglot-test-snippet-completions-with-company ((skip-unless (an= d > (executable-find "pylsp") (functionp 'yas-minor-mode) (functionp > 'company-complete))) :form (and (executable-find "pylsp") (functionp > 'yas-minor-mode) (functionp 'company-complete)) :value nil) > --8<---------------cut here---------------end--------------->8--- > > Could somebody check why the test eglot-test-multiline-eldoc fails? And > are there recipes how to install the missing dependencies in Debian > bullseye, in order to activate the missing tests? I've digged for > recipes of clangd and pylisp (see test/infra/Dockerfile.emba target > emacs-eglot); doing it for the other dependencies would be too much for > me. > > Best regards, Michael. > --000000000000bba59a05f80b0ba0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I can check the eldoc/eglot tests later, looks like I int= roduced it in a recent commit and the test might need updating.

Jo=C3=A3o

On Wed, Mar 29, 2023, 15:3= 4 Michael Albinus <michael.albinus@gmx.de> wrote:
Michael Albinus <michael.alb= inus@gmx.de> writes:

Hi,

> FTR, I have changed test/infra/Dockerfile.emba to install also clangd = on
> the server. This shall enable some of the Eglot tests, which are skipp= ed
> at all ATM. Pushed to the emacs-29 branch.

This has been extended for the master branch. On EMBA, there are now two jobs build-image-eglot and test-eglot, which run in every scheduled
pipeline for the master branch. See for example
<https://emba.gnu.org/emacs/em= acs/-/jobs/65322> and
<https://emba.gnu.org/emacs/em= acs/-/jobs/65324>. The result,
eglot-tests.log from the latter job, can be retrieved as artifact via
<https://em= ba.gnu.org/emacs/emacs/-/jobs/65324/artifacts/download>.

While 36 (of 50) tests pass, we have also one failing and 13 skipped jobs:<= br>
--8<---------------cut here---------------start------------->8---
Ran 50 tests, 36 results as expected, 1 unexpected, 13 skipped (2023-03-29 = 14:07:00+0000, 75.388590 sec)

1 unexpected results:
=C2=A0 =C2=A0FAILED=C2=A0 eglot-test-multiline-eldoc=C2=A0 "eglot--tes= ts-force-full-eldoc didn't deliver"

13 skipped results:
=C2=A0 SKIPPED=C2=A0 eglot-test-eclipse-connect=C2=A0 ((skip-unless (execut= able-find "jdtls")) :form (executable-find "jdtls") :va= lue nil)
=C2=A0 SKIPPED=C2=A0 eglot-test-javascript-basic=C2=A0 ((skip-unless (and (= executable-find "typescript-language-server") (executable-find &q= uot;tsserver"))) :form (and (executable-find "typescript-language= -server") (executable-find "tsserver")) :value nil)
=C2=A0 SKIPPED=C2=A0 eglot-test-json-basic=C2=A0 ((skip-unless (executable-= find "vscode-json-languageserver")) :form (executable-find "= vscode-json-languageserver") :value nil)
=C2=A0 SKIPPED=C2=A0 eglot-test-path-to-uri-windows=C2=A0 ((skip-unless (eq= system-type 'windows-nt)) :form (eq gnu/linux windows-nt) :value nil)<= br> =C2=A0 SKIPPED=C2=A0 eglot-test-project-wide-diagnostics-rust-analyzer=C2= =A0 ((skip-unless (executable-find "rust-analyzer")) :form (execu= table-find "rust-analyzer") :value nil)
=C2=A0 SKIPPED=C2=A0 eglot-test-project-wide-diagnostics-typescript=C2=A0 (= (skip-unless (and (executable-find "typescript-language-server") = (executable-find "tsserver"))) :form (and (executable-find "= typescript-language-server") (executable-find "tsserver")) := value nil)
=C2=A0 SKIPPED=C2=A0 eglot-test-python-autopep-formatting=C2=A0 ((skip-unle= ss (and (executable-find "pylsp") (executable-find "autopep8= "))) :form (and (executable-find "pylsp") (executable-find &= quot;autopep8")) :value nil)
=C2=A0 SKIPPED=C2=A0 eglot-test-python-yapf-formatting=C2=A0 ((skip-unless = (and (executable-find "pylsp") (not (executable-find "autope= p8")) (or (executable-find "yapf") (executable-find "ya= pf3")))) :form (and (executable-find "pylsp") (not (executab= le-find "autopep8")) (or (executable-find "yapf") (exec= utable-find "yapf3"))) :value nil)
=C2=A0 SKIPPED=C2=A0 eglot-test-rust-analyzer-hover-after-edit=C2=A0 ((skip= -unless (executable-find "rust-analyzer")) :form (executable-find= "rust-analyzer") :value nil)
=C2=A0 SKIPPED=C2=A0 eglot-test-rust-analyzer-watches-files=C2=A0 ((skip-un= less (executable-find "rust-analyzer")) :form (executable-find &q= uot;rust-analyzer") :value nil)
=C2=A0 SKIPPED=C2=A0 eglot-test-rust-on-type-formatting=C2=A0 ((skip-unless= (executable-find "rust-analyzer")) :form (executable-find "= rust-analyzer") :value nil)
=C2=A0 SKIPPED=C2=A0 eglot-test-snippet-completions=C2=A0 ((skip-unless (an= d (executable-find "pylsp") (functionp 'yas-minor-mode))) :fo= rm (and (executable-find "pylsp") (functionp 'yas-minor-mode)= ) :value nil)
=C2=A0 SKIPPED=C2=A0 eglot-test-snippet-completions-with-company=C2=A0 ((sk= ip-unless (and (executable-find "pylsp") (functionp 'yas-mino= r-mode) (functionp 'company-complete))) :form (and (executable-find &qu= ot;pylsp") (functionp 'yas-minor-mode) (functionp 'company-com= plete)) :value nil)
--8<---------------cut here---------------end--------------->8---

Could somebody check why the test eglot-test-multiline-eldoc fails? And
are there recipes how to install the missing dependencies in Debian
bullseye, in order to activate the missing tests? I've digged for
recipes of clangd and pylisp (see test/infra/Dockerfile.emba target
emacs-eglot); doing it for the other dependencies would be too much for
me.

Best regards, Michael.
--000000000000bba59a05f80b0ba0--